Re: [PATCH v4 3/3] serial: amba-pl011: add ACPI support to AMBA probe

2016-01-06 Thread Graeme Gregory
On Tue, Jan 05, 2016 at 10:23:08AM -0600, Timur Tabi wrote: > G Gregory wrote: > >>>I'm confused by this patch. We already have code like this in > >>>tty-next, in the form of sbsa_uart_probe(): > >>> >

Re: [PATCH v4 3/3] serial: amba-pl011: add ACPI support to AMBA probe

2016-01-06 Thread Graeme Gregory
On Tue, Jan 05, 2016 at 10:23:08AM -0600, Timur Tabi wrote: > G Gregory wrote: > >>>I'm confused by this patch. We already have code like this in > >>>tty-next, in the form of sbsa_uart_probe(): > >>> >

Re: [PATCH v4 3/3] serial: amba-pl011: add ACPI support to AMBA probe

2016-01-05 Thread Timur Tabi
G Gregory wrote: >I'm confused by this patch. We already have code like this in >tty-next, in the form of sbsa_uart_probe(): > >https://kernel.googlesource.com/pub/scm/linux/kernel/git/gregkh/tty/+/tty-next/drivers/tty/serial/amba-pl011.c#2553 > Because Russell expressed unhappiness at that

Re: [PATCH v4 3/3] serial: amba-pl011: add ACPI support to AMBA probe

2016-01-05 Thread G Gregory
On 4 January 2016 at 23:13, Timur Tabi wrote: > On Wed, Dec 23, 2015 at 8:19 AM, Aleksey Makarov > wrote: >> From: Graeme Gregory >> >> In ACPI this device is only defined in SBSA mode so >> if we are coming from ACPI use this mode. >> >> Signed-off-by: Graeme Gregory >> Signed-off-by: Aleksey

Re: [PATCH v4 3/3] serial: amba-pl011: add ACPI support to AMBA probe

2016-01-05 Thread G Gregory
On 4 January 2016 at 23:13, Timur Tabi wrote: > On Wed, Dec 23, 2015 at 8:19 AM, Aleksey Makarov > wrote: >> From: Graeme Gregory >> >> In ACPI this device is only defined in SBSA mode so >> if we are coming from ACPI

Re: [PATCH v4 3/3] serial: amba-pl011: add ACPI support to AMBA probe

2016-01-05 Thread Timur Tabi
G Gregory wrote: >I'm confused by this patch. We already have code like this in >tty-next, in the form of sbsa_uart_probe(): > >https://kernel.googlesource.com/pub/scm/linux/kernel/git/gregkh/tty/+/tty-next/drivers/tty/serial/amba-pl011.c#2553 > Because Russell expressed unhappiness at that

Re: [PATCH v4 3/3] serial: amba-pl011: add ACPI support to AMBA probe

2016-01-04 Thread Timur Tabi
On Wed, Dec 23, 2015 at 8:19 AM, Aleksey Makarov wrote: > From: Graeme Gregory > > In ACPI this device is only defined in SBSA mode so > if we are coming from ACPI use this mode. > > Signed-off-by: Graeme Gregory > Signed-off-by: Aleksey Makarov > --- > drivers/tty/serial/amba-pl011.c | 37

Re: [PATCH v4 3/3] serial: amba-pl011: add ACPI support to AMBA probe

2016-01-04 Thread Timur Tabi
On Wed, Dec 23, 2015 at 8:19 AM, Aleksey Makarov wrote: > From: Graeme Gregory > > In ACPI this device is only defined in SBSA mode so > if we are coming from ACPI use this mode. > > Signed-off-by: Graeme Gregory

[PATCH v4 3/3] serial: amba-pl011: add ACPI support to AMBA probe

2015-12-23 Thread Aleksey Makarov
From: Graeme Gregory In ACPI this device is only defined in SBSA mode so if we are coming from ACPI use this mode. Signed-off-by: Graeme Gregory Signed-off-by: Aleksey Makarov --- drivers/tty/serial/amba-pl011.c | 37 ++--- 1 file changed, 26 insertions(+), 11

[PATCH v4 3/3] serial: amba-pl011: add ACPI support to AMBA probe

2015-12-23 Thread Aleksey Makarov
From: Graeme Gregory In ACPI this device is only defined in SBSA mode so if we are coming from ACPI use this mode. Signed-off-by: Graeme Gregory Signed-off-by: Aleksey Makarov ---