Re: [PATCH v4 3/4] scmi-cpufreq: get opp_shared_cpus from opp-v2 for EM

2020-12-09 Thread Sudeep Holla
On Wed, Dec 09, 2020 at 11:15:02AM +0530, Viresh Kumar wrote: > On 08-12-20, 11:20, Sudeep Holla wrote: > > It is because of per-CPU vs per domain drama here. Imagine a system with > > 4 CPUs which the firmware puts in individual domains while they all are > > in the same perf domain and hence OPP

Re: [PATCH v4 3/4] scmi-cpufreq: get opp_shared_cpus from opp-v2 for EM

2020-12-09 Thread Nicola Mazzucato
Hi both, thanks for looking into this. On 12/9/20 5:45 AM, Viresh Kumar wrote: > On 08-12-20, 11:20, Sudeep Holla wrote: >> It is because of per-CPU vs per domain drama here. Imagine a system with >> 4 CPUs which the firmware puts in individual domains while they all are >> in the same perf

Re: [PATCH v4 3/4] scmi-cpufreq: get opp_shared_cpus from opp-v2 for EM

2020-12-08 Thread Viresh Kumar
On 08-12-20, 11:20, Sudeep Holla wrote: > It is because of per-CPU vs per domain drama here. Imagine a system with > 4 CPUs which the firmware puts in individual domains while they all are > in the same perf domain and hence OPP is marked shared in DT. > > Since this probe gets called for all the

Re: [PATCH v4 3/4] scmi-cpufreq: get opp_shared_cpus from opp-v2 for EM

2020-12-08 Thread Nicola Mazzucato
Hi All, thanks for your feedback, please see below On 12/8/20 12:22 PM, Sudeep Holla wrote: > On Tue, Dec 08, 2020 at 11:34:36AM +, Lukasz Luba wrote: >> >> >> On 12/8/20 11:20 AM, Sudeep Holla wrote: >>> On Tue, Dec 08, 2020 at 12:56:11PM +0530, Viresh Kumar wrote: On 08-12-20, 07:22,

Re: [PATCH v4 3/4] scmi-cpufreq: get opp_shared_cpus from opp-v2 for EM

2020-12-08 Thread Sudeep Holla
On Tue, Dec 08, 2020 at 11:34:36AM +, Lukasz Luba wrote: > > > On 12/8/20 11:20 AM, Sudeep Holla wrote: > > On Tue, Dec 08, 2020 at 12:56:11PM +0530, Viresh Kumar wrote: > > > On 08-12-20, 07:22, Nicola Mazzucato wrote: > > > > On 12/8/20 5:50 AM, Viresh Kumar wrote: > > > > > On 02-12-20,

Re: [PATCH v4 3/4] scmi-cpufreq: get opp_shared_cpus from opp-v2 for EM

2020-12-08 Thread Lukasz Luba
On 12/8/20 11:20 AM, Sudeep Holla wrote: On Tue, Dec 08, 2020 at 12:56:11PM +0530, Viresh Kumar wrote: On 08-12-20, 07:22, Nicola Mazzucato wrote: On 12/8/20 5:50 AM, Viresh Kumar wrote: On 02-12-20, 17:23, Nicola Mazzucato wrote: nr_opp = dev_pm_opp_get_opp_count(cpu_dev);

Re: [PATCH v4 3/4] scmi-cpufreq: get opp_shared_cpus from opp-v2 for EM

2020-12-08 Thread Sudeep Holla
On Tue, Dec 08, 2020 at 04:31:48PM +0530, Viresh Kumar wrote: > On 08-12-20, 10:58, Nicola Mazzucato wrote: > > > > > > On 12/8/20 7:26 AM, Viresh Kumar wrote: > > > On 08-12-20, 07:22, Nicola Mazzucato wrote: > > >> On 12/8/20 5:50 AM, Viresh Kumar wrote: > > >>> On 02-12-20, 17:23, Nicola

Re: [PATCH v4 3/4] scmi-cpufreq: get opp_shared_cpus from opp-v2 for EM

2020-12-08 Thread Sudeep Holla
On Tue, Dec 08, 2020 at 12:56:11PM +0530, Viresh Kumar wrote: > On 08-12-20, 07:22, Nicola Mazzucato wrote: > > On 12/8/20 5:50 AM, Viresh Kumar wrote: > > > On 02-12-20, 17:23, Nicola Mazzucato wrote: > > >> nr_opp = dev_pm_opp_get_opp_count(cpu_dev); > > >> if (nr_opp <= 0) { >

Re: [PATCH v4 3/4] scmi-cpufreq: get opp_shared_cpus from opp-v2 for EM

2020-12-08 Thread Viresh Kumar
On 08-12-20, 10:58, Nicola Mazzucato wrote: > > > On 12/8/20 7:26 AM, Viresh Kumar wrote: > > On 08-12-20, 07:22, Nicola Mazzucato wrote: > >> On 12/8/20 5:50 AM, Viresh Kumar wrote: > >>> On 02-12-20, 17:23, Nicola Mazzucato wrote: > nr_opp = dev_pm_opp_get_opp_count(cpu_dev); >

Re: [PATCH v4 3/4] scmi-cpufreq: get opp_shared_cpus from opp-v2 for EM

2020-12-08 Thread Nicola Mazzucato
On 12/8/20 7:26 AM, Viresh Kumar wrote: > On 08-12-20, 07:22, Nicola Mazzucato wrote: >> On 12/8/20 5:50 AM, Viresh Kumar wrote: >>> On 02-12-20, 17:23, Nicola Mazzucato wrote: nr_opp = dev_pm_opp_get_opp_count(cpu_dev); if (nr_opp <= 0) { - dev_dbg(cpu_dev, "OPP

Re: [PATCH v4 3/4] scmi-cpufreq: get opp_shared_cpus from opp-v2 for EM

2020-12-07 Thread Viresh Kumar
On 08-12-20, 07:22, Nicola Mazzucato wrote: > On 12/8/20 5:50 AM, Viresh Kumar wrote: > > On 02-12-20, 17:23, Nicola Mazzucato wrote: > >>nr_opp = dev_pm_opp_get_opp_count(cpu_dev); > >>if (nr_opp <= 0) { > >> - dev_dbg(cpu_dev, "OPP table is not ready, deferring probe\n"); > >> -

Re: [PATCH v4 3/4] scmi-cpufreq: get opp_shared_cpus from opp-v2 for EM

2020-12-07 Thread Nicola Mazzucato
Hi Viresh, thanks for looking into this. Please find below On 12/8/20 5:50 AM, Viresh Kumar wrote: > On 02-12-20, 17:23, Nicola Mazzucato wrote: >> By design, SCMI performance domains define the granularity of >> performance controls, they do not describe any underlying hardware >> dependencies

Re: [PATCH v4 3/4] scmi-cpufreq: get opp_shared_cpus from opp-v2 for EM

2020-12-07 Thread Viresh Kumar
On 02-12-20, 17:23, Nicola Mazzucato wrote: > By design, SCMI performance domains define the granularity of > performance controls, they do not describe any underlying hardware > dependencies (although they may match in many cases). > > It is therefore possible to have some platforms where

[PATCH v4 3/4] scmi-cpufreq: get opp_shared_cpus from opp-v2 for EM

2020-12-02 Thread Nicola Mazzucato
By design, SCMI performance domains define the granularity of performance controls, they do not describe any underlying hardware dependencies (although they may match in many cases). It is therefore possible to have some platforms where hardware may have the ability to control CPU performance at