Re: [PATCH v4 3/5] pagemap: rework hugetlb and thp report

2015-07-24 Thread Mark Williamson
(my review on this patch comes with the caveat that the specifics of hugetlb / thp are a bit outside my experience) On Fri, Jul 24, 2015 at 7:17 PM, Mark Williamson wrote: > Reviewed-by: Mark Williamson > > On Tue, Jul 21, 2015 at 9:43 AM, Konstantin Khlebnikov > wrote: >> On Tue, Jul 21,

Re: [PATCH v4 3/5] pagemap: rework hugetlb and thp report

2015-07-24 Thread Mark Williamson
Reviewed-by: Mark Williamson On Tue, Jul 21, 2015 at 9:43 AM, Konstantin Khlebnikov wrote: > On Tue, Jul 21, 2015 at 11:00 AM, Naoya Horiguchi > wrote: >> On Tue, Jul 14, 2015 at 06:37:39PM +0300, Konstantin Khlebnikov wrote: >>> This patch moves pmd dissection out of reporting loop: huge

Re: [PATCH v4 3/5] pagemap: rework hugetlb and thp report

2015-07-24 Thread Mark Williamson
Reviewed-by: Mark Williamson mwilliam...@undo-software.com On Tue, Jul 21, 2015 at 9:43 AM, Konstantin Khlebnikov koc...@gmail.com wrote: On Tue, Jul 21, 2015 at 11:00 AM, Naoya Horiguchi n-horigu...@ah.jp.nec.com wrote: On Tue, Jul 14, 2015 at 06:37:39PM +0300, Konstantin Khlebnikov wrote:

Re: [PATCH v4 3/5] pagemap: rework hugetlb and thp report

2015-07-24 Thread Mark Williamson
(my review on this patch comes with the caveat that the specifics of hugetlb / thp are a bit outside my experience) On Fri, Jul 24, 2015 at 7:17 PM, Mark Williamson mwilliam...@undo-software.com wrote: Reviewed-by: Mark Williamson mwilliam...@undo-software.com On Tue, Jul 21, 2015 at 9:43 AM,

Re: [PATCH v4 3/5] pagemap: rework hugetlb and thp report

2015-07-21 Thread Konstantin Khlebnikov
On Tue, Jul 21, 2015 at 11:00 AM, Naoya Horiguchi wrote: > On Tue, Jul 14, 2015 at 06:37:39PM +0300, Konstantin Khlebnikov wrote: >> This patch moves pmd dissection out of reporting loop: huge pages >> are reported as bunch of normal pages with contiguous PFNs. >> >> Add missing "FILE" bit in

Re: [PATCH v4 3/5] pagemap: rework hugetlb and thp report

2015-07-21 Thread Naoya Horiguchi
On Tue, Jul 14, 2015 at 06:37:39PM +0300, Konstantin Khlebnikov wrote: > This patch moves pmd dissection out of reporting loop: huge pages > are reported as bunch of normal pages with contiguous PFNs. > > Add missing "FILE" bit in hugetlb vmas. > > Signed-off-by: Konstantin Khlebnikov With

Re: [PATCH v4 3/5] pagemap: rework hugetlb and thp report

2015-07-21 Thread Naoya Horiguchi
On Tue, Jul 14, 2015 at 06:37:39PM +0300, Konstantin Khlebnikov wrote: This patch moves pmd dissection out of reporting loop: huge pages are reported as bunch of normal pages with contiguous PFNs. Add missing FILE bit in hugetlb vmas. Signed-off-by: Konstantin Khlebnikov

Re: [PATCH v4 3/5] pagemap: rework hugetlb and thp report

2015-07-21 Thread Konstantin Khlebnikov
On Tue, Jul 21, 2015 at 11:00 AM, Naoya Horiguchi n-horigu...@ah.jp.nec.com wrote: On Tue, Jul 14, 2015 at 06:37:39PM +0300, Konstantin Khlebnikov wrote: This patch moves pmd dissection out of reporting loop: huge pages are reported as bunch of normal pages with contiguous PFNs. Add missing

Re: [PATCH v4 3/5] pagemap: rework hugetlb and thp report

2015-07-19 Thread Kirill A. Shutemov
On Tue, Jul 14, 2015 at 06:37:39PM +0300, Konstantin Khlebnikov wrote: > @@ -1073,35 +1047,48 @@ static int pagemap_pte_range(pmd_t *pmd, unsigned > long addr, unsigned long end, > pte_t *pte, *orig_pte; > int err = 0; > > - if (pmd_trans_huge_lock(pmd, vma, ) == 1) { > -

Re: [PATCH v4 3/5] pagemap: rework hugetlb and thp report

2015-07-19 Thread Kirill A. Shutemov
On Tue, Jul 14, 2015 at 06:37:39PM +0300, Konstantin Khlebnikov wrote: @@ -1073,35 +1047,48 @@ static int pagemap_pte_range(pmd_t *pmd, unsigned long addr, unsigned long end, pte_t *pte, *orig_pte; int err = 0; - if (pmd_trans_huge_lock(pmd, vma, ptl) == 1) { -

[PATCH v4 3/5] pagemap: rework hugetlb and thp report

2015-07-14 Thread Konstantin Khlebnikov
This patch moves pmd dissection out of reporting loop: huge pages are reported as bunch of normal pages with contiguous PFNs. Add missing "FILE" bit in hugetlb vmas. Signed-off-by: Konstantin Khlebnikov --- fs/proc/task_mmu.c | 100 +++- 1 file

[PATCH v4 3/5] pagemap: rework hugetlb and thp report

2015-07-14 Thread Konstantin Khlebnikov
This patch moves pmd dissection out of reporting loop: huge pages are reported as bunch of normal pages with contiguous PFNs. Add missing FILE bit in hugetlb vmas. Signed-off-by: Konstantin Khlebnikov khlebni...@yandex-team.ru --- fs/proc/task_mmu.c | 100