Re: [PATCH v4 3/5] watchdog: iTCO_wdt: Add PMC specific noreboot update api

2017-04-02 Thread Sathyanarayanan Kuppuswamy Natarajan
Hi, On Sun, Apr 2, 2017 at 7:04 AM, Andy Shevchenko wrote: > On Sat, Apr 1, 2017 at 2:27 AM, Kuppuswamy Sathyanarayanan > wrote: >> In some SOCs, setting noreboot bit needs modification to > > SoCs. > > Perhaps you can create a wikipage to share with your team what style > issues usually needs t

Re: [PATCH v4 3/5] watchdog: iTCO_wdt: Add PMC specific noreboot update api

2017-04-02 Thread Andy Shevchenko
On Sat, Apr 1, 2017 at 2:27 AM, Kuppuswamy Sathyanarayanan wrote: > In some SOCs, setting noreboot bit needs modification to SoCs. Perhaps you can create a wikipage to share with your team what style issues usually needs to be addressed. One of them is a proper capitalization in abbreviations /

[PATCH v4 3/5] watchdog: iTCO_wdt: Add PMC specific noreboot update api

2017-03-31 Thread Kuppuswamy Sathyanarayanan
In some SOCs, setting noreboot bit needs modification to PMC GC registers. But not all PMC drivers allow other drivers to memory map their GC region. This could create mem request conflict in watchdog driver. So this patch adds facility to allow PMC drivers to pass noreboot update function to watch