Re: [PATCH v4 3/5] x86/umwait: Add sysfs interface to control umwait C0.2 state

2019-06-17 Thread Fenghua Yu
On Mon, Jun 17, 2019 at 05:19:02PM -0700, Andy Lutomirski wrote: > On Mon, Jun 17, 2019 at 5:09 PM Fenghua Yu wrote: > But you're already using a mutex and a comment. And you're hoping > that the syscore resume callback reads something sensible despite the > lack of READ_ONCE / WRITE_ONCE. The

Re: [PATCH v4 3/5] x86/umwait: Add sysfs interface to control umwait C0.2 state

2019-06-17 Thread Andy Lutomirski
On Mon, Jun 17, 2019 at 5:09 PM Fenghua Yu wrote: > > On Mon, Jun 17, 2019 at 04:41:38PM -0700, Andy Lutomirski wrote: > > On Mon, Jun 17, 2019 at 4:20 PM Fenghua Yu wrote: > > > > > > On Mon, Jun 17, 2019 at 04:02:50PM -0700, Andy Lutomirski wrote: > > > > On Mon, Jun 17, 2019 at 1:36 PM

Re: [PATCH v4 3/5] x86/umwait: Add sysfs interface to control umwait C0.2 state

2019-06-17 Thread Fenghua Yu
On Mon, Jun 17, 2019 at 04:41:38PM -0700, Andy Lutomirski wrote: > On Mon, Jun 17, 2019 at 4:20 PM Fenghua Yu wrote: > > > > On Mon, Jun 17, 2019 at 04:02:50PM -0700, Andy Lutomirski wrote: > > > On Mon, Jun 17, 2019 at 1:36 PM Fenghua Yu wrote: > > > > > > > > On Mon, Jun 10, 2019 at 06:41:31AM

Re: [PATCH v4 3/5] x86/umwait: Add sysfs interface to control umwait C0.2 state

2019-06-17 Thread Andy Lutomirski
On Mon, Jun 17, 2019 at 4:20 PM Fenghua Yu wrote: > > On Mon, Jun 17, 2019 at 04:02:50PM -0700, Andy Lutomirski wrote: > > On Mon, Jun 17, 2019 at 1:36 PM Fenghua Yu wrote: > > > > > > On Mon, Jun 10, 2019 at 06:41:31AM -0700, Andy Lutomirski wrote: > > > > > > > > > > > > > On Jun 9, 2019, at

Re: [PATCH v4 3/5] x86/umwait: Add sysfs interface to control umwait C0.2 state

2019-06-17 Thread Fenghua Yu
On Mon, Jun 17, 2019 at 04:02:50PM -0700, Andy Lutomirski wrote: > On Mon, Jun 17, 2019 at 1:36 PM Fenghua Yu wrote: > > > > On Mon, Jun 10, 2019 at 06:41:31AM -0700, Andy Lutomirski wrote: > > > > > > > > > > On Jun 9, 2019, at 11:02 PM, Fenghua Yu wrote: > > > > > > > >> On Sun, Jun 09, 2019

Re: [PATCH v4 3/5] x86/umwait: Add sysfs interface to control umwait C0.2 state

2019-06-17 Thread Andy Lutomirski
On Mon, Jun 17, 2019 at 1:36 PM Fenghua Yu wrote: > > On Mon, Jun 10, 2019 at 06:41:31AM -0700, Andy Lutomirski wrote: > > > > > > > On Jun 9, 2019, at 11:02 PM, Fenghua Yu wrote: > > > > > >> On Sun, Jun 09, 2019 at 09:24:18PM -0700, Andy Lutomirski wrote: > > >>> On Sun, Jun 9, 2019 at 9:02 PM

Re: [PATCH v4 3/5] x86/umwait: Add sysfs interface to control umwait C0.2 state

2019-06-17 Thread Fenghua Yu
On Mon, Jun 17, 2019 at 03:59:28PM -0700, Andy Lutomirski wrote: > On Mon, Jun 17, 2019 at 3:57 PM Fenghua Yu wrote: > > > > On Sun, Jun 09, 2019 at 09:26:29PM -0700, Andy Lutomirski wrote: > > > On Sun, Jun 9, 2019 at 9:14 PM Fenghua Yu wrote: > > > > > > > > On Sat, Jun 08, 2019 at 03:52:03PM

Re: [PATCH v4 3/5] x86/umwait: Add sysfs interface to control umwait C0.2 state

2019-06-17 Thread Andy Lutomirski
On Mon, Jun 17, 2019 at 3:57 PM Fenghua Yu wrote: > > On Sun, Jun 09, 2019 at 09:26:29PM -0700, Andy Lutomirski wrote: > > On Sun, Jun 9, 2019 at 9:14 PM Fenghua Yu wrote: > > > > > > On Sat, Jun 08, 2019 at 03:52:03PM -0700, Andy Lutomirski wrote: > > > > On Fri, Jun 7, 2019 at 3:10 PM Fenghua

Re: [PATCH v4 3/5] x86/umwait: Add sysfs interface to control umwait C0.2 state

2019-06-17 Thread Fenghua Yu
On Sun, Jun 09, 2019 at 09:26:29PM -0700, Andy Lutomirski wrote: > On Sun, Jun 9, 2019 at 9:14 PM Fenghua Yu wrote: > > > > On Sat, Jun 08, 2019 at 03:52:03PM -0700, Andy Lutomirski wrote: > > > On Fri, Jun 7, 2019 at 3:10 PM Fenghua Yu wrote: > > > > > > > > C0.2 state in umwait and tpause

Re: [PATCH v4 3/5] x86/umwait: Add sysfs interface to control umwait C0.2 state

2019-06-17 Thread Fenghua Yu
On Mon, Jun 10, 2019 at 06:41:31AM -0700, Andy Lutomirski wrote: > > > > On Jun 9, 2019, at 11:02 PM, Fenghua Yu wrote: > > > >> On Sun, Jun 09, 2019 at 09:24:18PM -0700, Andy Lutomirski wrote: > >>> On Sun, Jun 9, 2019 at 9:02 PM Fenghua Yu wrote: > >>> > On Sat, Jun 08, 2019 at

Re: [PATCH v4 3/5] x86/umwait: Add sysfs interface to control umwait C0.2 state

2019-06-17 Thread Fenghua Yu
On Mon, Jun 17, 2019 at 08:14:44AM -0700, Andy Lutomirski wrote: > On Tue, Jun 11, 2019 at 10:27 AM Peter Zijlstra wrote: > > > > > > (can you, perchance, look at a MUA that isn't 'broken' ?) > > > > On Tue, Jun 11, 2019 at 09:04:30AM -0700, Andy Lutomirski wrote: > > > > > > > > > > On Jun 11,

Re: [PATCH v4 3/5] x86/umwait: Add sysfs interface to control umwait C0.2 state

2019-06-17 Thread Andy Lutomirski
On Tue, Jun 11, 2019 at 10:27 AM Peter Zijlstra wrote: > > > (can you, perchance, look at a MUA that isn't 'broken' ?) > > On Tue, Jun 11, 2019 at 09:04:30AM -0700, Andy Lutomirski wrote: > > > > > > > On Jun 11, 2019, at 1:54 AM, Peter Zijlstra wrote: > > > > > >> On Fri, Jun 07, 2019 at

Re: [PATCH v4 3/5] x86/umwait: Add sysfs interface to control umwait C0.2 state

2019-06-11 Thread Peter Zijlstra
(can you, perchance, look at a MUA that isn't 'broken' ?) On Tue, Jun 11, 2019 at 09:04:30AM -0700, Andy Lutomirski wrote: > > > > On Jun 11, 2019, at 1:54 AM, Peter Zijlstra wrote: > > > >> On Fri, Jun 07, 2019 at 03:00:35PM -0700, Fenghua Yu wrote: > >> C0.2 state in umwait and tpause

Re: [PATCH v4 3/5] x86/umwait: Add sysfs interface to control umwait C0.2 state

2019-06-11 Thread Andy Lutomirski
> On Jun 11, 2019, at 1:54 AM, Peter Zijlstra wrote: > >> On Fri, Jun 07, 2019 at 03:00:35PM -0700, Fenghua Yu wrote: >> C0.2 state in umwait and tpause instructions can be enabled or disabled >> on a processor through IA32_UMWAIT_CONTROL MSR register. >> >> By default, C0.2 is enabled and

Re: [PATCH v4 3/5] x86/umwait: Add sysfs interface to control umwait C0.2 state

2019-06-11 Thread Peter Zijlstra
On Fri, Jun 07, 2019 at 03:00:35PM -0700, Fenghua Yu wrote: > C0.2 state in umwait and tpause instructions can be enabled or disabled > on a processor through IA32_UMWAIT_CONTROL MSR register. > > By default, C0.2 is enabled and the user wait instructions result in > lower power consumption with

Re: [PATCH v4 3/5] x86/umwait: Add sysfs interface to control umwait C0.2 state

2019-06-10 Thread Andy Lutomirski
> On Jun 9, 2019, at 11:02 PM, Fenghua Yu wrote: > >> On Sun, Jun 09, 2019 at 09:24:18PM -0700, Andy Lutomirski wrote: >>> On Sun, Jun 9, 2019 at 9:02 PM Fenghua Yu wrote: >>> On Sat, Jun 08, 2019 at 03:50:32PM -0700, Andy Lutomirski wrote: > On Fri, Jun 7, 2019 at 3:10 PM Fenghua

Re: [PATCH v4 3/5] x86/umwait: Add sysfs interface to control umwait C0.2 state

2019-06-10 Thread Fenghua Yu
On Sun, Jun 09, 2019 at 09:24:18PM -0700, Andy Lutomirski wrote: > On Sun, Jun 9, 2019 at 9:02 PM Fenghua Yu wrote: > > > > On Sat, Jun 08, 2019 at 03:50:32PM -0700, Andy Lutomirski wrote: > > > On Fri, Jun 7, 2019 at 3:10 PM Fenghua Yu wrote: > > > > > > > > C0.2 state in umwait and tpause

Re: [PATCH v4 3/5] x86/umwait: Add sysfs interface to control umwait C0.2 state

2019-06-09 Thread Andy Lutomirski
On Sun, Jun 9, 2019 at 9:14 PM Fenghua Yu wrote: > > On Sat, Jun 08, 2019 at 03:52:03PM -0700, Andy Lutomirski wrote: > > On Fri, Jun 7, 2019 at 3:10 PM Fenghua Yu wrote: > > > > > > C0.2 state in umwait and tpause instructions can be enabled or disabled > > > on a processor through

Re: [PATCH v4 3/5] x86/umwait: Add sysfs interface to control umwait C0.2 state

2019-06-09 Thread Andy Lutomirski
On Sun, Jun 9, 2019 at 9:02 PM Fenghua Yu wrote: > > On Sat, Jun 08, 2019 at 03:50:32PM -0700, Andy Lutomirski wrote: > > On Fri, Jun 7, 2019 at 3:10 PM Fenghua Yu wrote: > > > > > > C0.2 state in umwait and tpause instructions can be enabled or disabled > > > on a processor through

Re: [PATCH v4 3/5] x86/umwait: Add sysfs interface to control umwait C0.2 state

2019-06-09 Thread Fenghua Yu
On Sat, Jun 08, 2019 at 03:52:03PM -0700, Andy Lutomirski wrote: > On Fri, Jun 7, 2019 at 3:10 PM Fenghua Yu wrote: > > > > C0.2 state in umwait and tpause instructions can be enabled or disabled > > on a processor through IA32_UMWAIT_CONTROL MSR register. > > > > > +static u32

Re: [PATCH v4 3/5] x86/umwait: Add sysfs interface to control umwait C0.2 state

2019-06-09 Thread Fenghua Yu
On Sat, Jun 08, 2019 at 03:50:32PM -0700, Andy Lutomirski wrote: > On Fri, Jun 7, 2019 at 3:10 PM Fenghua Yu wrote: > > > > C0.2 state in umwait and tpause instructions can be enabled or disabled > > on a processor through IA32_UMWAIT_CONTROL MSR register. > > > > By default, C0.2 is enabled and

Re: [PATCH v4 3/5] x86/umwait: Add sysfs interface to control umwait C0.2 state

2019-06-08 Thread Andy Lutomirski
On Fri, Jun 7, 2019 at 3:10 PM Fenghua Yu wrote: > > C0.2 state in umwait and tpause instructions can be enabled or disabled > on a processor through IA32_UMWAIT_CONTROL MSR register. > > +static u32 get_umwait_control_c02(void) > +{ > + return umwait_control_cached &

Re: [PATCH v4 3/5] x86/umwait: Add sysfs interface to control umwait C0.2 state

2019-06-08 Thread Andy Lutomirski
On Fri, Jun 7, 2019 at 3:10 PM Fenghua Yu wrote: > > C0.2 state in umwait and tpause instructions can be enabled or disabled > on a processor through IA32_UMWAIT_CONTROL MSR register. > > By default, C0.2 is enabled and the user wait instructions result in > lower power consumption with slower

[PATCH v4 3/5] x86/umwait: Add sysfs interface to control umwait C0.2 state

2019-06-07 Thread Fenghua Yu
C0.2 state in umwait and tpause instructions can be enabled or disabled on a processor through IA32_UMWAIT_CONTROL MSR register. By default, C0.2 is enabled and the user wait instructions result in lower power consumption with slower wakeup time. But in real time systems which require faster