Re: [PATCH v4 3/6] libnvdimm, acpi, nfit: Add bus level dsm mask for pass thru.

2017-07-05 Thread Dan Williams
On Wed, Jul 5, 2017 at 4:14 PM, Jerry Hoemann wrote: > On Wed, Jul 05, 2017 at 09:35:48AM -0700, Dan Williams wrote: [..] >> It was a mistake to use _DSM for common root-level functionality, and >> we shouldn't double down on that mistake by allowing unfettered > > As to

Re: [PATCH v4 3/6] libnvdimm, acpi, nfit: Add bus level dsm mask for pass thru.

2017-07-05 Thread Dan Williams
On Wed, Jul 5, 2017 at 4:14 PM, Jerry Hoemann wrote: > On Wed, Jul 05, 2017 at 09:35:48AM -0700, Dan Williams wrote: [..] >> It was a mistake to use _DSM for common root-level functionality, and >> we shouldn't double down on that mistake by allowing unfettered > > As to the moral aspects of

Re: [PATCH v4 3/6] libnvdimm, acpi, nfit: Add bus level dsm mask for pass thru.

2017-07-05 Thread Jerry Hoemann
On Wed, Jul 05, 2017 at 09:35:48AM -0700, Dan Williams wrote: > On Wed, Jul 5, 2017 at 9:24 AM, Jerry Hoemann wrote: > > On Tue, Jul 04, 2017 at 01:37:43PM -0700, Dan Williams wrote: > >> On Tue, Jul 4, 2017 at 1:08 PM, Jerry Hoemann > >> wrote: >

Re: [PATCH v4 3/6] libnvdimm, acpi, nfit: Add bus level dsm mask for pass thru.

2017-07-05 Thread Jerry Hoemann
On Wed, Jul 05, 2017 at 09:35:48AM -0700, Dan Williams wrote: > On Wed, Jul 5, 2017 at 9:24 AM, Jerry Hoemann wrote: > > On Tue, Jul 04, 2017 at 01:37:43PM -0700, Dan Williams wrote: > >> On Tue, Jul 4, 2017 at 1:08 PM, Jerry Hoemann > >> wrote: > >> > On Sat, Jul 01, 2017 at 01:46:03PM -0700,

Re: [PATCH v4 3/6] libnvdimm, acpi, nfit: Add bus level dsm mask for pass thru.

2017-07-05 Thread Dan Williams
On Wed, Jul 5, 2017 at 9:24 AM, Jerry Hoemann wrote: > On Tue, Jul 04, 2017 at 01:37:43PM -0700, Dan Williams wrote: >> On Tue, Jul 4, 2017 at 1:08 PM, Jerry Hoemann wrote: >> > On Sat, Jul 01, 2017 at 01:46:03PM -0700, Dan Williams wrote: >> >> On

Re: [PATCH v4 3/6] libnvdimm, acpi, nfit: Add bus level dsm mask for pass thru.

2017-07-05 Thread Dan Williams
On Wed, Jul 5, 2017 at 9:24 AM, Jerry Hoemann wrote: > On Tue, Jul 04, 2017 at 01:37:43PM -0700, Dan Williams wrote: >> On Tue, Jul 4, 2017 at 1:08 PM, Jerry Hoemann wrote: >> > On Sat, Jul 01, 2017 at 01:46:03PM -0700, Dan Williams wrote: >> >> On Sat, Jul 1, 2017 at 1:38 PM, Jerry Hoemann >>

Re: [PATCH v4 3/6] libnvdimm, acpi, nfit: Add bus level dsm mask for pass thru.

2017-07-05 Thread Jerry Hoemann
On Tue, Jul 04, 2017 at 01:37:43PM -0700, Dan Williams wrote: > On Tue, Jul 4, 2017 at 1:08 PM, Jerry Hoemann wrote: > > On Sat, Jul 01, 2017 at 01:46:03PM -0700, Dan Williams wrote: > >> On Sat, Jul 1, 2017 at 1:38 PM, Jerry Hoemann > >> wrote: >

Re: [PATCH v4 3/6] libnvdimm, acpi, nfit: Add bus level dsm mask for pass thru.

2017-07-05 Thread Jerry Hoemann
On Tue, Jul 04, 2017 at 01:37:43PM -0700, Dan Williams wrote: > On Tue, Jul 4, 2017 at 1:08 PM, Jerry Hoemann wrote: > > On Sat, Jul 01, 2017 at 01:46:03PM -0700, Dan Williams wrote: > >> On Sat, Jul 1, 2017 at 1:38 PM, Jerry Hoemann > >> wrote: > >> > On Sat, Jul 01, 2017 at 01:10:31PM -0700,

Re: [PATCH v4 3/6] libnvdimm, acpi, nfit: Add bus level dsm mask for pass thru.

2017-07-05 Thread Linda Knippers
On 07/04/2017 04:37 PM, Dan Williams wrote: > On Tue, Jul 4, 2017 at 1:08 PM, Jerry Hoemann wrote: >> On Sat, Jul 01, 2017 at 01:46:03PM -0700, Dan Williams wrote: >>> On Sat, Jul 1, 2017 at 1:38 PM, Jerry Hoemann wrote: On Sat, Jul 01, 2017 at

Re: [PATCH v4 3/6] libnvdimm, acpi, nfit: Add bus level dsm mask for pass thru.

2017-07-05 Thread Linda Knippers
On 07/04/2017 04:37 PM, Dan Williams wrote: > On Tue, Jul 4, 2017 at 1:08 PM, Jerry Hoemann wrote: >> On Sat, Jul 01, 2017 at 01:46:03PM -0700, Dan Williams wrote: >>> On Sat, Jul 1, 2017 at 1:38 PM, Jerry Hoemann wrote: On Sat, Jul 01, 2017 at 01:10:31PM -0700, Dan Williams wrote: > On

Re: [PATCH v4 3/6] libnvdimm, acpi, nfit: Add bus level dsm mask for pass thru.

2017-07-04 Thread Dan Williams
On Tue, Jul 4, 2017 at 1:08 PM, Jerry Hoemann wrote: > On Sat, Jul 01, 2017 at 01:46:03PM -0700, Dan Williams wrote: >> On Sat, Jul 1, 2017 at 1:38 PM, Jerry Hoemann wrote: >> > On Sat, Jul 01, 2017 at 01:10:31PM -0700, Dan Williams wrote: >> >> On

Re: [PATCH v4 3/6] libnvdimm, acpi, nfit: Add bus level dsm mask for pass thru.

2017-07-04 Thread Dan Williams
On Tue, Jul 4, 2017 at 1:08 PM, Jerry Hoemann wrote: > On Sat, Jul 01, 2017 at 01:46:03PM -0700, Dan Williams wrote: >> On Sat, Jul 1, 2017 at 1:38 PM, Jerry Hoemann wrote: >> > On Sat, Jul 01, 2017 at 01:10:31PM -0700, Dan Williams wrote: >> >> On Sat, Jul 1, 2017 at 1:08 PM, Dan Williams >>

Re: [PATCH v4 3/6] libnvdimm, acpi, nfit: Add bus level dsm mask for pass thru.

2017-07-04 Thread Jerry Hoemann
On Sat, Jul 01, 2017 at 01:46:03PM -0700, Dan Williams wrote: > On Sat, Jul 1, 2017 at 1:38 PM, Jerry Hoemann wrote: > > On Sat, Jul 01, 2017 at 01:10:31PM -0700, Dan Williams wrote: > >> On Sat, Jul 1, 2017 at 1:08 PM, Dan Williams > >> wrote: >

Re: [PATCH v4 3/6] libnvdimm, acpi, nfit: Add bus level dsm mask for pass thru.

2017-07-04 Thread Jerry Hoemann
On Sat, Jul 01, 2017 at 01:46:03PM -0700, Dan Williams wrote: > On Sat, Jul 1, 2017 at 1:38 PM, Jerry Hoemann wrote: > > On Sat, Jul 01, 2017 at 01:10:31PM -0700, Dan Williams wrote: > >> On Sat, Jul 1, 2017 at 1:08 PM, Dan Williams > >> wrote: > >> > On Sat, Jul 1, 2017 at 12:58 PM, Jerry

Re: [PATCH v4 3/6] libnvdimm, acpi, nfit: Add bus level dsm mask for pass thru.

2017-07-01 Thread Dan Williams
On Sat, Jul 1, 2017 at 1:38 PM, Jerry Hoemann wrote: > On Sat, Jul 01, 2017 at 01:10:31PM -0700, Dan Williams wrote: >> On Sat, Jul 1, 2017 at 1:08 PM, Dan Williams >> wrote: >> > On Sat, Jul 1, 2017 at 12:58 PM, Jerry Hoemann

Re: [PATCH v4 3/6] libnvdimm, acpi, nfit: Add bus level dsm mask for pass thru.

2017-07-01 Thread Dan Williams
On Sat, Jul 1, 2017 at 1:38 PM, Jerry Hoemann wrote: > On Sat, Jul 01, 2017 at 01:10:31PM -0700, Dan Williams wrote: >> On Sat, Jul 1, 2017 at 1:08 PM, Dan Williams >> wrote: >> > On Sat, Jul 1, 2017 at 12:58 PM, Jerry Hoemann >> > wrote: >> >> On Fri, Jun 30, 2017 at 08:55:22PM -0700, Dan

Re: [PATCH v4 3/6] libnvdimm, acpi, nfit: Add bus level dsm mask for pass thru.

2017-07-01 Thread Jerry Hoemann
On Sat, Jul 01, 2017 at 01:10:31PM -0700, Dan Williams wrote: > On Sat, Jul 1, 2017 at 1:08 PM, Dan Williams wrote: > > On Sat, Jul 1, 2017 at 12:58 PM, Jerry Hoemann > > wrote: > >> On Fri, Jun 30, 2017 at 08:55:22PM -0700, Dan Williams wrote: >

Re: [PATCH v4 3/6] libnvdimm, acpi, nfit: Add bus level dsm mask for pass thru.

2017-07-01 Thread Jerry Hoemann
On Sat, Jul 01, 2017 at 01:10:31PM -0700, Dan Williams wrote: > On Sat, Jul 1, 2017 at 1:08 PM, Dan Williams wrote: > > On Sat, Jul 1, 2017 at 12:58 PM, Jerry Hoemann > > wrote: > >> On Fri, Jun 30, 2017 at 08:55:22PM -0700, Dan Williams wrote: > >> > >> ... > >> > >>> On Fri, Jun 30, 2017 at

Re: [PATCH v4 3/6] libnvdimm, acpi, nfit: Add bus level dsm mask for pass thru.

2017-07-01 Thread Dan Williams
On Sat, Jul 1, 2017 at 1:08 PM, Dan Williams wrote: > On Sat, Jul 1, 2017 at 12:58 PM, Jerry Hoemann wrote: >> On Fri, Jun 30, 2017 at 08:55:22PM -0700, Dan Williams wrote: >> >> ... >> >>> On Fri, Jun 30, 2017 at 9:09 AM, Jerry Hoemann

Re: [PATCH v4 3/6] libnvdimm, acpi, nfit: Add bus level dsm mask for pass thru.

2017-07-01 Thread Dan Williams
On Sat, Jul 1, 2017 at 1:08 PM, Dan Williams wrote: > On Sat, Jul 1, 2017 at 12:58 PM, Jerry Hoemann wrote: >> On Fri, Jun 30, 2017 at 08:55:22PM -0700, Dan Williams wrote: >> >> ... >> >>> On Fri, Jun 30, 2017 at 9:09 AM, Jerry Hoemann >>> wrote: >>> > + if (cmd == ND_CMD_CALL)

Re: [PATCH v4 3/6] libnvdimm, acpi, nfit: Add bus level dsm mask for pass thru.

2017-07-01 Thread Dan Williams
On Sat, Jul 1, 2017 at 12:58 PM, Jerry Hoemann wrote: > On Fri, Jun 30, 2017 at 08:55:22PM -0700, Dan Williams wrote: > > ... > >> On Fri, Jun 30, 2017 at 9:09 AM, Jerry Hoemann wrote: >> > + if (cmd == ND_CMD_CALL) >> > +

Re: [PATCH v4 3/6] libnvdimm, acpi, nfit: Add bus level dsm mask for pass thru.

2017-07-01 Thread Dan Williams
On Sat, Jul 1, 2017 at 12:58 PM, Jerry Hoemann wrote: > On Fri, Jun 30, 2017 at 08:55:22PM -0700, Dan Williams wrote: > > ... > >> On Fri, Jun 30, 2017 at 9:09 AM, Jerry Hoemann wrote: >> > + if (cmd == ND_CMD_CALL) >> > + dsm_mask = nd_desc->bus_dsm_mask; >>

Re: [PATCH v4 3/6] libnvdimm, acpi, nfit: Add bus level dsm mask for pass thru.

2017-07-01 Thread Jerry Hoemann
On Fri, Jun 30, 2017 at 08:55:22PM -0700, Dan Williams wrote: ... > On Fri, Jun 30, 2017 at 9:09 AM, Jerry Hoemann wrote: > > + if (cmd == ND_CMD_CALL) > > + dsm_mask = nd_desc->bus_dsm_mask; > > desc =

Re: [PATCH v4 3/6] libnvdimm, acpi, nfit: Add bus level dsm mask for pass thru.

2017-07-01 Thread Jerry Hoemann
On Fri, Jun 30, 2017 at 08:55:22PM -0700, Dan Williams wrote: ... > On Fri, Jun 30, 2017 at 9:09 AM, Jerry Hoemann wrote: > > + if (cmd == ND_CMD_CALL) > > + dsm_mask = nd_desc->bus_dsm_mask; > > desc = nd_cmd_bus_desc(cmd); > >

Re: [PATCH v4 3/6] libnvdimm, acpi, nfit: Add bus level dsm mask for pass thru.

2017-06-30 Thread Dan Williams
On Fri, Jun 30, 2017 at 9:09 AM, Jerry Hoemann wrote: > Add a bus level dsm_mask to nvdimm_bus_descriptor to allow the passthru > calling mechanism to specify a different mask from the cmd_mask. > > Populate bus_dsm_mask and use it to filter dsm calls that user can > make

Re: [PATCH v4 3/6] libnvdimm, acpi, nfit: Add bus level dsm mask for pass thru.

2017-06-30 Thread Dan Williams
On Fri, Jun 30, 2017 at 9:09 AM, Jerry Hoemann wrote: > Add a bus level dsm_mask to nvdimm_bus_descriptor to allow the passthru > calling mechanism to specify a different mask from the cmd_mask. > > Populate bus_dsm_mask and use it to filter dsm calls that user can > make through the pass thru

[PATCH v4 3/6] libnvdimm, acpi, nfit: Add bus level dsm mask for pass thru.

2017-06-30 Thread Jerry Hoemann
Add a bus level dsm_mask to nvdimm_bus_descriptor to allow the passthru calling mechanism to specify a different mask from the cmd_mask. Populate bus_dsm_mask and use it to filter dsm calls that user can make through the pass thru interface. Signed-off-by: Jerry Hoemann

[PATCH v4 3/6] libnvdimm, acpi, nfit: Add bus level dsm mask for pass thru.

2017-06-30 Thread Jerry Hoemann
Add a bus level dsm_mask to nvdimm_bus_descriptor to allow the passthru calling mechanism to specify a different mask from the cmd_mask. Populate bus_dsm_mask and use it to filter dsm calls that user can make through the pass thru interface. Signed-off-by: Jerry Hoemann ---