Re: [PATCH v4 3/7] drm/fb-helper: Add fb_deferred_io support

2016-05-02 Thread Daniel Vetter
On Fri, Apr 29, 2016 at 04:47:08PM +0200, Noralf Trønnes wrote: > > Den 29.04.2016 14:50, skrev Tomi Valkeinen: > >Hi, > > > >On 28/04/16 18:18, Noralf Trønnes wrote: > >>This adds deferred io support to drm_fb_helper. > >>The fbdev framebuffer changes are flushed using the callback > >>(struct dr

Re: [PATCH v4 3/7] drm/fb-helper: Add fb_deferred_io support

2016-04-29 Thread Daniel Vetter
Adding David, forgot that before hitting send. -Daniel On Fri, Apr 29, 2016 at 5:36 PM, Daniel Vetter wrote: > On Fri, Apr 29, 2016 at 06:00:18PM +0300, Tomi Valkeinen wrote: >> >> On 29/04/16 17:55, Daniel Vetter wrote: >> >> >> Who's calling {write,fillrect,copyarea,imageblit} in an atomic cont

Re: [PATCH v4 3/7] drm/fb-helper: Add fb_deferred_io support

2016-04-29 Thread Daniel Vetter
On Fri, Apr 29, 2016 at 06:00:18PM +0300, Tomi Valkeinen wrote: > > On 29/04/16 17:55, Daniel Vetter wrote: > > >> Who's calling {write,fillrect,copyarea,imageblit} in an atomic context? > >> That sounds like a very bad idea to me... > >> > >> If this is only for accumulating changes, I think it

Re: [PATCH v4 3/7] drm/fb-helper: Add fb_deferred_io support

2016-04-29 Thread Daniel Vetter
On Fri, Apr 29, 2016 at 03:50:40PM +0300, Tomi Valkeinen wrote: > Hi, > > On 28/04/16 18:18, Noralf Trønnes wrote: > > This adds deferred io support to drm_fb_helper. > > The fbdev framebuffer changes are flushed using the callback > > (struct drm_framebuffer *)->funcs->dirty() by a dedicated work

Re: [PATCH v4 3/7] drm/fb-helper: Add fb_deferred_io support

2016-04-29 Thread Tomi Valkeinen
On 29/04/16 17:55, Daniel Vetter wrote: >> Who's calling {write,fillrect,copyarea,imageblit} in an atomic context? >> That sounds like a very bad idea to me... >> >> If this is only for accumulating changes, I think it may be better to >> leave that to the driver as it may have better idea of how

Re: [PATCH v4 3/7] drm/fb-helper: Add fb_deferred_io support

2016-04-29 Thread Noralf Trønnes
Den 29.04.2016 14:50, skrev Tomi Valkeinen: Hi, On 28/04/16 18:18, Noralf Trønnes wrote: This adds deferred io support to drm_fb_helper. The fbdev framebuffer changes are flushed using the callback (struct drm_framebuffer *)->funcs->dirty() by a dedicated worker ensuring that it always runs in

Re: [PATCH v4 3/7] drm/fb-helper: Add fb_deferred_io support

2016-04-29 Thread Tomi Valkeinen
Hi, On 28/04/16 18:18, Noralf Trønnes wrote: > This adds deferred io support to drm_fb_helper. > The fbdev framebuffer changes are flushed using the callback > (struct drm_framebuffer *)->funcs->dirty() by a dedicated worker > ensuring that it always runs in process context. > > Signed-off-by: No

[PATCH v4 3/7] drm/fb-helper: Add fb_deferred_io support

2016-04-28 Thread Noralf Trønnes
This adds deferred io support to drm_fb_helper. The fbdev framebuffer changes are flushed using the callback (struct drm_framebuffer *)->funcs->dirty() by a dedicated worker ensuring that it always runs in process context. Signed-off-by: Noralf Trønnes Reviewed-by: Daniel Vetter --- Changes sin