Re: [PATCH v4 3/7] mtrr, x86: Remove a wrong address check in __mtrr_type_lookup()

2015-05-06 Thread Borislav Petkov
On Tue, Mar 24, 2015 at 04:08:37PM -0600, Toshi Kani wrote: > __mtrr_type_lookup() checks MTRR fixed ranges when > mtrr_state.have_fixed is set and start is less than > 0x10. However, the 'else if (start < 0x100)' > in the code checks with a wrong address as it has > an extra-zero in the

Re: [PATCH v4 3/7] mtrr, x86: Remove a wrong address check in __mtrr_type_lookup()

2015-05-06 Thread Borislav Petkov
On Tue, Mar 24, 2015 at 04:08:37PM -0600, Toshi Kani wrote: __mtrr_type_lookup() checks MTRR fixed ranges when mtrr_state.have_fixed is set and start is less than 0x10. However, the 'else if (start 0x100)' in the code checks with a wrong address as it has an extra-zero in the

[PATCH v4 3/7] mtrr, x86: Remove a wrong address check in __mtrr_type_lookup()

2015-03-24 Thread Toshi Kani
__mtrr_type_lookup() checks MTRR fixed ranges when mtrr_state.have_fixed is set and start is less than 0x10. However, the 'else if (start < 0x100)' in the code checks with a wrong address as it has an extra-zero in the address. The code still runs correctly as this check is meaningless,

[PATCH v4 3/7] mtrr, x86: Remove a wrong address check in __mtrr_type_lookup()

2015-03-24 Thread Toshi Kani
__mtrr_type_lookup() checks MTRR fixed ranges when mtrr_state.have_fixed is set and start is less than 0x10. However, the 'else if (start 0x100)' in the code checks with a wrong address as it has an extra-zero in the address. The code still runs correctly as this check is meaningless,