Re: [PATCH v4 3/7] regulator: IRQ based event/error notification helpers

2021-04-12 Thread Mark Brown
On Mon, Apr 12, 2021 at 03:24:16PM +0300, Matti Vaittinen wrote: > Maybe this 'hardware protection, in-kernel, emergency HW saving > shutdown' - logic, should be pulled out of thermal_core.c (or at least > exported) for (other parts like) the regulators to use? That sounds sensible.

Re: [PATCH v4 3/7] regulator: IRQ based event/error notification helpers

2021-04-12 Thread Matti Vaittinen
On Fri, 2021-04-09 at 10:08 +0300, Matti Vaittinen wrote: > On Thu, 2021-04-08 at 20:20 -0700, Kees Cook wrote: > > On Wed, Apr 07, 2021 at 03:50:15PM +0300, Andy Shevchenko wrote: > > > On Wed, Apr 7, 2021 at 12:49 PM Vaittinen, Matti > > > wrote: > > > > On Wed, 2021-04-07 at 12:10 +0300,

Re: [PATCH v4 3/7] regulator: IRQ based event/error notification helpers

2021-04-09 Thread Vaittinen, Matti
On Thu, 2021-04-08 at 20:20 -0700, Kees Cook wrote: > On Wed, Apr 07, 2021 at 03:50:15PM +0300, Andy Shevchenko wrote: > > On Wed, Apr 7, 2021 at 12:49 PM Vaittinen, Matti > > wrote: > > > On Wed, 2021-04-07 at 12:10 +0300, Andy Shevchenko wrote: > > > > On Wed, Apr 7, 2021 at 8:02 AM Matti

Re: [PATCH v4 3/7] regulator: IRQ based event/error notification helpers

2021-04-08 Thread Kees Cook
On Wed, Apr 07, 2021 at 03:50:15PM +0300, Andy Shevchenko wrote: > On Wed, Apr 7, 2021 at 12:49 PM Vaittinen, Matti > wrote: > > On Wed, 2021-04-07 at 12:10 +0300, Andy Shevchenko wrote: > > > On Wed, Apr 7, 2021 at 8:02 AM Matti Vaittinen > > > wrote: > > > > On Wed, 2021-04-07 at 01:44 +0300,

Re: [PATCH v4 3/7] regulator: IRQ based event/error notification helpers

2021-04-07 Thread Andy Shevchenko
On Wed, Apr 7, 2021 at 12:49 PM Vaittinen, Matti wrote: > On Wed, 2021-04-07 at 12:10 +0300, Andy Shevchenko wrote: > > On Wed, Apr 7, 2021 at 8:02 AM Matti Vaittinen > > wrote: > > > On Wed, 2021-04-07 at 01:44 +0300, Andy Shevchenko wrote: > > > > On Tuesday, April 6, 2021, Matti Vaittinen < >

Re: [PATCH v4 3/7] regulator: IRQ based event/error notification helpers

2021-04-07 Thread Vaittinen, Matti
Hello Andy, On Wed, 2021-04-07 at 12:10 +0300, Andy Shevchenko wrote: > On Wed, Apr 7, 2021 at 8:02 AM Matti Vaittinen > wrote: > > On Wed, 2021-04-07 at 01:44 +0300, Andy Shevchenko wrote: > > > On Tuesday, April 6, 2021, Matti Vaittinen < > > > matti.vaitti...@fi.rohmeurope.com> wrote: > >

Re: [PATCH v4 3/7] regulator: IRQ based event/error notification helpers

2021-04-07 Thread Andy Shevchenko
On Wed, Apr 7, 2021 at 8:02 AM Matti Vaittinen wrote: > > Morning Andy, > > Thanks for the review! By the way, is it me or did your mail-client > spill this out using HTML? It's Gmail from my mobile phone, sorry for that. We have to blame Google that they don't think through. > On Wed,

Re: [PATCH v4 3/7] regulator: IRQ based event/error notification helpers

2021-04-06 Thread Matti Vaittinen
Morning Andy, Thanks for the review! By the way, is it me or did your mail-client spill this out using HTML? On Wed, 2021-04-07 at 01:44 +0300, Andy Shevchenko wrote: > On Tuesday, April 6, 2021, Matti Vaittinen < > matti.vaitti...@fi.rohmeurope.com> wrote: > > +static void die_loudly(const

Re: [PATCH v4 3/7] regulator: IRQ based event/error notification helpers

2021-04-06 Thread kernel test robot
Hi Matti, I love your patch! Yet something to improve: [auto build test ERROR on v5.12-rc6] [also build test ERROR on next-20210401] [cannot apply to regulator/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base'

Re: [PATCH v4 3/7] regulator: IRQ based event/error notification helpers

2021-04-06 Thread Matti Vaittinen
On Tue, 2021-04-06 at 18:27 +0800, kernel test robot wrote: > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > All errors (new ones prefixed by >>): > >In file included from include/linux/kernel.h:16, > from

Re: [PATCH v4 3/7] regulator: IRQ based event/error notification helpers

2021-04-06 Thread kernel test robot
Hi Matti, I love your patch! Yet something to improve: [auto build test ERROR on v5.12-rc6] [also build test ERROR on next-20210401] [cannot apply to regulator/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base'

[PATCH v4 3/7] regulator: IRQ based event/error notification helpers

2021-04-06 Thread Matti Vaittinen
Provide helper function for IC's implementing regulator notifications when an IRQ fires. The helper also works for IRQs which can not be acked. Helper can be set to disable the IRQ at handler and then re-enabling it on delayed work later. The helper also adds regulator_get_error_flags() errors in