Re: [PATCH v4 3/8] clk: add support for clocks provided by SCP(System Control Processor)

2015-07-22 Thread Sudeep Holla
On 21/07/15 19:05, Stephen Boyd wrote: On 07/20/2015 01:54 AM, Sudeep Holla wrote: On 17/07/15 19:13, Stephen Boyd wrote: On 07/17/2015 04:17 AM, Sudeep Holla wrote: [...] determine_rate change shouldn't affect SCPI clock driver but I remember seeing round_rate change too on the list

Re: [PATCH v4 3/8] clk: add support for clocks provided by SCP(System Control Processor)

2015-07-22 Thread Sudeep Holla
On 21/07/15 19:05, Stephen Boyd wrote: On 07/20/2015 01:54 AM, Sudeep Holla wrote: On 17/07/15 19:13, Stephen Boyd wrote: On 07/17/2015 04:17 AM, Sudeep Holla wrote: [...] determine_rate change shouldn't affect SCPI clock driver but I remember seeing round_rate change too on the list

Re: [PATCH v4 3/8] clk: add support for clocks provided by SCP(System Control Processor)

2015-07-21 Thread Stephen Boyd
On 07/20/2015 01:54 AM, Sudeep Holla wrote: On 17/07/15 19:13, Stephen Boyd wrote: On 07/17/2015 04:17 AM, Sudeep Holla wrote: [...] determine_rate change shouldn't affect SCPI clock driver but I remember seeing round_rate change too on the list which returns value using the argument

Re: [PATCH v4 3/8] clk: add support for clocks provided by SCP(System Control Processor)

2015-07-21 Thread Stephen Boyd
On 07/20/2015 01:54 AM, Sudeep Holla wrote: On 17/07/15 19:13, Stephen Boyd wrote: On 07/17/2015 04:17 AM, Sudeep Holla wrote: [...] determine_rate change shouldn't affect SCPI clock driver but I remember seeing round_rate change too on the list which returns value using the argument

Re: [PATCH v4 3/8] clk: add support for clocks provided by SCP(System Control Processor)

2015-07-20 Thread Sudeep Holla
On 17/07/15 19:13, Stephen Boyd wrote: On 07/17/2015 04:17 AM, Sudeep Holla wrote: [...] determine_rate change shouldn't affect SCPI clock driver but I remember seeing round_rate change too on the list which returns value using the argument from Boris. Is that planned for v4.3 ? I would

Re: [PATCH v4 3/8] clk: add support for clocks provided by SCP(System Control Processor)

2015-07-20 Thread Sudeep Holla
On 17/07/15 19:13, Stephen Boyd wrote: On 07/17/2015 04:17 AM, Sudeep Holla wrote: [...] determine_rate change shouldn't affect SCPI clock driver but I remember seeing round_rate change too on the list which returns value using the argument from Boris. Is that planned for v4.3 ? I would

Re: [PATCH v4 3/8] clk: add support for clocks provided by SCP(System Control Processor)

2015-07-17 Thread Stephen Boyd
On 07/17/2015 04:17 AM, Sudeep Holla wrote: On 16/07/15 20:31, Stephen Boyd wrote: On 07/16, Sudeep Holla wrote: On 08/07/15 02:46, Stephen Boyd wrote: Yes struct clk would have min/max, and struct clk_core would have min/max. Then some sort of provider API (or possibly even clk_init_data)

Re: [PATCH v4 3/8] clk: add support for clocks provided by SCP(System Control Processor)

2015-07-17 Thread Sudeep Holla
On 16/07/15 20:31, Stephen Boyd wrote: On 07/16, Sudeep Holla wrote: On 08/07/15 02:46, Stephen Boyd wrote: Yes struct clk would have min/max, and struct clk_core would have min/max. Then some sort of provider API (or possibly even clk_init_data) would take the min/max fields and copy them

Re: [PATCH v4 3/8] clk: add support for clocks provided by SCP(System Control Processor)

2015-07-17 Thread Sudeep Holla
On 16/07/15 20:31, Stephen Boyd wrote: On 07/16, Sudeep Holla wrote: On 08/07/15 02:46, Stephen Boyd wrote: Yes struct clk would have min/max, and struct clk_core would have min/max. Then some sort of provider API (or possibly even clk_init_data) would take the min/max fields and copy them

Re: [PATCH v4 3/8] clk: add support for clocks provided by SCP(System Control Processor)

2015-07-17 Thread Stephen Boyd
On 07/17/2015 04:17 AM, Sudeep Holla wrote: On 16/07/15 20:31, Stephen Boyd wrote: On 07/16, Sudeep Holla wrote: On 08/07/15 02:46, Stephen Boyd wrote: Yes struct clk would have min/max, and struct clk_core would have min/max. Then some sort of provider API (or possibly even clk_init_data)

Re: [PATCH v4 3/8] clk: add support for clocks provided by SCP(System Control Processor)

2015-07-16 Thread Stephen Boyd
On 07/16, Sudeep Holla wrote: > On 08/07/15 02:46, Stephen Boyd wrote: > > > >Yes struct clk would have min/max, and struct clk_core would have > >min/max. Then some sort of provider API (or possibly even > >clk_init_data) would take the min/max fields and copy them over > >to struct clk_core.

Re: [PATCH v4 3/8] clk: add support for clocks provided by SCP(System Control Processor)

2015-07-16 Thread Sudeep Holla
Hi Stephen, On 08/07/15 02:46, Stephen Boyd wrote: On 07/07, Sudeep Holla wrote: On 06/07/15 20:52, Stephen Boyd wrote: If I have time I may try to start doing the clk_register() conversion, but it will take a while so I doubt it will be in v4.3. I'm asking if you can add a clk_hw based

Re: [PATCH v4 3/8] clk: add support for clocks provided by SCP(System Control Processor)

2015-07-16 Thread Sudeep Holla
Hi Stephen, On 08/07/15 02:46, Stephen Boyd wrote: On 07/07, Sudeep Holla wrote: On 06/07/15 20:52, Stephen Boyd wrote: If I have time I may try to start doing the clk_register() conversion, but it will take a while so I doubt it will be in v4.3. I'm asking if you can add a clk_hw based

Re: [PATCH v4 3/8] clk: add support for clocks provided by SCP(System Control Processor)

2015-07-16 Thread Stephen Boyd
On 07/16, Sudeep Holla wrote: On 08/07/15 02:46, Stephen Boyd wrote: Yes struct clk would have min/max, and struct clk_core would have min/max. Then some sort of provider API (or possibly even clk_init_data) would take the min/max fields and copy them over to struct clk_core. Then during

Re: [PATCH v4 3/8] clk: add support for clocks provided by SCP(System Control Processor)

2015-07-07 Thread Stephen Boyd
On 07/07, Sudeep Holla wrote: > > > On 06/07/15 20:52, Stephen Boyd wrote: > >> > > > >If I have time I may try to start doing the clk_register() conversion, > >but it will take a while so I doubt it will be in v4.3. I'm asking if > >you can add a clk_hw based API that does something like >

Re: [PATCH v4 3/8] clk: add support for clocks provided by SCP(System Control Processor)

2015-07-07 Thread Sudeep Holla
On 06/07/15 20:52, Stephen Boyd wrote: On 07/03/2015 07:52 AM, Sudeep Holla wrote: Hi Stephen, Thanks for the review. On 02/07/15 18:23, Stephen Boyd wrote: On 06/08, Sudeep Holla wrote: [...] + +clk = devm_clk_register(dev, >hw); +if (!IS_ERR(clk) && max) +

Re: [PATCH v4 3/8] clk: add support for clocks provided by SCP(System Control Processor)

2015-07-07 Thread Sudeep Holla
On 06/07/15 20:52, Stephen Boyd wrote: On 07/03/2015 07:52 AM, Sudeep Holla wrote: Hi Stephen, Thanks for the review. On 02/07/15 18:23, Stephen Boyd wrote: On 06/08, Sudeep Holla wrote: [...] + +clk = devm_clk_register(dev, sclk-hw); +if (!IS_ERR(clk) max) +

Re: [PATCH v4 3/8] clk: add support for clocks provided by SCP(System Control Processor)

2015-07-07 Thread Stephen Boyd
On 07/07, Sudeep Holla wrote: On 06/07/15 20:52, Stephen Boyd wrote: If I have time I may try to start doing the clk_register() conversion, but it will take a while so I doubt it will be in v4.3. I'm asking if you can add a clk_hw based API that does something like

Re: [PATCH v4 3/8] clk: add support for clocks provided by SCP(System Control Processor)

2015-07-06 Thread Stephen Boyd
On 07/03/2015 07:52 AM, Sudeep Holla wrote: > Hi Stephen, > > > Thanks for the review. > > On 02/07/15 18:23, Stephen Boyd wrote: >> On 06/08, Sudeep Holla wrote: >>> diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig >>> index 9897f353bf1a..0fe8daefc105 100644 >>> --- a/drivers/clk/Kconfig

Re: [PATCH v4 3/8] clk: add support for clocks provided by SCP(System Control Processor)

2015-07-06 Thread Stephen Boyd
On 07/03/2015 07:52 AM, Sudeep Holla wrote: Hi Stephen, Thanks for the review. On 02/07/15 18:23, Stephen Boyd wrote: On 06/08, Sudeep Holla wrote: diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig index 9897f353bf1a..0fe8daefc105 100644 --- a/drivers/clk/Kconfig +++

Re: [PATCH v4 3/8] clk: add support for clocks provided by SCP(System Control Processor)

2015-07-03 Thread Sudeep Holla
On 03/07/15 15:52, Sudeep Holla wrote: [...] +static int scpi_clk_set_rate(struct clk_hw *hw, unsigned long rate, +unsigned long parent_rate) +{ + struct scpi_clk *clk = to_scpi_clk(hw); + + return clk->scpi_ops->clk_set_val(clk->id, rate); +} +

Re: [PATCH v4 3/8] clk: add support for clocks provided by SCP(System Control Processor)

2015-07-03 Thread Sudeep Holla
Hi Stephen, Thanks for the review. On 02/07/15 18:23, Stephen Boyd wrote: On 06/08, Sudeep Holla wrote: diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig index 9897f353bf1a..0fe8daefc105 100644 --- a/drivers/clk/Kconfig +++ b/drivers/clk/Kconfig @@ -59,6 +59,16 @@ config

Re: [PATCH v4 3/8] clk: add support for clocks provided by SCP(System Control Processor)

2015-07-03 Thread Sudeep Holla
Hi Stephen, Thanks for the review. On 02/07/15 18:23, Stephen Boyd wrote: On 06/08, Sudeep Holla wrote: diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig index 9897f353bf1a..0fe8daefc105 100644 --- a/drivers/clk/Kconfig +++ b/drivers/clk/Kconfig @@ -59,6 +59,16 @@ config

Re: [PATCH v4 3/8] clk: add support for clocks provided by SCP(System Control Processor)

2015-07-03 Thread Sudeep Holla
On 03/07/15 15:52, Sudeep Holla wrote: [...] +static int scpi_clk_set_rate(struct clk_hw *hw, unsigned long rate, +unsigned long parent_rate) +{ + struct scpi_clk *clk = to_scpi_clk(hw); + + return clk-scpi_ops-clk_set_val(clk-id, rate); +} + +static

Re: [PATCH v4 3/8] clk: add support for clocks provided by SCP(System Control Processor)

2015-07-02 Thread Stephen Boyd
On 06/08, Sudeep Holla wrote: > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig > index 9897f353bf1a..0fe8daefc105 100644 > --- a/drivers/clk/Kconfig > +++ b/drivers/clk/Kconfig > @@ -59,6 +59,16 @@ config COMMON_CLK_RK808 > clocked at 32KHz each. Clkout1 is always on, Clkout2 can

Re: [PATCH v4 3/8] clk: add support for clocks provided by SCP(System Control Processor)

2015-07-02 Thread Stephen Boyd
On 06/08, Sudeep Holla wrote: diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig index 9897f353bf1a..0fe8daefc105 100644 --- a/drivers/clk/Kconfig +++ b/drivers/clk/Kconfig @@ -59,6 +59,16 @@ config COMMON_CLK_RK808 clocked at 32KHz each. Clkout1 is always on, Clkout2 can off

[PATCH v4 3/8] clk: add support for clocks provided by SCP(System Control Processor)

2015-06-08 Thread Sudeep Holla
On some ARM based systems, a separate Cortex-M based System Control Processor(SCP) provides the overall power, clock, reset and system control. System Control and Power Interface(SCPI) Message Protocol is defined for the communication between the Application Cores(AP) and the SCP. This patch adds

[PATCH v4 3/8] clk: add support for clocks provided by SCP(System Control Processor)

2015-06-08 Thread Sudeep Holla
On some ARM based systems, a separate Cortex-M based System Control Processor(SCP) provides the overall power, clock, reset and system control. System Control and Power Interface(SCPI) Message Protocol is defined for the communication between the Application Cores(AP) and the SCP. This patch adds