Re: [PATCH v4 3/9] Documentation: bindings: net: add the Marvell PXA168 Ethernet controller

2014-09-23 Thread Arnd Bergmann
On Tuesday 23 September 2014 19:31:40 Sebastian Hesselbarth wrote: > It has been a while I looked it up in the pxa168 datasheet, but IIRC > there is only one port per controller. FWIW, there actually is also > just one port per controller for Orion SoCs. The multiple ports per > controller comes

Re: [PATCH v4 3/9] Documentation: bindings: net: add the Marvell PXA168 Ethernet controller

2014-09-23 Thread Sebastian Hesselbarth
On 09/23/2014 07:02 PM, Arnd Bergmann wrote: On Tuesday 23 September 2014 18:40:46 Sebastian Hesselbarth wrote: On 09/23/2014 06:29 PM, Arnd Bergmann wrote: On Tuesday 23 September 2014 17:45:52 Sebastian Hesselbarth wrote: For reference, this is what we have for MVEBU SoCs with multiple

Re: [PATCH v4 3/9] Documentation: bindings: net: add the Marvell PXA168 Ethernet controller

2014-09-23 Thread Arnd Bergmann
On Tuesday 23 September 2014 18:40:46 Sebastian Hesselbarth wrote: > On 09/23/2014 06:29 PM, Arnd Bergmann wrote: > > On Tuesday 23 September 2014 17:45:52 Sebastian Hesselbarth wrote: > >> For reference, this is what we have for MVEBU SoCs with multiple ports > >> per controller: > >> > >> eth:

Re: [PATCH v4 3/9] Documentation: bindings: net: add the Marvell PXA168 Ethernet controller

2014-09-23 Thread Sebastian Hesselbarth
On 09/23/2014 06:29 PM, Arnd Bergmann wrote: On Tuesday 23 September 2014 17:45:52 Sebastian Hesselbarth wrote: For reference, this is what we have for MVEBU SoCs with multiple ports per controller: eth: ethernet-ctrl@72000 { compatible = "marvell,orion-eth"; ... reg =

Re: [PATCH v4 3/9] Documentation: bindings: net: add the Marvell PXA168 Ethernet controller

2014-09-23 Thread Arnd Bergmann
On Tuesday 23 September 2014 17:45:52 Sebastian Hesselbarth wrote: > For reference, this is what we have for MVEBU SoCs with multiple ports > per controller: > > eth: ethernet-ctrl@72000 { > compatible = "marvell,orion-eth"; > #address-cells = <1>; > #size-cells = <0>; >

Re: [PATCH v4 3/9] Documentation: bindings: net: add the Marvell PXA168 Ethernet controller

2014-09-23 Thread Sebastian Hesselbarth
On 09/23/2014 04:37 PM, Arnd Bergmann wrote: On Tuesday 23 September 2014 16:29:22 Antoine Tenart wrote: So I had a look on other Ethernet bindings. Would you agree with something like the following? eth0: ethernet@f7b9 { ... #address-cells =

Re: [PATCH v4 3/9] Documentation: bindings: net: add the Marvell PXA168 Ethernet controller

2014-09-23 Thread Antoine Tenart
On Tue, Sep 23, 2014 at 04:33:48PM +0200, Arnd Bergmann wrote: > On Tuesday 23 September 2014 16:01:13 Antoine Tenart wrote: > > > > On Tue, Sep 23, 2014 at 02:38:39PM +0200, Arnd Bergmann wrote: > > > On Tuesday 23 September 2014 14:15:30 Antoine Tenart wrote: > > > > +Optional properties: > > >

Re: [PATCH v4 3/9] Documentation: bindings: net: add the Marvell PXA168 Ethernet controller

2014-09-23 Thread Arnd Bergmann
On Tuesday 23 September 2014 16:29:22 Antoine Tenart wrote: > > So I had a look on other Ethernet bindings. Would you agree with > something like the following? > > eth0: ethernet@f7b9 { > ... > #address-cells = <1>; > #size-cells =

Re: [PATCH v4 3/9] Documentation: bindings: net: add the Marvell PXA168 Ethernet controller

2014-09-23 Thread Arnd Bergmann
On Tuesday 23 September 2014 16:01:13 Antoine Tenart wrote: > > On Tue, Sep 23, 2014 at 02:38:39PM +0200, Arnd Bergmann wrote: > > On Tuesday 23 September 2014 14:15:30 Antoine Tenart wrote: > > > +Optional properties: > > > +- port-id: should be '0','1' or '2'. > > > +- phy-addr: MDIO address of

Re: [PATCH v4 3/9] Documentation: bindings: net: add the Marvell PXA168 Ethernet controller

2014-09-23 Thread Antoine Tenart
On Tue, Sep 23, 2014 at 04:01:13PM +0200, Antoine Tenart wrote: > Arnd, > > On Tue, Sep 23, 2014 at 02:38:39PM +0200, Arnd Bergmann wrote: > > On Tuesday 23 September 2014 14:15:30 Antoine Tenart wrote: > > > +Optional properties: > > > +- port-id: should be '0','1' or '2'. > > > +- phy-addr:

Re: [PATCH v4 3/9] Documentation: bindings: net: add the Marvell PXA168 Ethernet controller

2014-09-23 Thread Antoine Tenart
Arnd, On Tue, Sep 23, 2014 at 02:38:39PM +0200, Arnd Bergmann wrote: > On Tuesday 23 September 2014 14:15:30 Antoine Tenart wrote: > > +Optional properties: > > +- port-id: should be '0','1' or '2'. > > +- phy-addr: MDIO address of the PHY. > > +- local-mac-address: see ethernet.txt file in the

Re: [PATCH v4 3/9] Documentation: bindings: net: add the Marvell PXA168 Ethernet controller

2014-09-23 Thread Arnd Bergmann
On Tuesday 23 September 2014 14:15:30 Antoine Tenart wrote: > +Optional properties: > +- port-id: should be '0','1' or '2'. > +- phy-addr: MDIO address of the PHY. > +- local-mac-address: see ethernet.txt file in the same directory. > + > I believe new bindings should not use "phy-addr"

[PATCH v4 3/9] Documentation: bindings: net: add the Marvell PXA168 Ethernet controller

2014-09-23 Thread Antoine Tenart
This adds the binding documentation for the Marvell PXA168 Ethernet controller, following its DT support. Signed-off-by: Antoine Tenart --- .../devicetree/bindings/net/marvell-pxa168.txt | 21 + 1 file changed, 21 insertions(+) create mode 100644

[PATCH v4 3/9] Documentation: bindings: net: add the Marvell PXA168 Ethernet controller

2014-09-23 Thread Antoine Tenart
This adds the binding documentation for the Marvell PXA168 Ethernet controller, following its DT support. Signed-off-by: Antoine Tenart antoine.ten...@free-electrons.com --- .../devicetree/bindings/net/marvell-pxa168.txt | 21 + 1 file changed, 21 insertions(+) create

Re: [PATCH v4 3/9] Documentation: bindings: net: add the Marvell PXA168 Ethernet controller

2014-09-23 Thread Arnd Bergmann
On Tuesday 23 September 2014 14:15:30 Antoine Tenart wrote: +Optional properties: +- port-id: should be '0','1' or '2'. +- phy-addr: MDIO address of the PHY. +- local-mac-address: see ethernet.txt file in the same directory. + I believe new bindings should not use phy-addr properties, but

Re: [PATCH v4 3/9] Documentation: bindings: net: add the Marvell PXA168 Ethernet controller

2014-09-23 Thread Antoine Tenart
Arnd, On Tue, Sep 23, 2014 at 02:38:39PM +0200, Arnd Bergmann wrote: On Tuesday 23 September 2014 14:15:30 Antoine Tenart wrote: +Optional properties: +- port-id: should be '0','1' or '2'. +- phy-addr: MDIO address of the PHY. +- local-mac-address: see ethernet.txt file in the same

Re: [PATCH v4 3/9] Documentation: bindings: net: add the Marvell PXA168 Ethernet controller

2014-09-23 Thread Antoine Tenart
On Tue, Sep 23, 2014 at 04:01:13PM +0200, Antoine Tenart wrote: Arnd, On Tue, Sep 23, 2014 at 02:38:39PM +0200, Arnd Bergmann wrote: On Tuesday 23 September 2014 14:15:30 Antoine Tenart wrote: +Optional properties: +- port-id: should be '0','1' or '2'. +- phy-addr: MDIO address of

Re: [PATCH v4 3/9] Documentation: bindings: net: add the Marvell PXA168 Ethernet controller

2014-09-23 Thread Arnd Bergmann
On Tuesday 23 September 2014 16:01:13 Antoine Tenart wrote: On Tue, Sep 23, 2014 at 02:38:39PM +0200, Arnd Bergmann wrote: On Tuesday 23 September 2014 14:15:30 Antoine Tenart wrote: +Optional properties: +- port-id: should be '0','1' or '2'. +- phy-addr: MDIO address of the PHY.

Re: [PATCH v4 3/9] Documentation: bindings: net: add the Marvell PXA168 Ethernet controller

2014-09-23 Thread Arnd Bergmann
On Tuesday 23 September 2014 16:29:22 Antoine Tenart wrote: So I had a look on other Ethernet bindings. Would you agree with something like the following? eth0: ethernet@f7b9 { ... #address-cells = 1; #size-cells = 0;

Re: [PATCH v4 3/9] Documentation: bindings: net: add the Marvell PXA168 Ethernet controller

2014-09-23 Thread Antoine Tenart
On Tue, Sep 23, 2014 at 04:33:48PM +0200, Arnd Bergmann wrote: On Tuesday 23 September 2014 16:01:13 Antoine Tenart wrote: On Tue, Sep 23, 2014 at 02:38:39PM +0200, Arnd Bergmann wrote: On Tuesday 23 September 2014 14:15:30 Antoine Tenart wrote: +Optional properties: +- port-id:

Re: [PATCH v4 3/9] Documentation: bindings: net: add the Marvell PXA168 Ethernet controller

2014-09-23 Thread Sebastian Hesselbarth
On 09/23/2014 04:37 PM, Arnd Bergmann wrote: On Tuesday 23 September 2014 16:29:22 Antoine Tenart wrote: So I had a look on other Ethernet bindings. Would you agree with something like the following? eth0: ethernet@f7b9 { ... #address-cells = 1;

Re: [PATCH v4 3/9] Documentation: bindings: net: add the Marvell PXA168 Ethernet controller

2014-09-23 Thread Arnd Bergmann
On Tuesday 23 September 2014 17:45:52 Sebastian Hesselbarth wrote: For reference, this is what we have for MVEBU SoCs with multiple ports per controller: eth: ethernet-ctrl@72000 { compatible = marvell,orion-eth; #address-cells = 1; #size-cells = 0; reg =

Re: [PATCH v4 3/9] Documentation: bindings: net: add the Marvell PXA168 Ethernet controller

2014-09-23 Thread Sebastian Hesselbarth
On 09/23/2014 06:29 PM, Arnd Bergmann wrote: On Tuesday 23 September 2014 17:45:52 Sebastian Hesselbarth wrote: For reference, this is what we have for MVEBU SoCs with multiple ports per controller: eth: ethernet-ctrl@72000 { compatible = marvell,orion-eth; ... reg =

Re: [PATCH v4 3/9] Documentation: bindings: net: add the Marvell PXA168 Ethernet controller

2014-09-23 Thread Arnd Bergmann
On Tuesday 23 September 2014 18:40:46 Sebastian Hesselbarth wrote: On 09/23/2014 06:29 PM, Arnd Bergmann wrote: On Tuesday 23 September 2014 17:45:52 Sebastian Hesselbarth wrote: For reference, this is what we have for MVEBU SoCs with multiple ports per controller: eth:

Re: [PATCH v4 3/9] Documentation: bindings: net: add the Marvell PXA168 Ethernet controller

2014-09-23 Thread Sebastian Hesselbarth
On 09/23/2014 07:02 PM, Arnd Bergmann wrote: On Tuesday 23 September 2014 18:40:46 Sebastian Hesselbarth wrote: On 09/23/2014 06:29 PM, Arnd Bergmann wrote: On Tuesday 23 September 2014 17:45:52 Sebastian Hesselbarth wrote: For reference, this is what we have for MVEBU SoCs with multiple

Re: [PATCH v4 3/9] Documentation: bindings: net: add the Marvell PXA168 Ethernet controller

2014-09-23 Thread Arnd Bergmann
On Tuesday 23 September 2014 19:31:40 Sebastian Hesselbarth wrote: It has been a while I looked it up in the pxa168 datasheet, but IIRC there is only one port per controller. FWIW, there actually is also just one port per controller for Orion SoCs. The multiple ports per controller comes from