Re: [PATCH v4 3/9] net: xfrm: use __this_cpu_read per-cpu helper

2012-11-13 Thread Steffen Klassert
On Tue, Nov 13, 2012 at 05:33:19PM +0800, Shan Wei wrote: > Steffen Klassert said, at 2012/11/13 15:21: > > > > This should just fetch the tfm pointer, so why exactly __this_cpu_read > > is better than __this_cpu_ptr? Please keep in mind that performance is > > not the most important thing here.

Re: [PATCH v4 3/9] net: xfrm: use __this_cpu_read per-cpu helper

2012-11-13 Thread Shan Wei
Steffen Klassert said, at 2012/11/13 15:21: > > This should just fetch the tfm pointer, so why exactly __this_cpu_read > is better than __this_cpu_ptr? Please keep in mind that performance is > not the most important thing here. It's much more important that it > works in any case. [0/9]

Re: [PATCH v4 3/9] net: xfrm: use __this_cpu_read per-cpu helper

2012-11-13 Thread Shan Wei
Steffen Klassert said, at 2012/11/13 15:21: This should just fetch the tfm pointer, so why exactly __this_cpu_read is better than __this_cpu_ptr? Please keep in mind that performance is not the most important thing here. It's much more important that it works in any case. [0/9] describes

Re: [PATCH v4 3/9] net: xfrm: use __this_cpu_read per-cpu helper

2012-11-13 Thread Steffen Klassert
On Tue, Nov 13, 2012 at 05:33:19PM +0800, Shan Wei wrote: Steffen Klassert said, at 2012/11/13 15:21: This should just fetch the tfm pointer, so why exactly __this_cpu_read is better than __this_cpu_ptr? Please keep in mind that performance is not the most important thing here. It's much

Re: [PATCH v4 3/9] net: xfrm: use __this_cpu_read per-cpu helper

2012-11-12 Thread Steffen Klassert
On Tue, Nov 13, 2012 at 09:52:09AM +0800, Shan Wei wrote: > From: Shan Wei > Please add a proper commit message, explaining why you do this change. > > Signed-off-by: Shan Wei > --- > v4: > derefrence pointer before reading to avoid compile warning. > --- > net/xfrm/xfrm_ipcomp.c |8

[PATCH v4 3/9] net: xfrm: use __this_cpu_read per-cpu helper

2012-11-12 Thread Shan Wei
From: Shan Wei Signed-off-by: Shan Wei --- v4: derefrence pointer before reading to avoid compile warning. --- net/xfrm/xfrm_ipcomp.c |8 +++- 1 files changed, 3 insertions(+), 5 deletions(-) diff --git a/net/xfrm/xfrm_ipcomp.c b/net/xfrm/xfrm_ipcomp.c index e5246fb..2906d52 100644

[PATCH v4 3/9] net: xfrm: use __this_cpu_read per-cpu helper

2012-11-12 Thread Shan Wei
From: Shan Wei davids...@tencent.com Signed-off-by: Shan Wei davids...@tencent.com --- v4: derefrence pointer before reading to avoid compile warning. --- net/xfrm/xfrm_ipcomp.c |8 +++- 1 files changed, 3 insertions(+), 5 deletions(-) diff --git a/net/xfrm/xfrm_ipcomp.c

Re: [PATCH v4 3/9] net: xfrm: use __this_cpu_read per-cpu helper

2012-11-12 Thread Steffen Klassert
On Tue, Nov 13, 2012 at 09:52:09AM +0800, Shan Wei wrote: From: Shan Wei davids...@tencent.com Please add a proper commit message, explaining why you do this change. Signed-off-by: Shan Wei davids...@tencent.com --- v4: derefrence pointer before reading to avoid compile warning. ---