Re: [PATCH v4 4/4] dma-buf: heaps: add chunk heap to dmabuf heaps

2021-01-27 Thread Michal Hocko
On Tue 26-01-21 11:25:36, Minchan Kim wrote: > On Tue, Jan 26, 2021 at 08:46:05AM +0100, Michal Hocko wrote: > > On Thu 21-01-21 09:55:02, Minchan Kim wrote: > > > From: Hyesoo Yu > > > > > > This patch supports chunk heap that allocates the buffers that > > > arranged into a list a fixed size

Re: [PATCH v4 4/4] dma-buf: heaps: add chunk heap to dmabuf heaps

2021-01-26 Thread Minchan Kim
On Tue, Jan 26, 2021 at 07:07:44AM +, Christoph Hellwig wrote: > > +config DMABUF_HEAPS_CHUNK > > + bool "DMA-BUF CHUNK Heap" > > + depends on DMABUF_HEAPS && DMA_CMA > > + help > > + Choose this option to enable dma-buf CHUNK heap. This heap is backed > > + by the Contiguous

Re: [PATCH v4 4/4] dma-buf: heaps: add chunk heap to dmabuf heaps

2021-01-26 Thread Minchan Kim
On Tue, Jan 26, 2021 at 08:46:05AM +0100, Michal Hocko wrote: > On Thu 21-01-21 09:55:02, Minchan Kim wrote: > > From: Hyesoo Yu > > > > This patch supports chunk heap that allocates the buffers that > > arranged into a list a fixed size chunks taken from CMA. > > > > The chunk heap driver is

Re: [PATCH v4 4/4] dma-buf: heaps: add chunk heap to dmabuf heaps

2021-01-26 Thread Minchan Kim
On Mon, Jan 25, 2021 at 11:32:57PM -0800, John Stultz wrote: > On Thu, Jan 21, 2021 at 9:55 AM Minchan Kim wrote: > > Hey Minchan, > Thanks for sending this out! I'm still working through testing with > this patch set, so I may have some more feedback tomorrow, but a few > quick items I did

Re: [PATCH v4 4/4] dma-buf: heaps: add chunk heap to dmabuf heaps

2021-01-26 Thread John Stultz
On Thu, Jan 21, 2021 at 9:55 AM Minchan Kim wrote: Hey Minchan, Thanks for sending this out! I'm still working through testing with this patch set, so I may have some more feedback tomorrow, but a few quick items I did hit below. > + > +#define CHUNK_PREFIX "chunk-" > + > +static int

Re: [PATCH v4 4/4] dma-buf: heaps: add chunk heap to dmabuf heaps

2021-01-26 Thread Michal Hocko
On Thu 21-01-21 09:55:02, Minchan Kim wrote: > From: Hyesoo Yu > > This patch supports chunk heap that allocates the buffers that > arranged into a list a fixed size chunks taken from CMA. > > The chunk heap driver is bound directly to a reserved_memory > node by following Rob Herring's

Re: [PATCH v4 4/4] dma-buf: heaps: add chunk heap to dmabuf heaps

2021-01-26 Thread Christoph Hellwig
> +config DMABUF_HEAPS_CHUNK > + bool "DMA-BUF CHUNK Heap" > + depends on DMABUF_HEAPS && DMA_CMA > + help > + Choose this option to enable dma-buf CHUNK heap. This heap is backed > + by the Contiguous Memory Allocator (CMA) and allocates the buffers > that > + are

[PATCH v4 4/4] dma-buf: heaps: add chunk heap to dmabuf heaps

2021-01-21 Thread Minchan Kim
From: Hyesoo Yu This patch supports chunk heap that allocates the buffers that arranged into a list a fixed size chunks taken from CMA. The chunk heap driver is bound directly to a reserved_memory node by following Rob Herring's suggestion in [1]. [1]