Re: [PATCH v4 4/4] livepatch/module: remove livepatch module notifier

2016-03-28 Thread Steven Rostedt
On Tue, 16 Feb 2016 00:42:25 +0100 (CET) Jiri Kosina wrote: > Steven, I'd appreciate if you could tell me whether your Ack to > "ftrace/module: remove ftrace module notifier" still holds even if > module.c changes are not happening. When threads get this busy, and I'm busy on other things, I

Re: [PATCH v4 4/4] livepatch/module: remove livepatch module notifier

2016-02-29 Thread Rusty Russell
Jiri Kosina writes: > On Wed, 10 Feb 2016, Rusty Russell wrote: > >> > Remove the livepatch module notifier in favor of directly enabling and >> > disabling patches to modules in the module loader. Hard-coding the >> > function calls ensures that ftrace_module_enable() is run before >> > klp_modul

Re: [PATCH v4 4/4] livepatch/module: remove livepatch module notifier

2016-02-15 Thread Jiri Kosina
On Mon, 15 Feb 2016, Josh Poimboeuf wrote: > So I think the commit causing the regression is 5156dca34a3e, which > occurred in the 4.5 cycle, *not* in 4.4. Agreed, by "4.4 regresion" I mean "regression compared to 4.4"; i.e. regression that will become real issue once 4.5 is released. > Also it

Re: [PATCH v4 4/4] livepatch/module: remove livepatch module notifier

2016-02-15 Thread Josh Poimboeuf
On Sun, Feb 14, 2016 at 11:59:00PM +0100, Jiri Kosina wrote: > On Wed, 10 Feb 2016, Jiri Kosina wrote: > > > > > Remove the livepatch module notifier in favor of directly enabling and > > > > disabling patches to modules in the module loader. Hard-coding the > > > > function calls ensures that ftr

Re: [PATCH v4 4/4] livepatch/module: remove livepatch module notifier

2016-02-14 Thread Jiri Kosina
On Wed, 10 Feb 2016, Jiri Kosina wrote: > > > Remove the livepatch module notifier in favor of directly enabling and > > > disabling patches to modules in the module loader. Hard-coding the > > > function calls ensures that ftrace_module_enable() is run before > > > klp_module_coming() during modu

Re: [PATCH v4 4/4] livepatch/module: remove livepatch module notifier

2016-02-10 Thread Miroslav Benes
On Mon, 8 Feb 2016, Jessica Yu wrote: > Remove the livepatch module notifier in favor of directly enabling and > disabling patches to modules in the module loader. Hard-coding the > function calls ensures that ftrace_module_enable() is run before > klp_module_coming() during module load, and that

Re: [PATCH v4 4/4] livepatch/module: remove livepatch module notifier

2016-02-10 Thread Jiri Kosina
On Wed, 10 Feb 2016, Rusty Russell wrote: > > Remove the livepatch module notifier in favor of directly enabling and > > disabling patches to modules in the module loader. Hard-coding the > > function calls ensures that ftrace_module_enable() is run before > > klp_module_coming() during module loa

Re: [PATCH v4 4/4] livepatch/module: remove livepatch module notifier

2016-02-09 Thread Rusty Russell
Jessica Yu writes: > Remove the livepatch module notifier in favor of directly enabling and > disabling patches to modules in the module loader. Hard-coding the > function calls ensures that ftrace_module_enable() is run before > klp_module_coming() during module load, and that klp_module_going()

Re: [PATCH v4 4/4] livepatch/module: remove livepatch module notifier

2016-02-09 Thread Josh Poimboeuf
On Mon, Feb 08, 2016 at 11:50:24PM -0500, Jessica Yu wrote: > Remove the livepatch module notifier in favor of directly enabling and > disabling patches to modules in the module loader. Hard-coding the > function calls ensures that ftrace_module_enable() is run before > klp_module_coming() during m

[PATCH v4 4/4] livepatch/module: remove livepatch module notifier

2016-02-08 Thread Jessica Yu
Remove the livepatch module notifier in favor of directly enabling and disabling patches to modules in the module loader. Hard-coding the function calls ensures that ftrace_module_enable() is run before klp_module_coming() during module load, and that klp_module_going() is run before ftrace_release