Re: [PATCH v4 4/5] dell-wmi: properly process Dell Instant Launch hotkey

2016-03-03 Thread Darren Hart
On Thu, Mar 03, 2016 at 07:46:32PM +0100, Michał Kępień wrote: > > Your description below helped explain why the KE_KEY change was necessary, > > the > > commit message didn't do that for me. Just explicitly stating "when there > > is no > > i8042 interrupt, the WMI even must generate a valid KE_

Re: [PATCH v4 4/5] dell-wmi: properly process Dell Instant Launch hotkey

2016-03-03 Thread Michał Kępień
> Your description below helped explain why the KE_KEY change was necessary, the > commit message didn't do that for me. Just explicitly stating "when there is > no > i8042 interrupt, the WMI even must generate a valid KE_KEY" or something along > those lines would help. I will do that in v5, the

Re: [PATCH v4 4/5] dell-wmi: properly process Dell Instant Launch hotkey

2016-03-03 Thread Darren Hart
On Wed, Mar 02, 2016 at 01:35:04PM +0100, Michał Kępień wrote: > > On Mon, Feb 29, 2016 at 09:56:03PM +0100, Pali Rohár wrote: > > > On Monday 29 February 2016 21:49:27 you wrote: > > > > > On Monday 29 February 2016 21:31:23 Michał Kępień wrote: I understand this better now, thank you for the add

Re: [PATCH v4 4/5] dell-wmi: properly process Dell Instant Launch hotkey

2016-03-02 Thread Michał Kępień
> On Mon, Feb 29, 2016 at 09:56:03PM +0100, Pali Rohár wrote: > > On Monday 29 February 2016 21:49:27 you wrote: > > > > On Monday 29 February 2016 21:31:23 Michał Kępień wrote: > > > > > > > diff --git a/drivers/platform/x86/dell-wmi.c > > > > > > > b/drivers/platform/x86/dell-wmi.c index 65edd93.

Re: [PATCH v4 4/5] dell-wmi: properly process Dell Instant Launch hotkey

2016-02-29 Thread Darren Hart
On Mon, Feb 29, 2016 at 09:31:23PM +0100, Michał Kępień wrote: > > > diff --git a/drivers/platform/x86/dell-wmi.c > > > b/drivers/platform/x86/dell-wmi.c > > > index 65edd93..ffc957b5 100644 > > > --- a/drivers/platform/x86/dell-wmi.c > > > +++ b/drivers/platform/x86/dell-wmi.c > > > @@ -111,7 +11

Re: [PATCH v4 4/5] dell-wmi: properly process Dell Instant Launch hotkey

2016-02-29 Thread Darren Hart
On Mon, Feb 29, 2016 at 09:56:03PM +0100, Pali Rohár wrote: > On Monday 29 February 2016 21:49:27 you wrote: > > > On Monday 29 February 2016 21:31:23 Michał Kępień wrote: > > > > > > diff --git a/drivers/platform/x86/dell-wmi.c > > > > > > b/drivers/platform/x86/dell-wmi.c index 65edd93..ffc957b5

Re: [PATCH v4 4/5] dell-wmi: properly process Dell Instant Launch hotkey

2016-02-29 Thread Pali Rohár
On Monday 29 February 2016 21:49:27 you wrote: > > On Monday 29 February 2016 21:31:23 Michał Kępień wrote: > > > > > diff --git a/drivers/platform/x86/dell-wmi.c > > > > > b/drivers/platform/x86/dell-wmi.c index 65edd93..ffc957b5 > > > > > 100644 --- a/drivers/platform/x86/dell-wmi.c > > > > > +++

Re: [PATCH v4 4/5] dell-wmi: properly process Dell Instant Launch hotkey

2016-02-29 Thread Michał Kępień
> On Monday 29 February 2016 21:31:23 Michał Kępień wrote: > > > > diff --git a/drivers/platform/x86/dell-wmi.c > > > > b/drivers/platform/x86/dell-wmi.c index 65edd93..ffc957b5 100644 > > > > --- a/drivers/platform/x86/dell-wmi.c > > > > +++ b/drivers/platform/x86/dell-wmi.c > > > > @@ -111,7 +111

Re: [PATCH v4 4/5] dell-wmi: properly process Dell Instant Launch hotkey

2016-02-29 Thread Pali Rohár
On Monday 29 February 2016 21:31:23 Michał Kępień wrote: > > > diff --git a/drivers/platform/x86/dell-wmi.c > > > b/drivers/platform/x86/dell-wmi.c index 65edd93..ffc957b5 100644 > > > --- a/drivers/platform/x86/dell-wmi.c > > > +++ b/drivers/platform/x86/dell-wmi.c > > > @@ -111,7 +111,7 @@ static

Re: [PATCH v4 4/5] dell-wmi: properly process Dell Instant Launch hotkey

2016-02-29 Thread Michał Kępień
> > diff --git a/drivers/platform/x86/dell-wmi.c > > b/drivers/platform/x86/dell-wmi.c > > index 65edd93..ffc957b5 100644 > > --- a/drivers/platform/x86/dell-wmi.c > > +++ b/drivers/platform/x86/dell-wmi.c > > @@ -111,7 +111,7 @@ static const struct key_entry dell_wmi_legacy_keymap[] > > __initco

Re: [PATCH v4 4/5] dell-wmi: properly process Dell Instant Launch hotkey

2016-02-29 Thread Pali Rohár
On Wednesday 24 February 2016 08:20:14 Michał Kępień wrote: > On models on which an SMBIOS request needs to be issued in order for WMI > events to be generated, pressing the Dell Instant Launch hotkey does not > raise an i8042 interrupt - only a WMI event is generated (0xe025 on Dell > Vostro V131)

[PATCH v4 4/5] dell-wmi: properly process Dell Instant Launch hotkey

2016-02-23 Thread Michał Kępień
On models on which an SMBIOS request needs to be issued in order for WMI events to be generated, pressing the Dell Instant Launch hotkey does not raise an i8042 interrupt - only a WMI event is generated (0xe025 on Dell Vostro V131). Thus, the 0xe025 event should only be ignored on machines which d