Re: [PATCH v4 4/5] iio: fxas21002c: add ODR/Scale support

2018-09-16 Thread Jonathan Cameron
On Fri, 14 Sep 2018 23:00:58 +0530 Himanshu Jha wrote: > On Fri, Sep 14, 2018 at 04:26:44PM +0100, Afonso Bordado wrote: > > Hi, > > > > Thanks for your help with this. > > > > > And I suspect it may be originating from your code snippet: > > > > > > #define FXAS21002C_SCALE(scale) (IIO_DEGR

Re: [PATCH v4 4/5] iio: fxas21002c: add ODR/Scale support

2018-09-14 Thread Himanshu Jha
On Fri, Sep 14, 2018 at 04:26:44PM +0100, Afonso Bordado wrote: > Hi, > > Thanks for your help with this. > > > And I suspect it may be originating from your code snippet: > > > > #define FXAS21002C_SCALE(scale) (IIO_DEGREE_TO_RAD(62500U >> > > (scale))) > > > > and looking at the implementatio

Re: [PATCH v4 4/5] iio: fxas21002c: add ODR/Scale support

2018-09-14 Thread Afonso Bordado
Hi, Thanks for your help with this. > And I suspect it may be originating from your code snippet: > > #define FXAS21002C_SCALE(scale) (IIO_DEGREE_TO_RAD(62500U >> > (scale))) > > and looking at the implementation: > > include/linux/iio/iio.h > /** > * IIO_DEGREE_TO_RAD() - Convert degree to r

Re: [PATCH v4 4/5] iio: fxas21002c: add ODR/Scale support

2018-09-12 Thread Himanshu Jha
Hello Afonso, On Wed, Sep 12, 2018 at 05:26:01PM +0800, kbuild test robot wrote: > Hi Afonso, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on iio/togreg] > [also build test ERROR on v4.19-rc3 next-20180912] > [if your patch is applied to the wrong git tree, p

Re: [PATCH v4 4/5] iio: fxas21002c: add ODR/Scale support

2018-09-12 Thread kbuild test robot
Hi Afonso, Thank you for the patch! Yet something to improve: [auto build test ERROR on iio/togreg] [also build test ERROR on v4.19-rc3 next-20180912] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/com

[PATCH v4 4/5] iio: fxas21002c: add ODR/Scale support

2018-09-11 Thread Afonso Bordado
This patch adds support for reading/writing ODR/Scale We don't support the scale boost modes. Signed-off-by: Afonso Bordado --- drivers/iio/gyro/fxas21002c.c | 143 +++--- 1 file changed, 131 insertions(+), 12 deletions(-) diff --git a/drivers/iio/gyro/fxas21002c.c