Re: [PATCH v4 4/5] soc: qcom: socinfo: Expose custom attributes

2019-03-25 Thread Vaishali Thakkar
On Mon, 25 Mar 2019 at 21:31, Stephen Boyd wrote: > > Quoting Vaishali Thakkar (2019-03-24 10:42:36) > > On Sat, 23 Mar 2019 at 05:31, Stephen Boyd wrote: > > > > > debugfs_create_devm_seqfile() which may work to print a string from some > > > struct member. I'm not sure why you're using

Re: [PATCH v4 4/5] soc: qcom: socinfo: Expose custom attributes

2019-03-25 Thread Stephen Boyd
Quoting Vaishali Thakkar (2019-03-24 10:42:36) > On Sat, 23 Mar 2019 at 05:31, Stephen Boyd wrote: > > > debugfs_create_devm_seqfile() which may work to print a string from some > > struct member. I'm not sure why you're using simple_attr_read(). Where > > does that become important? > >

Re: [PATCH v4 4/5] soc: qcom: socinfo: Expose custom attributes

2019-03-24 Thread Vaishali Thakkar
On Sat, 23 Mar 2019 at 05:31, Stephen Boyd wrote: > > Quoting Vaishali Thakkar (2019-03-20 22:51:20) > > On Thu, 14 Mar 2019 at 21:28, Stephen Boyd wrote: > > > > > > Quoting Vaishali Thakkar (2019-03-14 04:25:16) > > > > On Fri, 1 Mar 2019 at 03:02, Stephen Boyd wrote: > > > > > > > > > > > In

Re: [PATCH v4 4/5] soc: qcom: socinfo: Expose custom attributes

2019-03-22 Thread Stephen Boyd
Quoting Vaishali Thakkar (2019-03-20 22:51:20) > On Thu, 14 Mar 2019 at 21:28, Stephen Boyd wrote: > > > > Quoting Vaishali Thakkar (2019-03-14 04:25:16) > > > On Fri, 1 Mar 2019 at 03:02, Stephen Boyd wrote: > > > > > > > > In the case of converting it to cpu native during probe, I'll need to >

Re: [PATCH v4 4/5] soc: qcom: socinfo: Expose custom attributes

2019-03-20 Thread Vaishali Thakkar
On Thu, 14 Mar 2019 at 21:28, Stephen Boyd wrote: > > Quoting Vaishali Thakkar (2019-03-14 04:25:16) > > On Fri, 1 Mar 2019 at 03:02, Stephen Boyd wrote: > > > > > > Why can't we use the debugfs_create_u32 function? It would make things > > > clearer if there was either a debugfs_create_le32()

Re: [PATCH v4 4/5] soc: qcom: socinfo: Expose custom attributes

2019-03-14 Thread Stephen Boyd
Quoting Vaishali Thakkar (2019-03-14 04:25:16) > On Fri, 1 Mar 2019 at 03:02, Stephen Boyd wrote: > > > > Why can't we use the debugfs_create_u32 function? It would make things > > clearer if there was either a debugfs_create_le32() function or if the > > socinfo structure stored in smem was

Re: [PATCH v4 4/5] soc: qcom: socinfo: Expose custom attributes

2019-03-14 Thread Vaishali Thakkar
On Fri, 1 Mar 2019 at 03:02, Stephen Boyd wrote: > > Quoting Vaishali Thakkar (2019-02-24 22:50:43) > > diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c > > index 02078049fac7..ccadeba69a81 100644 > > --- a/drivers/soc/qcom/socinfo.c > > +++ b/drivers/soc/qcom/socinfo.c > > @@

Re: [PATCH v4 4/5] soc: qcom: socinfo: Expose custom attributes

2019-03-01 Thread Bjorn Andersson
On Sun 24 Feb 22:50 PST 2019, Vaishali Thakkar wrote: > +#ifdef CONFIG_DEBUG_FS > +/* pmic model info */ Please drop this comment and make "pmic_model" plural. > +static const char *const pmic_model[] = { > + [0] = "Unknown PMIC model", > + [9] = "PM8994", > + [11] = "PM8916", > +

Re: [PATCH v4 4/5] soc: qcom: socinfo: Expose custom attributes

2019-02-28 Thread Stephen Boyd
Quoting Vaishali Thakkar (2019-02-24 22:50:43) > diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c > index 02078049fac7..ccadeba69a81 100644 > --- a/drivers/soc/qcom/socinfo.c > +++ b/drivers/soc/qcom/socinfo.c > @@ -70,6 +93,10 @@ struct socinfo { > struct qcom_socinfo { >

[PATCH v4 4/5] soc: qcom: socinfo: Expose custom attributes

2019-02-24 Thread Vaishali Thakkar
The Qualcomm socinfo provides a number of additional attributes, add these to the socinfo driver and expose them via debugfs functionality. Signed-off-by: Vaishali Thakkar --- Changes since v3: - Fix compilation error in function signatures when debugfs is disabled Changes