Re: [PATCH v4 4/6] bus: ti-sysc: Add support for software reset

2018-07-06 Thread Faiz Abbas
Hi, On Friday 06 July 2018 04:05 PM, Tony Lindgren wrote: > * Faiz Abbas [180706 10:05]: >> Hi, >> >> On Thursday 05 July 2018 09:17 PM, Tony Lindgren wrote: >>> * Faiz Abbas [180705 14:24]: +static int sysc_reset(struct sysc *ddata) +{ + int offset = ddata->offsets[SYSC_SYSCONFI

Re: [PATCH v4 4/6] bus: ti-sysc: Add support for software reset

2018-07-06 Thread Tony Lindgren
* Faiz Abbas [180706 10:05]: > Hi, > > On Thursday 05 July 2018 09:17 PM, Tony Lindgren wrote: > > * Faiz Abbas [180705 14:24]: > >> +static int sysc_reset(struct sysc *ddata) > >> +{ > >> + int offset = ddata->offsets[SYSC_SYSCONFIG]; > >> + int val = sysc_read(ddata, offset); > > > > Can yo

Re: [PATCH v4 4/6] bus: ti-sysc: Add support for software reset

2018-07-06 Thread Faiz Abbas
Hi, On Thursday 05 July 2018 09:17 PM, Tony Lindgren wrote: > * Faiz Abbas [180705 14:24]: >> +static int sysc_reset(struct sysc *ddata) >> +{ >> +int offset = ddata->offsets[SYSC_SYSCONFIG]; >> +int val = sysc_read(ddata, offset); > > Can you please just warn and return early for now if

Re: [PATCH v4 4/6] bus: ti-sysc: Add support for software reset

2018-07-05 Thread Tony Lindgren
* Faiz Abbas [180705 14:24]: > +static int sysc_reset(struct sysc *ddata) > +{ > + int offset = ddata->offsets[SYSC_SYSCONFIG]; > + int val = sysc_read(ddata, offset); Can you please just warn and return early for now if no syss_mask is specified? Otherwise we'll have mysterious errors if

[PATCH v4 4/6] bus: ti-sysc: Add support for software reset

2018-07-05 Thread Faiz Abbas
Add support for the software reset of a target interconnect module using its sysconfig and sysstatus registers. Signed-off-by: Faiz Abbas --- drivers/bus/ti-sysc.c | 39 +++ 1 file changed, 39 insertions(+) diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-