Re: [PATCH v4 4/7] scsi: sr: block events when runtime suspended

2012-08-06 Thread Aaron Lu
On 08/03/2012 10:52 PM, Jeff Garzik wrote: On 08/03/2012 05:50 AM, Aaron Lu wrote: Hello, Not sure if I should use EXPORT_SYMBOL or EXPORT_SYMBOL_GPL, any comments? Typically you follow the pattern of similar exports in the file (or in the API, if no others are in the file). Thanks Jeff for

Re: [PATCH v4 4/7] scsi: sr: block events when runtime suspended

2012-08-03 Thread Jeff Garzik
On 08/03/2012 05:50 AM, Aaron Lu wrote: Hello, Not sure if I should use EXPORT_SYMBOL or EXPORT_SYMBOL_GPL, any comments? Typically you follow the pattern of similar exports in the file (or in the API, if no others are in the file). Jeff -- To unsubscribe from this list: send t

Re: [PATCH v4 4/7] scsi: sr: block events when runtime suspended

2012-08-03 Thread Aaron Lu
Hello, Not sure if I should use EXPORT_SYMBOL or EXPORT_SYMBOL_GPL, any comments? Thanks, Aaron On 07/27/2012 05:00 PM, Aaron Lu wrote: When the ODD is runtime suspended, there is no need to poll it for events, so block events poll for it and unblock when resumed. Signed-off-by: Aaron Lu ---

[PATCH v4 4/7] scsi: sr: block events when runtime suspended

2012-07-27 Thread Aaron Lu
When the ODD is runtime suspended, there is no need to poll it for events, so block events poll for it and unblock when resumed. Signed-off-by: Aaron Lu --- block/genhd.c | 2 ++ drivers/scsi/sr.c | 7 --- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/block/genhd.c b/blo