Re: [PATCH v4 4/7] tracing: Add support for dynamic strings to synthetic events

2020-10-09 Thread Masami Hiramatsu
On Thu, 8 Oct 2020 15:21:50 -0400 Steven Rostedt wrote: > On Thu, 8 Oct 2020 18:22:07 +0900 > Masami Hiramatsu wrote: > > > Some of those issues are not introduced from this series. I think > > we'd better fix those before introducing this series so that > > we can backport it to stable kernels

Re: [PATCH v4 4/7] tracing: Add support for dynamic strings to synthetic events

2020-10-08 Thread Tom Zanussi
Hi Masami, On Thu, 2020-10-08 at 18:22 +0900, Masami Hiramatsu wrote: > Hi Tom, > > On Sun, 4 Oct 2020 17:14:06 -0500 > Tom Zanussi wrote: > > > Currently, sythetic events only support static string fields such > > as: > > > > # echo 'test_latency u64 lat; char somename[32]' > > > /sys/kern

Re: [PATCH v4 4/7] tracing: Add support for dynamic strings to synthetic events

2020-10-08 Thread Steven Rostedt
On Thu, 8 Oct 2020 18:22:07 +0900 Masami Hiramatsu wrote: > Some of those issues are not introduced from this series. I think > we'd better fix those before introducing this series so that > we can backport it to stable kernels. I agree that these should be fixed, but I'm not sure I want to hold

Re: [PATCH v4 4/7] tracing: Add support for dynamic strings to synthetic events

2020-10-08 Thread Masami Hiramatsu
Hi Tom, On Sun, 4 Oct 2020 17:14:06 -0500 Tom Zanussi wrote: > Currently, sythetic events only support static string fields such as: > > # echo 'test_latency u64 lat; char somename[32]' > > /sys/kernel/debug/tracing/synthetic_events > > Which is fine, but wastes a lot of space in the event

[PATCH v4 4/7] tracing: Add support for dynamic strings to synthetic events

2020-10-04 Thread Tom Zanussi
Currently, sythetic events only support static string fields such as: # echo 'test_latency u64 lat; char somename[32]' > /sys/kernel/debug/tracing/synthetic_events Which is fine, but wastes a lot of space in the event. It also prevents the most commonly-defined strings in the existing trace e