Re: [PATCH v4 5/9] KVM: nSVM: introduce nested_svm_load_cr3()/nested_npt_enabled()

2020-07-14 Thread Sean Christopherson
On Tue, Jul 14, 2020 at 01:26:24PM +0200, Vitaly Kuznetsov wrote: > Sean Christopherson writes: > > IMO the addition of nested_npt_enabled() should be a separate patch, and > > the additoin of @nested_npt should be in patch 7. > > > > Hypothetically speaking, if nested_npt_enabled() is inaccurate

Re: [PATCH v4 5/9] KVM: nSVM: introduce nested_svm_load_cr3()/nested_npt_enabled()

2020-07-14 Thread Vitaly Kuznetsov
Sean Christopherson writes: > On Fri, Jul 10, 2020 at 04:11:53PM +0200, Vitaly Kuznetsov wrote: >> As a preparatory change for implementing nested specifig PGD switch for > > s/specifig/specific > >> nSVM (following nVMX' nested_vmx_load_cr3()) instead of relying on > > nVMX's > >> kvm_set_cr3()

Re: [PATCH v4 5/9] KVM: nSVM: introduce nested_svm_load_cr3()/nested_npt_enabled()

2020-07-13 Thread Sean Christopherson
On Fri, Jul 10, 2020 at 04:11:53PM +0200, Vitaly Kuznetsov wrote: > As a preparatory change for implementing nested specifig PGD switch for s/specifig/specific > nSVM (following nVMX' nested_vmx_load_cr3()) instead of relying on nVMX's > kvm_set_cr3() introduce nested_svm_load_cr3(). The chang

[PATCH v4 5/9] KVM: nSVM: introduce nested_svm_load_cr3()/nested_npt_enabled()

2020-07-10 Thread Vitaly Kuznetsov
As a preparatory change for implementing nested specifig PGD switch for nSVM (following nVMX' nested_vmx_load_cr3()) instead of relying on kvm_set_cr3() introduce nested_svm_load_cr3(). No functional change intended. Signed-off-by: Vitaly Kuznetsov --- arch/x86/kvm/svm/nested.c | 21 +++