Re: [PATCH v4 6/7] dt-bindings: phy-qcom-usb2: Add support to override tuning values

Hi, On 4/13/2018 2:17 AM, Doug Anderson wrote: >> Thanks for review Rob. I too agree with both the viewpoints. >> Doug, if it is not of much concern then can I stick with current approach? > I certainly would appreciate the #defines and believe they add to the > readability, but if you're dead

Re: [PATCH v4 6/7] dt-bindings: phy-qcom-usb2: Add support to override tuning values

Hi, On 4/13/2018 2:17 AM, Doug Anderson wrote: >> Thanks for review Rob. I too agree with both the viewpoints. >> Doug, if it is not of much concern then can I stick with current approach? > I certainly would appreciate the #defines and believe they add to the > readability, but if you're dead

Re: [PATCH v4 6/7] dt-bindings: phy-qcom-usb2: Add support to override tuning values

Hi, On Tue, Apr 10, 2018 at 12:16 AM, Manu Gautam wrote: > > > On 4/10/2018 1:48 AM, Rob Herring wrote: >> On Thu, Mar 29, 2018 at 01:38:23PM -0700, Doug Anderson wrote: >>> Hi, >>> >>> On Thu, Mar 29, 2018 at 4:04 AM, Manu Gautam wrote: To

Re: [PATCH v4 6/7] dt-bindings: phy-qcom-usb2: Add support to override tuning values

Hi, On Tue, Apr 10, 2018 at 12:16 AM, Manu Gautam wrote: > > > On 4/10/2018 1:48 AM, Rob Herring wrote: >> On Thu, Mar 29, 2018 at 01:38:23PM -0700, Doug Anderson wrote: >>> Hi, >>> >>> On Thu, Mar 29, 2018 at 4:04 AM, Manu Gautam wrote: To improve eye diagram for PHYs on different boards

Re: [PATCH v4 6/7] dt-bindings: phy-qcom-usb2: Add support to override tuning values

On 4/10/2018 1:48 AM, Rob Herring wrote: > On Thu, Mar 29, 2018 at 01:38:23PM -0700, Doug Anderson wrote: >> Hi, >> >> On Thu, Mar 29, 2018 at 4:04 AM, Manu Gautam wrote: >>> To improve eye diagram for PHYs on different boards of same SOC, >>> some parameters may need to

Re: [PATCH v4 6/7] dt-bindings: phy-qcom-usb2: Add support to override tuning values

On 4/10/2018 1:48 AM, Rob Herring wrote: > On Thu, Mar 29, 2018 at 01:38:23PM -0700, Doug Anderson wrote: >> Hi, >> >> On Thu, Mar 29, 2018 at 4:04 AM, Manu Gautam wrote: >>> To improve eye diagram for PHYs on different boards of same SOC, >>> some parameters may need to be changed. Provide

Re: [PATCH v4 6/7] dt-bindings: phy-qcom-usb2: Add support to override tuning values

On Thu, Mar 29, 2018 at 01:38:23PM -0700, Doug Anderson wrote: > Hi, > > On Thu, Mar 29, 2018 at 4:04 AM, Manu Gautam wrote: > > To improve eye diagram for PHYs on different boards of same SOC, > > some parameters may need to be changed. Provide device tree > > properties

Re: [PATCH v4 6/7] dt-bindings: phy-qcom-usb2: Add support to override tuning values

On Thu, Mar 29, 2018 at 01:38:23PM -0700, Doug Anderson wrote: > Hi, > > On Thu, Mar 29, 2018 at 4:04 AM, Manu Gautam wrote: > > To improve eye diagram for PHYs on different boards of same SOC, > > some parameters may need to be changed. Provide device tree > > properties to override these from

Re: [PATCH v4 6/7] dt-bindings: phy-qcom-usb2: Add support to override tuning values

Hi, On Thu, Mar 29, 2018 at 4:04 AM, Manu Gautam wrote: > To improve eye diagram for PHYs on different boards of same SOC, > some parameters may need to be changed. Provide device tree > properties to override these from board specific device tree > files. While at it,

Re: [PATCH v4 6/7] dt-bindings: phy-qcom-usb2: Add support to override tuning values

Hi, On Thu, Mar 29, 2018 at 4:04 AM, Manu Gautam wrote: > To improve eye diagram for PHYs on different boards of same SOC, > some parameters may need to be changed. Provide device tree > properties to override these from board specific device tree > files. While at it, replace

[PATCH v4 6/7] dt-bindings: phy-qcom-usb2: Add support to override tuning values

To improve eye diagram for PHYs on different boards of same SOC, some parameters may need to be changed. Provide device tree properties to override these from board specific device tree files. While at it, replace "qcom,qusb2-v2-phy" with compatible string for USB2 PHY on sdm845 which was earlier

[PATCH v4 6/7] dt-bindings: phy-qcom-usb2: Add support to override tuning values

To improve eye diagram for PHYs on different boards of same SOC, some parameters may need to be changed. Provide device tree properties to override these from board specific device tree files. While at it, replace "qcom,qusb2-v2-phy" with compatible string for USB2 PHY on sdm845 which was earlier