Re: [PATCH v4 6/7] gpio: exar: switch to using regmap

2020-11-10 Thread Andy Shevchenko
On Tue, Nov 10, 2020 at 05:52:26PM +0100, Bartosz Golaszewski wrote: > On Tue, Nov 10, 2020 at 5:43 PM Andy Shevchenko > wrote: > > > > On Tue, Nov 10, 2020 at 6:37 PM Bartosz Golaszewski > > wrote: > > > On Tue, Nov 10, 2020 at 5:17 PM Andy Shevchenko > > > wrote: ... > > It's not a typo. But

Re: [PATCH v4 6/7] gpio: exar: switch to using regmap

2020-11-10 Thread Bartosz Golaszewski
On Tue, Nov 10, 2020 at 5:43 PM Andy Shevchenko wrote: > > On Tue, Nov 10, 2020 at 6:37 PM Bartosz Golaszewski > wrote: > > On Tue, Nov 10, 2020 at 5:17 PM Andy Shevchenko > > wrote: > > ... > > > > > > > > +static const struct regmap_config exar_regmap_config = { > > > > > > > + .name

Re: [PATCH v4 6/7] gpio: exar: switch to using regmap

2020-11-10 Thread Andy Shevchenko
On Tue, Nov 10, 2020 at 6:37 PM Bartosz Golaszewski wrote: > On Tue, Nov 10, 2020 at 5:17 PM Andy Shevchenko > wrote: ... > > > > > > +static const struct regmap_config exar_regmap_config = { > > > > > > + .name = "exar-gpio", > > > > > > + .reg_bits = 16, > > > > > > > > >

Re: [PATCH v4 6/7] gpio: exar: switch to using regmap

2020-11-10 Thread Bartosz Golaszewski
On Tue, Nov 10, 2020 at 5:17 PM Andy Shevchenko wrote: > > On Tue, Nov 10, 2020 at 04:12:38PM +0100, Bartosz Golaszewski wrote: > > On Tue, Nov 10, 2020 at 4:09 PM Andy Shevchenko > > wrote: > > > > > > On Tue, Nov 10, 2020 at 05:04:47PM +0200, Andy Shevchenko wrote: > > > > On Tue, Nov 10, 2020

Re: [PATCH v4 6/7] gpio: exar: switch to using regmap

2020-11-10 Thread Andy Shevchenko
On Tue, Nov 10, 2020 at 04:12:38PM +0100, Bartosz Golaszewski wrote: > On Tue, Nov 10, 2020 at 4:09 PM Andy Shevchenko > wrote: > > > > On Tue, Nov 10, 2020 at 05:04:47PM +0200, Andy Shevchenko wrote: > > > On Tue, Nov 10, 2020 at 03:55:51PM +0100, Bartosz Golaszewski wrote: > > > > From: Bartosz

Re: [PATCH v4 6/7] gpio: exar: switch to using regmap

2020-11-10 Thread Bartosz Golaszewski
On Tue, Nov 10, 2020 at 4:09 PM Andy Shevchenko wrote: > > On Tue, Nov 10, 2020 at 05:04:47PM +0200, Andy Shevchenko wrote: > > On Tue, Nov 10, 2020 at 03:55:51PM +0100, Bartosz Golaszewski wrote: > > > From: Bartosz Golaszewski > > > > > > We can simplify the code in gpio-exar by using regmap. T

Re: [PATCH v4 6/7] gpio: exar: switch to using regmap

2020-11-10 Thread Andy Shevchenko
On Tue, Nov 10, 2020 at 05:04:47PM +0200, Andy Shevchenko wrote: > On Tue, Nov 10, 2020 at 03:55:51PM +0100, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > > > We can simplify the code in gpio-exar by using regmap. This allows us to > > drop the mutex (regmap provides its own lockin

Re: [PATCH v4 6/7] gpio: exar: switch to using regmap

2020-11-10 Thread Andy Shevchenko
On Tue, Nov 10, 2020 at 03:55:51PM +0100, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > We can simplify the code in gpio-exar by using regmap. This allows us to > drop the mutex (regmap provides its own locking) and we can also reuse > regmap's bit operations instead of implementing

[PATCH v4 6/7] gpio: exar: switch to using regmap

2020-11-10 Thread Bartosz Golaszewski
From: Bartosz Golaszewski We can simplify the code in gpio-exar by using regmap. This allows us to drop the mutex (regmap provides its own locking) and we can also reuse regmap's bit operations instead of implementing our own update function. Signed-off-by: Bartosz Golaszewski --- drivers/gpio