Re: [PATCH v4 6/8] drm/panel: Add Ilitek ILI9881c panel driver

2018-05-03 Thread Maxime Ripard
Hi Thierry, Thanks for your review, I'll fix the other things you pointed out. On Thu, Apr 26, 2018 at 05:07:12PM +0200, Thierry Reding wrote: > > +static int ili9881c_send_cmd_data(struct ili9881c *ctx, u8 cmd, u8 data) > > +{ > > + u8 buf[2] = { cmd, data }; > > + int ret; > > + > > + ret

Re: [PATCH v4 6/8] drm/panel: Add Ilitek ILI9881c panel driver

2018-04-26 Thread Thierry Reding
On Wed, Apr 04, 2018 at 11:57:14AM +0200, Maxime Ripard wrote: > The LHR050H41 panel is the panel shipped with the BananaPi M2-Magic, and is > based on the Ilitek ILI9881c Controller. Add a driver for it, modelled > after the other Ilitek controller drivers. > > Signed-off-by: Maxime Ripard > ---

[PATCH v4 6/8] drm/panel: Add Ilitek ILI9881c panel driver

2018-04-04 Thread Maxime Ripard
The LHR050H41 panel is the panel shipped with the BananaPi M2-Magic, and is based on the Ilitek ILI9881c Controller. Add a driver for it, modelled after the other Ilitek controller drivers. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/panel/Kconfig | 9 +- drivers/gpu/drm/p