Re: [PATCH v4 69/78] ncr5380: Fix whitespace in comments using regexp

On Sun, 2016-01-03 at 22:05 +, One Thousand Gnomes wrote: > On Sun, 03 Jan 2016 13:46:22 -0800 > Joe Perches wrote: > > > (using an email address for James that shouldn't bounce) > > > > On Sun, 2016-01-03 at 21:29 +, One Thousand Gnomes wrote: > > > > > I would beg to differ. As a tool

Re: [PATCH v4 69/78] ncr5380: Fix whitespace in comments using regexp

(using an email address for James that shouldn't bounce) On Sun, 2016-01-03 at 21:29 +, One Thousand Gnomes wrote: > > > I would beg to differ. As a tool for understanding the > > > differences as you > > > step through the versions it's invaluable. > > > > This removes intentional

Re: [PATCH v4 69/78] ncr5380: Fix whitespace in comments using regexp

> > I would beg to differ. As a tool for understanding the differences as you > > step through the versions it's invaluable. > > This removes intentional formatting that > makes reading comments easier. And this matters at the end of the patch series because ? -- To unsubscribe from this list:

Re: [PATCH v4 69/78] ncr5380: Fix whitespace in comments using regexp

On Sun, 2016-01-03 at 14:10 +, One Thousand Gnomes wrote: > On Sat, 02 Jan 2016 23:54:28 -0800 > Joe Perches wrote: > > > On Sun, 2016-01-03 at 16:06 +1100, Finn Thain wrote: > > > Hanging indentation was a poor choice for the text inside comments. It > > > has been used in the wrong places

Re: [PATCH v4 69/78] ncr5380: Fix whitespace in comments using regexp

On Sat, 02 Jan 2016 23:54:28 -0800 Joe Perches wrote: > On Sun, 2016-01-03 at 16:06 +1100, Finn Thain wrote: > > Hanging indentation was a poor choice for the text inside comments. It > > has been used in the wrong places and done badly elsewhere. There is > > little consistency within any file.

Re: [PATCH v4 69/78] ncr5380: Fix whitespace in comments using regexp

On Sat, 2 Jan 2016, Joe Perches wrote: > On Sun, 2016-01-03 at 16:06 +1100, Finn Thain wrote: > > Hanging indentation was a poor choice for the text inside comments. It > > has been used in the wrong places and done badly elsewhere. There is > > little consistency within any file. One fork of

Re: [PATCH v4 69/78] ncr5380: Fix whitespace in comments using regexp

> > I would beg to differ. As a tool for understanding the differences as you > > step through the versions it's invaluable. > > This removes intentional formatting that > makes reading comments easier. And this matters at the end of the patch series because ? -- To unsubscribe from this list:

Re: [PATCH v4 69/78] ncr5380: Fix whitespace in comments using regexp

On Sun, 2016-01-03 at 22:05 +, One Thousand Gnomes wrote: > On Sun, 03 Jan 2016 13:46:22 -0800 > Joe Perches wrote: > > > (using an email address for James that shouldn't bounce) > > > > On Sun, 2016-01-03 at 21:29 +, One Thousand Gnomes wrote: > > > > > I would beg to

Re: [PATCH v4 69/78] ncr5380: Fix whitespace in comments using regexp

(using an email address for James that shouldn't bounce) On Sun, 2016-01-03 at 21:29 +, One Thousand Gnomes wrote: > > > I would beg to differ. As a tool for understanding the > > > differences as you > > > step through the versions it's invaluable. > > > > This removes intentional

Re: [PATCH v4 69/78] ncr5380: Fix whitespace in comments using regexp

On Sat, 2 Jan 2016, Joe Perches wrote: > On Sun, 2016-01-03 at 16:06 +1100, Finn Thain wrote: > > Hanging indentation was a poor choice for the text inside comments. It > > has been used in the wrong places and done badly elsewhere. There is > > little consistency within any file. One fork of

Re: [PATCH v4 69/78] ncr5380: Fix whitespace in comments using regexp

On Sat, 02 Jan 2016 23:54:28 -0800 Joe Perches wrote: > On Sun, 2016-01-03 at 16:06 +1100, Finn Thain wrote: > > Hanging indentation was a poor choice for the text inside comments. It > > has been used in the wrong places and done badly elsewhere. There is > > little

Re: [PATCH v4 69/78] ncr5380: Fix whitespace in comments using regexp

On Sun, 2016-01-03 at 14:10 +, One Thousand Gnomes wrote: > On Sat, 02 Jan 2016 23:54:28 -0800 > Joe Perches wrote: > > > On Sun, 2016-01-03 at 16:06 +1100, Finn Thain wrote: > > > Hanging indentation was a poor choice for the text inside comments. It > > > has been used in

Re: [PATCH v4 69/78] ncr5380: Fix whitespace in comments using regexp

On Sun, 2016-01-03 at 16:06 +1100, Finn Thain wrote: > Hanging indentation was a poor choice for the text inside comments. It > has been used in the wrong places and done badly elsewhere. There is > little consistency within any file. One fork of the core driver uses > tabs for this indentation

[PATCH v4 69/78] ncr5380: Fix whitespace in comments using regexp

Hanging indentation was a poor choice for the text inside comments. It has been used in the wrong places and done badly elsewhere. There is little consistency within any file. One fork of the core driver uses tabs for this indentation while the other uses spaces. Better to use flush-left alignment

[PATCH v4 69/78] ncr5380: Fix whitespace in comments using regexp

Hanging indentation was a poor choice for the text inside comments. It has been used in the wrong places and done badly elsewhere. There is little consistency within any file. One fork of the core driver uses tabs for this indentation while the other uses spaces. Better to use flush-left alignment

Re: [PATCH v4 69/78] ncr5380: Fix whitespace in comments using regexp

On Sun, 2016-01-03 at 16:06 +1100, Finn Thain wrote: > Hanging indentation was a poor choice for the text inside comments. It > has been used in the wrong places and done badly elsewhere. There is > little consistency within any file. One fork of the core driver uses > tabs for this indentation