Re: [PATCH v4 8/9] MIPS: SGI-IP27: fix readb/writeb addressing

2019-08-14 Thread Thomas Bogendoerfer
On Tue, 13 Aug 2019 10:47:13 +0200 Philippe Mathieu-Daudé wrote: > Hi Thomas, > > On 8/11/19 9:29 AM, Greg Kroah-Hartman wrote: > > On Sat, Aug 10, 2019 at 04:22:23PM +0300, Andy Shevchenko wrote: > >> On Fri, Aug 9, 2019 at 1:34 PM Thomas Bogendoerfer > >> wrote: > >>> > >>> Our chosen byte sw

Re: [PATCH v4 8/9] MIPS: SGI-IP27: fix readb/writeb addressing

2019-08-13 Thread Philippe Mathieu-Daudé
Hi Thomas, On 8/11/19 9:29 AM, Greg Kroah-Hartman wrote: > On Sat, Aug 10, 2019 at 04:22:23PM +0300, Andy Shevchenko wrote: >> On Fri, Aug 9, 2019 at 1:34 PM Thomas Bogendoerfer >> wrote: >>> >>> Our chosen byte swapping, which is what firmware already uses, is to >>> do readl/writel by normal lw

Re: [PATCH v4 8/9] MIPS: SGI-IP27: fix readb/writeb addressing

2019-08-11 Thread Greg Kroah-Hartman
On Sat, Aug 10, 2019 at 04:22:23PM +0300, Andy Shevchenko wrote: > On Fri, Aug 9, 2019 at 1:34 PM Thomas Bogendoerfer > wrote: > > > > Our chosen byte swapping, which is what firmware already uses, is to > > do readl/writel by normal lw/sw intructions (data invariance). This > > also means we need

Re: [PATCH v4 8/9] MIPS: SGI-IP27: fix readb/writeb addressing

2019-08-10 Thread Andy Shevchenko
On Fri, Aug 9, 2019 at 1:34 PM Thomas Bogendoerfer wrote: > > Our chosen byte swapping, which is what firmware already uses, is to > do readl/writel by normal lw/sw intructions (data invariance). This > also means we need to mangle addresses for u8 and u16 accesses. The > mangling for 16bit has be

[PATCH v4 8/9] MIPS: SGI-IP27: fix readb/writeb addressing

2019-08-09 Thread Thomas Bogendoerfer
Our chosen byte swapping, which is what firmware already uses, is to do readl/writel by normal lw/sw intructions (data invariance). This also means we need to mangle addresses for u8 and u16 accesses. The mangling for 16bit has been done aready, but 8bit one was missing. Correcting this causes diff