RE: [PATCH v4 net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-12 Thread Dexuan Cui
> From: Jakub Kicinski > Sent: Monday, April 12, 2021 11:21 AM > ... > On Sun, 11 Apr 2021 19:34:55 -0700 Dexuan Cui wrote: > > + for (i = 0; i < ANA_INDIRECT_TABLE_SIZE; i++) > > + apc->indir_table[i] = i % apc->num_queues; > > ethtool_rxfh_indir_default() Will use

RE: [PATCH v4 net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-12 Thread Dexuan Cui
> From: Haiyang Zhang > Sent: Monday, April 12, 2021 7:40 AM > > From: Andrew Lunn > > Sent: Monday, April 12, 2021 8:32 AM > > > ... > > > + /* At most num_online_cpus() + 1 interrupts are used. */ > > > + msix_index = queue->eq.msix_index; > > > + if (WARN_ON(msix_index > num_online_cpus())) >

Re: [PATCH v4 net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-12 Thread Jakub Kicinski
On Sun, 11 Apr 2021 19:34:55 -0700 Dexuan Cui wrote: > + for (i = 0; i < ANA_INDIRECT_TABLE_SIZE; i++) > + apc->indir_table[i] = i % apc->num_queues; ethtool_rxfh_indir_default() > + err = mana_cfg_vport_steering(apc, rx, true, update_hash, update_tab); > + return err;

RE: [PATCH v4 net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-12 Thread Haiyang Zhang
nel.org; l...@kernel.org; > be...@petrovitsch.priv.at; rdun...@infradead.org; Shachar Raindel > ; linux-kernel@vger.kernel.org; linux- > hyp...@vger.kernel.org > Subject: Re: [PATCH v4 net-next] net: mana: Add a driver for Microsoft Azure > Network Adapter (MANA) > > > +static voi

RE: [PATCH v4 net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-12 Thread Haiyang Zhang
nel.org; l...@kernel.org; > be...@petrovitsch.priv.at; rdun...@infradead.org; Shachar Raindel > ; linux-kernel@vger.kernel.org; linux- > hyp...@vger.kernel.org > Subject: Re: [PATCH v4 net-next] net: mana: Add a driver for Microsoft Azure > Network Adapter (MANA) > > > +static inline bo

Re: [PATCH v4 net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-12 Thread Andrew Lunn
> +static void mana_gd_deregiser_irq(struct gdma_queue *queue) > +{ > + struct gdma_dev *gd = queue->gdma_dev; > + struct gdma_irq_context *gic; > + struct gdma_context *gc; > + struct gdma_resource *r; > + unsigned int msix_index; > + unsigned long flags; > + > + /* At

Re: [PATCH v4 net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-12 Thread Andrew Lunn
> +static inline bool is_gdma_msg(const void *req) > +{ > + struct gdma_req_hdr *hdr = (struct gdma_req_hdr *)req; > + > + if (hdr->req.hdr_type == GDMA_STANDARD_HEADER_TYPE && > + hdr->resp.hdr_type == GDMA_STANDARD_HEADER_TYPE && > + hdr->req.msg_size >= sizeof(struct

Re: [PATCH v4 net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-12 Thread Andrew Lunn
> > Currently the protocol versin is 0.1.1 You may ask why it's called > > "drv version" rather than "protocol version" -- it's because the PF driver > > calls it that way, so I think here the VF driver may as well use the same > > name. BTW, the "drv ver" info is passed to the PF driver in the

Re: [PATCH v4 net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-12 Thread Leon Romanovsky
On Mon, Apr 12, 2021 at 08:35:32AM +, Dexuan Cui wrote: > > From: Leon Romanovsky > > Sent: Monday, April 12, 2021 12:46 AM > > To: Dexuan Cui > > > ... > > > +#define ANA_MAJOR_VERSION0 > > > +#define ANA_MINOR_VERSION1 > > > +#define ANA_MICRO_VERSION1 > > > >

RE: [PATCH v4 net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-12 Thread Dexuan Cui
> From: Leon Romanovsky > Sent: Monday, April 12, 2021 12:46 AM > To: Dexuan Cui > > ... > > +#define ANA_MAJOR_VERSION 0 > > +#define ANA_MINOR_VERSION 1 > > +#define ANA_MICRO_VERSION 1 > > Please don't introduce drier versions. This is not the usual "driver version", though it's called

Re: [PATCH v4 net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-12 Thread Leon Romanovsky
On Sun, Apr 11, 2021 at 07:34:55PM -0700, Dexuan Cui wrote: > Add a VF driver for Microsoft Azure Network Adapter (MANA) that will be > available in the future. > > Co-developed-by: Haiyang Zhang > Signed-off-by: Haiyang Zhang > Co-developed-by: Shachar Raindel > Signed-off-by: Shachar Raindel