Re: [PATCH v5] ANDROID: binder: change down_write to down_read

On Mon, Apr 16, 2018 at 11:37:27AM +0200, Greg Kroah-Hartman wrote: > On Mon, Apr 16, 2018 at 06:17:48PM +0900, Minchan Kim wrote: > > Hi Ganesh, > > > > On Tue, Apr 10, 2018 at 04:52:58PM +0800, Ganesh Mahendran wrote: > > > > < snip > > > > >> basepatch_v1

Re: [PATCH v5] ANDROID: binder: change down_write to down_read

On Mon, Apr 16, 2018 at 11:37:27AM +0200, Greg Kroah-Hartman wrote: > On Mon, Apr 16, 2018 at 06:17:48PM +0900, Minchan Kim wrote: > > Hi Ganesh, > > > > On Tue, Apr 10, 2018 at 04:52:58PM +0800, Ganesh Mahendran wrote: > > > > < snip > > > > >> basepatch_v1

Re: [PATCH v5] ANDROID: binder: change down_write to down_read

On Mon, Apr 16, 2018 at 11:37:27AM +0200, Greg Kroah-Hartman wrote: > On Mon, Apr 16, 2018 at 06:17:48PM +0900, Minchan Kim wrote: > > Hi Ganesh, > > > > On Tue, Apr 10, 2018 at 04:52:58PM +0800, Ganesh Mahendran wrote: > > > > < snip > > > > >> basepatch_v1

Re: [PATCH v5] ANDROID: binder: change down_write to down_read

On Mon, Apr 16, 2018 at 11:37:27AM +0200, Greg Kroah-Hartman wrote: > On Mon, Apr 16, 2018 at 06:17:48PM +0900, Minchan Kim wrote: > > Hi Ganesh, > > > > On Tue, Apr 10, 2018 at 04:52:58PM +0800, Ganesh Mahendran wrote: > > > > < snip > > > > >> basepatch_v1

Re: [PATCH v5] ANDROID: binder: change down_write to down_read

On Mon, Apr 16, 2018 at 06:17:48PM +0900, Minchan Kim wrote: > Hi Ganesh, > > On Tue, Apr 10, 2018 at 04:52:58PM +0800, Ganesh Mahendran wrote: > > < snip > > > >> basepatch_v1 patch_v5 > > >> --- > > >>

Re: [PATCH v5] ANDROID: binder: change down_write to down_read

On Mon, Apr 16, 2018 at 06:17:48PM +0900, Minchan Kim wrote: > Hi Ganesh, > > On Tue, Apr 10, 2018 at 04:52:58PM +0800, Ganesh Mahendran wrote: > > < snip > > > >> basepatch_v1 patch_v5 > > >> --- > > >>

Re: [PATCH v5] ANDROID: binder: change down_write to down_read

Hi Ganesh, On Tue, Apr 10, 2018 at 04:52:58PM +0800, Ganesh Mahendran wrote: < snip > > >> basepatch_v1 patch_v5 > >> --- > >> 91223.4 90560.2 89644.5 > >> 90520.3

Re: [PATCH v5] ANDROID: binder: change down_write to down_read

Hi Ganesh, On Tue, Apr 10, 2018 at 04:52:58PM +0800, Ganesh Mahendran wrote: < snip > > >> basepatch_v1 patch_v5 > >> --- > >> 91223.4 90560.2 89644.5 > >> 90520.3

Re: [PATCH v5] ANDROID: binder: change down_write to down_read

2018-04-02 18:32 GMT+08:00 Minchan Kim : > Hi Ganesh, > > On Mon, Apr 02, 2018 at 06:01:59PM +0800, Ganesh Mahendran wrote: >> 2018-04-02 15:11 GMT+08:00 Minchan Kim : >> > On Mon, Apr 02, 2018 at 02:46:14PM +0800, Ganesh Mahendran wrote: >> >> 2018-04-02

Re: [PATCH v5] ANDROID: binder: change down_write to down_read

2018-04-02 18:32 GMT+08:00 Minchan Kim : > Hi Ganesh, > > On Mon, Apr 02, 2018 at 06:01:59PM +0800, Ganesh Mahendran wrote: >> 2018-04-02 15:11 GMT+08:00 Minchan Kim : >> > On Mon, Apr 02, 2018 at 02:46:14PM +0800, Ganesh Mahendran wrote: >> >> 2018-04-02 14:34 GMT+08:00 Minchan Kim : >> >> > On

Re: [PATCH v5] ANDROID: binder: change down_write to down_read

2018-04-09 14:40 GMT+08:00 Minchan Kim : > Hi Ganesh, > > Isn't there any update? We were on vacation a few days ago. After the test complete, I will update the result immediately. Thanks. > > On Mon, Apr 2, 2018 at 7:32 PM, Minchan Kim wrote: >> Hi

Re: [PATCH v5] ANDROID: binder: change down_write to down_read

2018-04-09 14:40 GMT+08:00 Minchan Kim : > Hi Ganesh, > > Isn't there any update? We were on vacation a few days ago. After the test complete, I will update the result immediately. Thanks. > > On Mon, Apr 2, 2018 at 7:32 PM, Minchan Kim wrote: >> Hi Ganesh, >> >> On Mon, Apr 02, 2018 at

Re: [PATCH v5] ANDROID: binder: change down_write to down_read

Hi Ganesh, Isn't there any update? On Mon, Apr 2, 2018 at 7:32 PM, Minchan Kim wrote: > Hi Ganesh, > > On Mon, Apr 02, 2018 at 06:01:59PM +0800, Ganesh Mahendran wrote: >> 2018-04-02 15:11 GMT+08:00 Minchan Kim : >> > On Mon, Apr 02, 2018 at 02:46:14PM

Re: [PATCH v5] ANDROID: binder: change down_write to down_read

Hi Ganesh, Isn't there any update? On Mon, Apr 2, 2018 at 7:32 PM, Minchan Kim wrote: > Hi Ganesh, > > On Mon, Apr 02, 2018 at 06:01:59PM +0800, Ganesh Mahendran wrote: >> 2018-04-02 15:11 GMT+08:00 Minchan Kim : >> > On Mon, Apr 02, 2018 at 02:46:14PM +0800, Ganesh Mahendran wrote: >> >>

Re: [PATCH v5] ANDROID: binder: change down_write to down_read

Hi Ganesh, On Mon, Apr 02, 2018 at 06:01:59PM +0800, Ganesh Mahendran wrote: > 2018-04-02 15:11 GMT+08:00 Minchan Kim : > > On Mon, Apr 02, 2018 at 02:46:14PM +0800, Ganesh Mahendran wrote: > >> 2018-04-02 14:34 GMT+08:00 Minchan Kim : > >> > On Fri, Mar

Re: [PATCH v5] ANDROID: binder: change down_write to down_read

Hi Ganesh, On Mon, Apr 02, 2018 at 06:01:59PM +0800, Ganesh Mahendran wrote: > 2018-04-02 15:11 GMT+08:00 Minchan Kim : > > On Mon, Apr 02, 2018 at 02:46:14PM +0800, Ganesh Mahendran wrote: > >> 2018-04-02 14:34 GMT+08:00 Minchan Kim : > >> > On Fri, Mar 30, 2018 at 12:04:07PM +0200, Greg

Re: [PATCH v5] ANDROID: binder: change down_write to down_read

2018-04-02 15:11 GMT+08:00 Minchan Kim : > On Mon, Apr 02, 2018 at 02:46:14PM +0800, Ganesh Mahendran wrote: >> 2018-04-02 14:34 GMT+08:00 Minchan Kim : >> > On Fri, Mar 30, 2018 at 12:04:07PM +0200, Greg Kroah-Hartman wrote: >> >> On Fri, Mar 30, 2018 at

Re: [PATCH v5] ANDROID: binder: change down_write to down_read

2018-04-02 15:11 GMT+08:00 Minchan Kim : > On Mon, Apr 02, 2018 at 02:46:14PM +0800, Ganesh Mahendran wrote: >> 2018-04-02 14:34 GMT+08:00 Minchan Kim : >> > On Fri, Mar 30, 2018 at 12:04:07PM +0200, Greg Kroah-Hartman wrote: >> >> On Fri, Mar 30, 2018 at 10:29:21AM +0900, Minchan Kim wrote: >> >>

Re: [PATCH v5] ANDROID: binder: change down_write to down_read

On Mon, Apr 02, 2018 at 02:46:14PM +0800, Ganesh Mahendran wrote: > 2018-04-02 14:34 GMT+08:00 Minchan Kim : > > On Fri, Mar 30, 2018 at 12:04:07PM +0200, Greg Kroah-Hartman wrote: > >> On Fri, Mar 30, 2018 at 10:29:21AM +0900, Minchan Kim wrote: > >> > Hi Ganesh, > >> > > >> >

Re: [PATCH v5] ANDROID: binder: change down_write to down_read

On Mon, Apr 02, 2018 at 02:46:14PM +0800, Ganesh Mahendran wrote: > 2018-04-02 14:34 GMT+08:00 Minchan Kim : > > On Fri, Mar 30, 2018 at 12:04:07PM +0200, Greg Kroah-Hartman wrote: > >> On Fri, Mar 30, 2018 at 10:29:21AM +0900, Minchan Kim wrote: > >> > Hi Ganesh, > >> > > >> > On Fri, Mar 30,

Re: [PATCH v5] ANDROID: binder: change down_write to down_read

2018-04-02 14:34 GMT+08:00 Minchan Kim : > On Fri, Mar 30, 2018 at 12:04:07PM +0200, Greg Kroah-Hartman wrote: >> On Fri, Mar 30, 2018 at 10:29:21AM +0900, Minchan Kim wrote: >> > Hi Ganesh, >> > >> > On Fri, Mar 30, 2018 at 09:21:55AM +0800, Ganesh Mahendran wrote: >> > >

Re: [PATCH v5] ANDROID: binder: change down_write to down_read

2018-04-02 14:34 GMT+08:00 Minchan Kim : > On Fri, Mar 30, 2018 at 12:04:07PM +0200, Greg Kroah-Hartman wrote: >> On Fri, Mar 30, 2018 at 10:29:21AM +0900, Minchan Kim wrote: >> > Hi Ganesh, >> > >> > On Fri, Mar 30, 2018 at 09:21:55AM +0800, Ganesh Mahendran wrote: >> > > 2018-03-29 14:54

Re: [PATCH v5] ANDROID: binder: change down_write to down_read

On Fri, Mar 30, 2018 at 12:04:07PM +0200, Greg Kroah-Hartman wrote: > On Fri, Mar 30, 2018 at 10:29:21AM +0900, Minchan Kim wrote: > > Hi Ganesh, > > > > On Fri, Mar 30, 2018 at 09:21:55AM +0800, Ganesh Mahendran wrote: > > > 2018-03-29 14:54 GMT+08:00 Minchan Kim : > > > >

Re: [PATCH v5] ANDROID: binder: change down_write to down_read

On Fri, Mar 30, 2018 at 12:04:07PM +0200, Greg Kroah-Hartman wrote: > On Fri, Mar 30, 2018 at 10:29:21AM +0900, Minchan Kim wrote: > > Hi Ganesh, > > > > On Fri, Mar 30, 2018 at 09:21:55AM +0800, Ganesh Mahendran wrote: > > > 2018-03-29 14:54 GMT+08:00 Minchan Kim : > > > >

Re: [PATCH v5] ANDROID: binder: change down_write to down_read

On Fri, Mar 30, 2018 at 10:29:21AM +0900, Minchan Kim wrote: > Hi Ganesh, > > On Fri, Mar 30, 2018 at 09:21:55AM +0800, Ganesh Mahendran wrote: > > 2018-03-29 14:54 GMT+08:00 Minchan Kim : > > > binder_update_page_range needs down_write of mmap_sem because > > > vm_insert_page

Re: [PATCH v5] ANDROID: binder: change down_write to down_read

On Fri, Mar 30, 2018 at 10:29:21AM +0900, Minchan Kim wrote: > Hi Ganesh, > > On Fri, Mar 30, 2018 at 09:21:55AM +0800, Ganesh Mahendran wrote: > > 2018-03-29 14:54 GMT+08:00 Minchan Kim : > > > binder_update_page_range needs down_write of mmap_sem because > > > vm_insert_page need to change

Re: [PATCH v5] ANDROID: binder: change down_write to down_read

On Fri, Mar 30, 2018 at 09:39:03AM +0800, Ganesh Mahendran wrote: > 2018-03-30 9:29 GMT+08:00 Minchan Kim : > > Hi Ganesh, > > > > On Fri, Mar 30, 2018 at 09:21:55AM +0800, Ganesh Mahendran wrote: > >> 2018-03-29 14:54 GMT+08:00 Minchan Kim : > >> >

Re: [PATCH v5] ANDROID: binder: change down_write to down_read

On Fri, Mar 30, 2018 at 09:39:03AM +0800, Ganesh Mahendran wrote: > 2018-03-30 9:29 GMT+08:00 Minchan Kim : > > Hi Ganesh, > > > > On Fri, Mar 30, 2018 at 09:21:55AM +0800, Ganesh Mahendran wrote: > >> 2018-03-29 14:54 GMT+08:00 Minchan Kim : > >> > binder_update_page_range needs down_write of

Re: [PATCH v5] ANDROID: binder: change down_write to down_read

2018-03-30 9:29 GMT+08:00 Minchan Kim : > Hi Ganesh, > > On Fri, Mar 30, 2018 at 09:21:55AM +0800, Ganesh Mahendran wrote: >> 2018-03-29 14:54 GMT+08:00 Minchan Kim : >> > binder_update_page_range needs down_write of mmap_sem because >> > vm_insert_page need

Re: [PATCH v5] ANDROID: binder: change down_write to down_read

2018-03-30 9:29 GMT+08:00 Minchan Kim : > Hi Ganesh, > > On Fri, Mar 30, 2018 at 09:21:55AM +0800, Ganesh Mahendran wrote: >> 2018-03-29 14:54 GMT+08:00 Minchan Kim : >> > binder_update_page_range needs down_write of mmap_sem because >> > vm_insert_page need to change vma->vm_flags to VM_MIXEDMAP

Re: [PATCH v5] ANDROID: binder: change down_write to down_read

Hi Ganesh, On Fri, Mar 30, 2018 at 09:21:55AM +0800, Ganesh Mahendran wrote: > 2018-03-29 14:54 GMT+08:00 Minchan Kim : > > binder_update_page_range needs down_write of mmap_sem because > > vm_insert_page need to change vma->vm_flags to VM_MIXEDMAP unless > > it is set.

Re: [PATCH v5] ANDROID: binder: change down_write to down_read

Hi Ganesh, On Fri, Mar 30, 2018 at 09:21:55AM +0800, Ganesh Mahendran wrote: > 2018-03-29 14:54 GMT+08:00 Minchan Kim : > > binder_update_page_range needs down_write of mmap_sem because > > vm_insert_page need to change vma->vm_flags to VM_MIXEDMAP unless > > it is set. However, when I profile

Re: [PATCH v5] ANDROID: binder: change down_write to down_read

2018-03-29 14:54 GMT+08:00 Minchan Kim : > binder_update_page_range needs down_write of mmap_sem because > vm_insert_page need to change vma->vm_flags to VM_MIXEDMAP unless > it is set. However, when I profile binder working, it seems > every binder buffers should be mapped in

Re: [PATCH v5] ANDROID: binder: change down_write to down_read

2018-03-29 14:54 GMT+08:00 Minchan Kim : > binder_update_page_range needs down_write of mmap_sem because > vm_insert_page need to change vma->vm_flags to VM_MIXEDMAP unless > it is set. However, when I profile binder working, it seems > every binder buffers should be mapped in advance by

[PATCH v5] ANDROID: binder: change down_write to down_read

binder_update_page_range needs down_write of mmap_sem because vm_insert_page need to change vma->vm_flags to VM_MIXEDMAP unless it is set. However, when I profile binder working, it seems every binder buffers should be mapped in advance by binder_mmap. It means we could set VM_MIXEDMAP in

[PATCH v5] ANDROID: binder: change down_write to down_read

binder_update_page_range needs down_write of mmap_sem because vm_insert_page need to change vma->vm_flags to VM_MIXEDMAP unless it is set. However, when I profile binder working, it seems every binder buffers should be mapped in advance by binder_mmap. It means we could set VM_MIXEDMAP in