On Thu, Dec 14, 2017 at 09:32:44AM +, Charles Keepax wrote:
> Not sure what you mean here but setting up CODEC registers
> directly from the machine driver is probably not ideal. You
> should probably be looking into regmap_register_patch this lets
> you apply a bunch of register settings to t
On Fri, Dec 15, 2017 at 11:36:54AM +, Charles Keepax wrote:
> Hmm... might need to think about the case of whether to share a
> clock depends a little on what the hardware actually looks like.
>
> But basically my point is that writing random CODEC registers
> from the machine driver is not v
On Thu, Dec 14, 2017 at 04:43:10PM -0600, Steven Eckhoff wrote:
> On Thu, Dec 14, 2017 at 04:36:17PM -0600, Steven Eckhoff wrote:
> > On Thu, Dec 14, 2017 at 09:32:44AM +, Charles Keepax wrote:
> >
> > > Not sure what you mean here but setting up CODEC registers
> > > directly from the machine
On Thu, Dec 14, 2017 at 04:36:17PM -0600, Steven Eckhoff wrote:
> On Thu, Dec 14, 2017 at 09:32:44AM +, Charles Keepax wrote:
>
> > Not sure what you mean here but setting up CODEC registers
> > directly from the machine driver is probably not ideal. You
> > should probably be looking into reg
On Thu, Dec 14, 2017 at 09:32:44AM +, Charles Keepax wrote:
> Not sure what you mean here but setting up CODEC registers
> directly from the machine driver is probably not ideal. You
> should probably be looking into regmap_register_patch this lets
> you apply a bunch of register settings to t
On Tue, Dec 12, 2017 at 03:31:16PM -0600, Steven Eckhoff wrote:
> On Tue, Dec 12, 2017 at 04:32:54PM +, Mark Brown wrote:
> > On Mon, Dec 11, 2017 at 01:54:25PM -0600, Steven Eckhoff wrote:
> > > +static int tscs42xx_probe(struct snd_soc_codec *codec)
> > > +{
> > > + int i;
> > > + int ret;
>
On Wed, Dec 13, 2017 at 10:47:32AM +, Mark Brown wrote:
> The things the driver is doing automatically to mute the DACs and ADCs
> should be moved to user control if they're not suitable for doing
> automatically.
>
The mutes can work normally without the PLL stuff. I have removed the PLL
stuf
On Tue, Dec 12, 2017 at 04:51:35PM -0600, Steven Eckhoff wrote:
> Also I am not sure what you mean with the mute controls. Could you
> elaborate more on this?
The things the driver is doing automatically to mute the DACs and ADCs
should be moved to user control if they're not suitable for doing
a
On Tue, Dec 12, 2017 at 04:51:35PM -0600, Steven Eckhoff wrote:
> > > > +static int tscs42xx_mute_stream(struct snd_soc_dai *dai, int mute, int
> > > > stream)
> > > > +{
> > > > + struct snd_soc_codec *codec = dai->codec;
> > > > + int ret;
> > > > +
> > > > + if (mute)
> > > >
On Tue, Dec 12, 2017 at 03:31:16PM -0600, Steven Eckhoff wrote:
> On Tue, Dec 12, 2017 at 04:32:54PM +, Mark Brown wrote:
> > On Mon, Dec 11, 2017 at 01:54:25PM -0600, Steven Eckhoff wrote:
> > > Currently there is no support for the TSCS42xx audio CODEC.
> > >
> > > Add support for it.
> > >
On Tue, Dec 12, 2017 at 04:32:54PM +, Mark Brown wrote:
> On Mon, Dec 11, 2017 at 01:54:25PM -0600, Steven Eckhoff wrote:
> > Currently there is no support for the TSCS42xx audio CODEC.
> >
> > Add support for it.
> >
> > v5 attempts to address all issues raised in the previous reviews.
> >
On Tue, Dec 12, 2017 at 02:10:09PM +0100, Takashi Iwai wrote:
> On Tue, 12 Dec 2017 14:04:01 +0100,
> Charles Keepax wrote:
> >
> > On Mon, Dec 11, 2017 at 01:54:25PM -0600, Steven Eckhoff wrote:
> > > Currently there is no support for the TSCS42xx audio CODEC.
> > >
> > > Add support for it.
> >
On Tue, Dec 12, 2017 at 01:04:01PM +, Charles Keepax wrote:
> On Mon, Dec 11, 2017 at 01:54:25PM -0600, Steven Eckhoff wrote:
> > Currently there is no support for the TSCS42xx audio CODEC.
> >
> > Add support for it.
> >
> > v5 attempts to address all issues raised in the previous reviews.
>
On Mon, Dec 11, 2017 at 01:54:25PM -0600, Steven Eckhoff wrote:
> Currently there is no support for the TSCS42xx audio CODEC.
>
> Add support for it.
>
> v5 attempts to address all issues raised in the previous reviews.
>
> Thank you to everyone who has invested their time reviewing these
> patc
On Tue, 12 Dec 2017 14:04:01 +0100,
Charles Keepax wrote:
>
> On Mon, Dec 11, 2017 at 01:54:25PM -0600, Steven Eckhoff wrote:
> > Currently there is no support for the TSCS42xx audio CODEC.
> >
> > Add support for it.
> >
> > v5 attempts to address all issues raised in the previous reviews.
> >
On Mon, Dec 11, 2017 at 01:54:25PM -0600, Steven Eckhoff wrote:
> Currently there is no support for the TSCS42xx audio CODEC.
>
> Add support for it.
>
> v5 attempts to address all issues raised in the previous reviews.
>
> Thank you to everyone who has invested their time reviewing these
> patc
Currently there is no support for the TSCS42xx audio CODEC.
Add support for it.
v5 attempts to address all issues raised in the previous reviews.
Thank you to everyone who has invested their time reviewing these
patches.
Acked-by: Philippe Ombredanne
Signed-off-by: Steven Eckhoff
---
.../dev
17 matches
Mail list logo
