RE: [PATCH v5] Fix the resolution issue in ChromeOS

2015-06-13 Thread Hn Chen
: [PATCH v5] Fix the resolution issue in ChromeOS On Wed, Jun 10, 2015 at 4:51 PM, Hn Chen wrote: > Hi, Frans, > >> Alright, I was just wondering. Seems like a waste to be waiting for >> something that's already finished ;-). >> There's of course a risk that ti

Re: [PATCH v5] Fix the resolution issue in ChromeOS

2015-06-12 Thread Frans Klaver
On Wed, Jun 10, 2015 at 4:51 PM, Hn Chen wrote: > Hi, Frans, > >> Alright, I was just wondering. Seems like a waste to be waiting for >> something that's already finished ;-). >> There's of course a risk that times may fluctuate between firmware versions. >> Did you take that into account in the

Re: [PATCH v5] Fix the resolution issue in ChromeOS

2015-06-12 Thread Dmitry Torokhov
Hi Hn, On Wed, Jun 10, 2015 at 10:41:26PM +0800, Hn Chen wrote: > Hi, Dmitry, > > Thanks for your suggestion ! > > > Thank you for making changes, I have some more comments. By the way, have > > you tried running scripts/checkpatch.pl over your patch? > > It often picks up some common issues.

RE: [PATCH v5] Fix the resolution issue in ChromeOS

2015-06-10 Thread Hn Chen
x-in...@vger.kernel.org; linux-kernel@vger.kernel.org; dmitry.torok...@gmail.com Subject: Re: [PATCH v5] Fix the resolution issue in ChromeOS On Tue, Jun 02, 2015 at 12:39:13AM +0800, Hn Chen wrote: > Hi, Klaver, > > Sorry for replying late and thanks for your opinion ! > > A

RE: [PATCH v5] Fix the resolution issue in ChromeOS

2015-06-10 Thread Hn Chen
Hi, Dmitry, Thanks for your suggestion ! > Thank you for making changes, I have some more comments. By the way, have you > tried running scripts/checkpatch.pl over your patch? > It often picks up some common issues. I did the check before I submit the patch every time. Below is the way what I

Re: [PATCH v5] Fix the resolution issue in ChromeOS

2015-06-07 Thread Dmitry Torokhov
Hi Hn, On Fri, May 29, 2015 at 12:27:29PM +0800, HungNien Chen wrote: > Signed-off-by: HungNien Chen Thank you for making changes, I have some more comments. By the way, have you tried running scripts/checkpatch.pl over your patch? It often picks up some common issues. > --- > drivers/input/to

Re: [PATCH v5] Fix the resolution issue in ChromeOS

2015-06-01 Thread Frans Klaver
On Tue, Jun 02, 2015 at 12:39:13AM +0800, Hn Chen wrote: > Hi, Klaver, > > Sorry for replying late and thanks for your opinion ! > > About the patch descrition, I will follow your suggestion and Ok. More on this is in Documentation/SubmittingPatches. > maybe add more commemts between codes to

Re: [PATCH v5] Fix the resolution issue in ChromeOS

2015-05-28 Thread Frans Klaver
Hi, On Fri, May 29, 2015 at 6:27 AM, HungNien Chen wrote: > Signed-off-by: HungNien Chen This seems rather short for adding a new driver. I also just noticed that your subjects don't quite match up with the actual contents of the commit. They rather seem to mention the difference between the cu

[PATCH v5] Fix the resolution issue in ChromeOS

2015-05-28 Thread HungNien Chen
Signed-off-by: HungNien Chen --- drivers/input/touchscreen/Kconfig | 12 + drivers/input/touchscreen/Makefile |1 + drivers/input/touchscreen/wdt87xx_i2c.c | 1404 +++ 3 files changed, 1417 insertions(+) create mode 100644 drivers/input/touchscreen/wd