Re: [PATCH v5] NET: Add ezchip ethernet driver

2015-06-23 Thread David Miller
From: Mahesh Bandewar Date: Mon, 22 Jun 2015 10:45:15 -0700 > On Tue, Jun 16, 2015 at 7:35 AM, Noam Camus wrote: >> @@ -0,0 +1,27 @@ >> +# >> +# EZchip network device configuration >> +# >> + >> +config NET_VENDOR_EZCHIP >> + bool "EZchip devices" >> + default y >> > Why this has to

RE: [PATCH v5] NET: Add ezchip ethernet driver

2015-06-22 Thread Noam Camus
From: Mahesh Bandewar [mailto:mahe...@google.com] Sent: Monday, June 22, 2015 8:45 PM > > a/drivers/net/ethernet/ezchip/Kconfig > > b/drivers/net/ethernet/ezchip/Kconfig > > new file mode 100644 > > index 000..d031177 > > --- /dev/null > > +++ b/drivers/net/ethernet/ezchip/Kconfig > > @@ -0,

Re: [PATCH v5] NET: Add ezchip ethernet driver

2015-06-22 Thread Paul Gortmaker
[Re: [PATCH v5] NET: Add ezchip ethernet driver] On 22/06/2015 (Mon 10:45) Mahesh Bandewar wrote: > On Tue, Jun 16, 2015 at 7:35 AM, Noam Camus wrote: > > > > From: Noam Camus > > > > Simple LAN device for debug or management purposes. > > Device supports in

Re: [PATCH v5] NET: Add ezchip ethernet driver

2015-06-22 Thread Mahesh Bandewar
On Tue, Jun 16, 2015 at 7:35 AM, Noam Camus wrote: > > From: Noam Camus > > Simple LAN device for debug or management purposes. > Device supports interrupts for RX and TX(completion). > Device does not have DMA ability. > > Signed-off-by: Noam Camus > Signed-off-by: Tal Zilcer > Acked-by: Alexe

RE: [PATCH v5] NET: Add ezchip ethernet driver

2015-06-22 Thread Noam Camus
From: David Miller [mailto:da...@davemloft.net] Sent: Sunday, June 21, 2015 7:22 PM > This builds with several warnings and also doesn't compile. > > drivers/net/ethernet/ezchip/nps_enet.c: In function ‘nps_enet_read_rx_fifo’: > drivers/net/ethernet/ezchip/nps_enet.c:43:24: warning: cast from poi

Re: [PATCH v5] NET: Add ezchip ethernet driver

2015-06-21 Thread David Miller
From: Noam Camus Date: Tue, 16 Jun 2015 17:35:42 +0300 > From: Noam Camus > > Simple LAN device for debug or management purposes. > Device supports interrupts for RX and TX(completion). > Device does not have DMA ability. > > Signed-off-by: Noam Camus > Signed-off-by: Tal Zilcer > Acked-by:

[PATCH v5] NET: Add ezchip ethernet driver

2015-06-16 Thread Noam Camus
From: Noam Camus Simple LAN device for debug or management purposes. Device supports interrupts for RX and TX(completion). Device does not have DMA ability. Signed-off-by: Noam Camus Signed-off-by: Tal Zilcer Acked-by: Alexey Brodkin --- Change log for v5: Basically its all based on Florian c