Re: [PATCH v5] chrome/platform: cros_ec_proto: Add trace event to trace EC commands

2019-04-16 Thread Enric Balletbo i Serra
Hi Raul, I really like the idea to have trace functionality in cros-ec. Only some few comments below and the patch looks good to me. On 15/4/19 22:57, Raul E Rangel wrote: > This is useful to see which EC commands are being executed and when. > > To enable: > > echo 'cros_ec:*' >> /sys/kern

Re: [PATCH v5] chrome/platform: cros_ec_proto: Add trace event to trace EC commands

2019-04-15 Thread Steven Rostedt
On Mon, 15 Apr 2019 14:57:04 -0600 Raul E Rangel wrote: > This is useful to see which EC commands are being executed and when. > > To enable: > > echo 'cros_ec:*' >> /sys/kernel/debug/tracing/set_event Note, you can accomplish the same thing with: echo 1 > /sys/kernel/debug/tracing/even

[PATCH v5] chrome/platform: cros_ec_proto: Add trace event to trace EC commands

2019-04-15 Thread Raul E Rangel
This is useful to see which EC commands are being executed and when. To enable: echo 'cros_ec:*' >> /sys/kernel/debug/tracing/set_event Example: /* cros_ec_cmd: version: 0, command: EC_CMD_GET_VERSION */ /* cros_ec_cmd: version: 0, command: EC_CMD_GET_PROTOCOL_INFO */ /* cros_ec