RE: [PATCH v5] gpio: dwapb: Add support for 1 interrupt per port A GPIO

2018-05-09 Thread Phil Edworthy
Hi Andy, On 05 May 2018 11:49 Andy Shevchenko wrote: > On Thu, Apr 26, 2018 at 7:19 PM, Phil Edworthy wrote: > > Sotty fo a late response. Consider follow up fixes for below. > > > if (!pp->irq_shared) { > > + int i; > > + > > + for (i = 0; i < pp->ngpio; i++)

Re: [PATCH v5] gpio: dwapb: Add support for 1 interrupt per port A GPIO

2018-05-05 Thread Andy Shevchenko
On Thu, Apr 26, 2018 at 7:19 PM, Phil Edworthy wrote: Sotty fo a late response. Consider follow up fixes for below. > if (!pp->irq_shared) { > + int i; > + > + for (i = 0; i < pp->ngpio; i++) { > + if (pp->irq[i]) > +

Re: [PATCH v5] gpio: dwapb: Add support for 1 interrupt per port A GPIO

2018-05-02 Thread Linus Walleij
On Thu, Apr 26, 2018 at 6:19 PM, Phil Edworthy wrote: > The DesignWare GPIO IP can be configured for either 1 interrupt or 1 > per GPIO in port A, but the driver currently only supports 1 interrupt. > See the DesignWare DW_apb_gpio Databook description of the > 'GPIO_INTR_IO' parameter. > > This

Re: [PATCH v5] gpio: dwapb: Add support for 1 interrupt per port A GPIO

2018-04-26 Thread Hoan Tran
Hi, On Thu, Apr 26, 2018 at 9:19 AM, Phil Edworthy wrote: > The DesignWare GPIO IP can be configured for either 1 interrupt or 1 > per GPIO in port A, but the driver currently only supports 1 interrupt. > See the DesignWare DW_apb_gpio Databook description of the > 'GPIO_INTR_IO' parameter. > > T

[PATCH v5] gpio: dwapb: Add support for 1 interrupt per port A GPIO

2018-04-26 Thread Phil Edworthy
The DesignWare GPIO IP can be configured for either 1 interrupt or 1 per GPIO in port A, but the driver currently only supports 1 interrupt. See the DesignWare DW_apb_gpio Databook description of the 'GPIO_INTR_IO' parameter. This change allows the driver to work with up to 32 interrupts, it will