Re: [PATCH v5] hv_netvsc: add support for vlans in AF_PACKET mode

2020-07-22 Thread Sriram Krishnan (srirakr2)
On 22/07/20, 8:49 PM, "Jakub Kicinski" wrote: > Please run checkpatch on your submissions: > WARNING: Missing a blank line after declarations > #76: FILE: drivers/net/hyperv/netvsc_drv.c:614: > + u16 vlan_tci = 0; > + skb_reset_mac_header(skb); > ERROR: code

Re: [PATCH v5] hv_netvsc: add support for vlans in AF_PACKET mode

2020-07-22 Thread Jakub Kicinski
On Wed, 22 Jul 2020 12:38:07 +0530 Sriram Krishnan wrote: > + /* When using AF_PACKET we need to drop VLAN header from > + * the frame and update the SKB to allow the HOST OS > + * to transmit the 802.1Q packet > + */ > + if (skb->protocol == htons(ETH_P_8021Q)) { > +

[PATCH v5] hv_netvsc: add support for vlans in AF_PACKET mode

2020-07-22 Thread Sriram Krishnan
Vlan tagged packets are getting dropped when used with DPDK that uses the AF_PACKET interface on a hyperV guest. The packet layer uses the tpacket interface to communicate the vlans information to the upper layers. On Rx path, these drivers can read the vlan info from the tpacket header but on the