Re: [PATCH v5] leaking_addresses: add generic 32-bit support

2018-01-13 Thread Tobin C. Harding
On Sat, Jan 13, 2018 at 10:55:26AM +, Kaiwan N Billimoria wrote: > Hi Tobin, > > Thanks very much for your detailed review. > Just wanted to say that am up to my neck in work (an exceptionally busy > time), hence will take a while to work on this - around another 3 weeks > perhaps. > I'd like

Re: [PATCH v5] leaking_addresses: add generic 32-bit support

2018-01-05 Thread Tobin C. Harding
Hi Kaiwan, Thanks for the patch On Thu, Jan 04, 2018 at 05:51:25PM +0530, kaiwan.billimo...@gmail.com wrote: > The script now attempts to detect the architecture it's running upon; as of > now, > we explicitly support x86_64, PPC64, ARM64, MIPS64 and x86_32. This is incorrect. We do not current

Re: [PATCH v5] leaking_addresses: add generic 32-bit support

2018-01-04 Thread kaiwan . billimoria
As a follow-up, pl see below some quick test cases on an emulated ARM32 platform (the Yocto-based qemuarm32 ARM Versatile): root@qemuarm:~# ./leaking_addresses.pl FATAL: Script does not recognize your architecture $ uname -m armv5tejl root@qemuarm:~

[PATCH v5] leaking_addresses: add generic 32-bit support

2018-01-04 Thread kaiwan . billimoria
The script now attempts to detect the architecture it's running upon; as of now, we explicitly support x86_64, PPC64, ARM64, MIPS64 and x86_32. If it's one of them, we proceed "normally". If we fail to detect the arch, we fallback to 64-bit scanning, _unless_ the user has passed either of these op