Re: [PATCH v5] perf stat: Fix wrong skipping for per-die aggregation

2021-01-14 Thread Jiri Olsa
On Thu, Jan 14, 2021 at 03:30:47PM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Jan 13, 2021 at 12:07:01PM +0100, Jiri Olsa escreveu: > > On Wed, Jan 13, 2021 at 09:56:31AM +0800, Jin Yao wrote: > > > > SNIP > > > > > > > > root@lkp-csl-2ap4 ~# ./perf stat -a -I 1000 -e llc_misses.mem_read

Re: [PATCH v5] perf stat: Fix wrong skipping for per-die aggregation

2021-01-14 Thread Arnaldo Carvalho de Melo
Em Wed, Jan 13, 2021 at 12:07:01PM +0100, Jiri Olsa escreveu: > On Wed, Jan 13, 2021 at 09:56:31AM +0800, Jin Yao wrote: > > SNIP > > > > > root@lkp-csl-2ap4 ~# ./perf stat -a -I 1000 -e llc_misses.mem_read > > --per-die -- sleep 5 > > 1.001586691 S0-D0 11229440

Re: [PATCH v5] perf stat: Fix wrong skipping for per-die aggregation

2021-01-13 Thread Jin, Yao
On 1/13/2021 7:07 PM, Jiri Olsa wrote: On Wed, Jan 13, 2021 at 09:56:31AM +0800, Jin Yao wrote: SNIP root@lkp-csl-2ap4 ~# ./perf stat -a -I 1000 -e llc_misses.mem_read --per-die -- sleep 5 1.001586691 S0-D0 11229440 Bytes llc_misses.mem_read 1.001586691

Re: [PATCH v5] perf stat: Fix wrong skipping for per-die aggregation

2021-01-13 Thread Jiri Olsa
On Wed, Jan 13, 2021 at 09:56:31AM +0800, Jin Yao wrote: SNIP > > root@lkp-csl-2ap4 ~# ./perf stat -a -I 1000 -e llc_misses.mem_read --per-die > -- sleep 5 > 1.001586691 S0-D0 11229440 Bytes > llc_misses.mem_read > 1.001586691 S0-D1 1

[PATCH v5] perf stat: Fix wrong skipping for per-die aggregation

2021-01-12 Thread Jin Yao
Uncore becomes die-scope on Xeon Cascade Lake-AP and perf has supported --per-die aggregation yet. One issue is found in check_per_pkg() for uncore events running on AP system. On cascade Lake-AP, we have: S0-D0 S0-D1 S1-D0 S1-D1 But in check_per_pkg(), S0-D1 and S1-D1 are skipped because the