Re: [PATCH v5] rtc: support DS1302 RTC on ICP DAS LP-8x4x

2015-12-24 Thread Sergei Ianovich
On Thu, 2015-12-24 at 12:04 +0100, Alexandre Belloni wrote: > On 22/12/2015 at 12:16:41 -0600, Rob Herring wrote : > > Well, the binding should reflect that, whether the driver needs to > > be > > re-written is somewhat a separate question. That should probably > > have > > been done for the DS1302

Re: [PATCH v5] rtc: support DS1302 RTC on ICP DAS LP-8x4x

2015-12-24 Thread Alexandre Belloni
Hi, On 22/12/2015 at 12:16:41 -0600, Rob Herring wrote : > Well, the binding should reflect that, whether the driver needs to be > re-written is somewhat a separate question. That should probably have > been done for the DS1302 driver originally and it is not too fair for > the 2nd person to fix i

Re: [PATCH v5] rtc: support DS1302 RTC on ICP DAS LP-8x4x

2015-12-22 Thread Rob Herring
On Sun, Dec 20, 2015 at 6:14 AM, Sergei Ianovich wrote: > On Sat, 2015-12-19 at 21:38 -0600, Rob Herring wrote: >> On Tue, Dec 15, 2015 at 08:45:23PM +0300, Sergei Ianovich wrote: [...] >> > diff --git a/Documentation/devicetree/bindings/rtc/rtc-ds1302.txt >> > b/Documentation/devicetree/binding

Re: [PATCH v5] rtc: support DS1302 RTC on ICP DAS LP-8x4x

2015-12-20 Thread Sergei Ianovich
On Sat, 2015-12-19 at 21:38 -0600, Rob Herring wrote: > On Tue, Dec 15, 2015 at 08:45:23PM +0300, Sergei Ianovich wrote: > > Nothing in this is specific to ICP, so the subject should be updated. > > > Signed-off-by: Sergei Ianovich > > CC: Alexandre Belloni > > --- > >    v4..v5 > >    * drop T

Re: [PATCH v5] rtc: support DS1302 RTC on ICP DAS LP-8x4x

2015-12-19 Thread Rob Herring
On Tue, Dec 15, 2015 at 08:45:23PM +0300, Sergei Ianovich wrote: Nothing in this is specific to ICP, so the subject should be updated. > Signed-off-by: Sergei Ianovich > CC: Alexandre Belloni > --- >v4..v5 >* drop THIS_MODULE from struct platform driver >* use "dallas" for vendor na

[PATCH v5] rtc: support DS1302 RTC on ICP DAS LP-8x4x

2015-12-15 Thread Sergei Ianovich
Signed-off-by: Sergei Ianovich CC: Alexandre Belloni --- v4..v5 * drop THIS_MODULE from struct platform driver * use "dallas" for vendor name per vendor-prefixes.txt v3..v4 * move DTS bindings to a different patch v2..v3 * use usleep_range instead of custom nsleep * numb