Re: [PATCH v5] selinux: fix a missing-check bug in selinux_sb_eat_lsm_opts()

2019-06-12 Thread Paul Moore
On Wed, Jun 12, 2019 at 9:55 AM Gen Zhang wrote: > > In selinux_sb_eat_lsm_opts(), 'arg' is allocated by kmemdup_nul(). It > returns NULL when fails. So 'arg' should be checked. And 'mnt_opts' > should be freed when error. > > Signed-off-by: Gen Zhang > Fixes: 99dbbb593fe6 ("selinux: rewrite seli

[PATCH v5] selinux: fix a missing-check bug in selinux_sb_eat_lsm_opts()

2019-06-12 Thread Gen Zhang
In selinux_sb_eat_lsm_opts(), 'arg' is allocated by kmemdup_nul(). It returns NULL when fails. So 'arg' should be checked. And 'mnt_opts' should be freed when error. Signed-off-by: Gen Zhang Fixes: 99dbbb593fe6 ("selinux: rewrite selinux_sb_eat_lsm_opts()") --- diff --git a/security/selinux/hook

[PATCH v5] selinux: fix a missing-check bug in selinux_sb_eat_lsm_opts()

2019-06-12 Thread Gen Zhang
In selinux_sb_eat_lsm_opts(), 'arg' is allocated by kmemdup_nul(). It returns NULL when fails. So 'arg' should be checked. And 'mnt_opts' should be freed when error. Signed-off-by: Gen Zhang Fixes: 99dbbb593fe6 ("selinux: rewrite selinux_sb_eat_lsm_opts()") diff --git a/security/selinux/hooks.c