Re: [PATCH v5] zram: break the strict dependency from lzo

2020-11-22 Thread Rui Salvaterra
Hi, Minchan, On Sat, 21 Nov 2020 at 00:44, Rui Salvaterra wrote: > > Well, it's quite possible I mis{read,applied} your patch. And I obviously did. Your kconfig suggestion does basically the same, in a more simplified way. I guess a v6 is in order. Thanks, Rui

Re: [PATCH v5] zram: break the strict dependency from lzo

2020-11-20 Thread Rui Salvaterra
Hi, Minchan, On Fri, 20 Nov 2020 at 21:40, Minchan Kim wrote: > > Do I miss your point? Well, it's quite possible I mis{read,applied} your patch. It's late here, I'll test it with fresher brains tomorrow to see if it's functionally equivalent. Thanks, Rui

Re: [PATCH v5] zram: break the strict dependency from lzo

2020-11-20 Thread Minchan Kim
On Fri, Nov 20, 2020 at 09:10:13AM +, Rui Salvaterra wrote: > Hi, Minchan, > > On Thu, 19 Nov 2020 at 22:26, Minchan Kim wrote: > > > > What's the purpose of ZRAM_AUTOSEL_ALGO? > > If you and Sergey already discussed, sorry about the missing it. > > The purpose of ZRAM_AUTOSEL_ALGO is to

Re: [PATCH v5] zram: break the strict dependency from lzo

2020-11-20 Thread Rui Salvaterra
Hi, Minchan, On Thu, 19 Nov 2020 at 22:26, Minchan Kim wrote: > > What's the purpose of ZRAM_AUTOSEL_ALGO? > If you and Sergey already discussed, sorry about the missing it. The purpose of ZRAM_AUTOSEL_ALGO is to make sure at least one of the required compression algorithms is enabled, either

Re: [PATCH v5] zram: break the strict dependency from lzo

2020-11-19 Thread Minchan Kim
On Sun, Nov 15, 2020 at 10:15:14AM +, Rui Salvaterra wrote: > From the beginning, the zram block device always enabled CRYPTO_LZO, since > lzo-rle is hardcoded as the fallback compression algorithm. As a consequence, > on > systems where another compression algorithm is chosen (e.g.

[PATCH v5] zram: break the strict dependency from lzo

2020-11-15 Thread Rui Salvaterra
>From the beginning, the zram block device always enabled CRYPTO_LZO, since lzo-rle is hardcoded as the fallback compression algorithm. As a consequence, on systems where another compression algorithm is chosen (e.g. CRYPTO_ZSTD), the lzo kernel module becomes unused, while still having to be