RE: [PATCH v5 0/3] close_range()

2020-06-07 Thread David Laight
From: Christian Brauner > Sent: 04 June 2020 00:24 .. > -struct files_struct *dup_fd(struct files_struct *oldf, int *errorp) > +struct files_struct *dup_fd(struct files_struct *oldf, unsigned int max_fds, > int *errorp) Shouldn't this get changed to use ERR_PTR() etc? .. > -int __close_range(str

Re: [PATCH v5 0/3] close_range()

2020-06-03 Thread Christian Brauner
On Wed, Jun 03, 2020 at 05:13:36PM -0700, Linus Torvalds wrote: > On Wed, Jun 3, 2020 at 4:24 PM Christian Brauner > wrote: > > > > Ok, here's what I have. Does the below look somewhat sane? > > Probably. Needs lots of testing. But this one looks wrong: Right, there's a patch for a test-suite fo

Re: [PATCH v5 0/3] close_range()

2020-06-03 Thread Linus Torvalds
On Wed, Jun 3, 2020 at 4:24 PM Christian Brauner wrote: > > Ok, here's what I have. Does the below look somewhat sane? Probably. Needs lots of testing. But this one looks wrong: > +int __close_range(unsigned fd, unsigned max_fd, unsigned int flags) > { > + if ((max_fd + 1) >= cur_

Re: [PATCH v5 0/3] close_range()

2020-06-03 Thread Christian Brauner
On Tue, Jun 02, 2020 at 05:08:22PM -0700, Linus Torvalds wrote: > On Tue, Jun 2, 2020 at 4:33 PM Christian Brauner > wrote: > > > > > > And maybe this _did_ get mentioned last time, and I just don't find > > > it. I also don't see anything like that in the patches, although the > > > flags argumen

Re: [PATCH v5 0/3] close_range()

2020-06-02 Thread Linus Torvalds
On Tue, Jun 2, 2020 at 4:33 PM Christian Brauner wrote: > > > > And maybe this _did_ get mentioned last time, and I just don't find > > it. I also don't see anything like that in the patches, although the > > flags argument is there. > > I spent some good time digging and I couldn't find this ment

Re: [PATCH v5 0/3] close_range()

2020-06-02 Thread Christian Brauner
On Tue, Jun 02, 2020 at 02:03:09PM -0700, Linus Torvalds wrote: > On Tue, Jun 2, 2020 at 1:42 PM Christian Brauner > wrote: > > > > This is a resend of the close_range() syscall, as discussed in [1]. There > > weren't any outstanding > > discussions anymore and this was in mergeable shape. I simp

Re: [PATCH v5 0/3] close_range()

2020-06-02 Thread Linus Torvalds
On Tue, Jun 2, 2020 at 1:42 PM Christian Brauner wrote: > > This is a resend of the close_range() syscall, as discussed in [1]. There > weren't any outstanding > discussions anymore and this was in mergeable shape. I simply hadn't gotten > around to moving this > into my for-next the last few cy

[PATCH v5 0/3] close_range()

2020-06-02 Thread Christian Brauner
Hey everyone, This is a resend of the close_range() syscall, as discussed in [1]. There weren't any outstanding discussions anymore and this was in mergeable shape. I simply hadn't gotten around to moving this into my for-next the last few cycles and then forgot about it. Thanks to Kyle and the