Re: [PATCH v5 0/3] livepatch: introduce atomic replace

2018-02-01 Thread Petr Mladek
On Wed 2018-01-31 17:09:21, Joe Lawrence wrote: > On 01/30/2018 09:03 AM, Petr Mladek wrote: > > On Fri 2018-01-26 14:29:36, Evgenii Shatokhin wrote: > >> > >> In my experience, it was quite convenient sometimes to just "replace all > >> binary patches the user currently has loaded with this single

Re: [PATCH v5 0/3] livepatch: introduce atomic replace

2018-01-31 Thread Joe Lawrence
On 01/30/2018 09:03 AM, Petr Mladek wrote: > On Fri 2018-01-26 14:29:36, Evgenii Shatokhin wrote: >> >> In my experience, it was quite convenient sometimes to just "replace all >> binary patches the user currently has loaded with this single one". No >> matter what these original binary patches did

Re: [PATCH v5 0/3] livepatch: introduce atomic replace

2018-01-31 Thread Josh Poimboeuf
On Fri, Jan 26, 2018 at 11:23:26AM +0100, Petr Mladek wrote: > So, we are talking about a lot of rather non-trivial code. > IMHO, it might be easier to run just the callbacks from > the new patch. In reality, the author should always know > what it might be replacing and what needs to be done. > >

Re: [PATCH v5 0/3] livepatch: introduce atomic replace

2018-01-31 Thread Miroslav Benes
> IMHO, it might be easier to run just the callbacks from > the new patch. In reality, the author should always know > what it might be replacing and what needs to be done. I agree. I don't see a good solution to the problem. Imagine a crazy situation in which someone would like to patch the ent

Re: [PATCH v5 0/3] livepatch: introduce atomic replace

2018-01-31 Thread Evgenii Shatokhin
On 30.01.2018 22:24, Joe Lawrence wrote: On 01/30/2018 01:19 PM, Jason Baron wrote: [ ... snip ... ] Our main interest in 'atomic replace' is simply to make sure that cumulative patches work as expected in that they 'replace' any prior patches. We have an interest primarily in being able to app

Re: [PATCH v5 0/3] livepatch: introduce atomic replace

2018-01-30 Thread Jason Baron
On 01/30/2018 02:24 PM, Joe Lawrence wrote: > On 01/30/2018 01:19 PM, Jason Baron wrote: >> [ ... snip ... ] >> >> Our main interest in 'atomic replace' is simply to make sure that >> cumulative patches work as expected in that they 'replace' any prior >> patches. We have an interest primarily in

Re: [PATCH v5 0/3] livepatch: introduce atomic replace

2018-01-30 Thread Joe Lawrence
On 01/30/2018 01:19 PM, Jason Baron wrote: > [ ... snip ... ] > > Our main interest in 'atomic replace' is simply to make sure that > cumulative patches work as expected in that they 'replace' any prior > patches. We have an interest primarily in being able to apply patches > from the stable trees

Re: [PATCH v5 0/3] livepatch: introduce atomic replace

2018-01-30 Thread Jason Baron
On 01/30/2018 10:06 AM, Evgenii Shatokhin wrote: > On 30.01.2018 17:03, Petr Mladek wrote: >> On Fri 2018-01-26 14:29:36, Evgenii Shatokhin wrote: >>> On 26.01.2018 13:23, Petr Mladek wrote: On Fri 2018-01-19 16:10:42, Jason Baron wrote: > > > On 01/19/2018 02:20 PM, Evgenii Shat

Re: [PATCH v5 0/3] livepatch: introduce atomic replace

2018-01-30 Thread Evgenii Shatokhin
On 30.01.2018 17:03, Petr Mladek wrote: On Fri 2018-01-26 14:29:36, Evgenii Shatokhin wrote: On 26.01.2018 13:23, Petr Mladek wrote: On Fri 2018-01-19 16:10:42, Jason Baron wrote: On 01/19/2018 02:20 PM, Evgenii Shatokhin wrote: On 12.01.2018 22:55, Jason Baron wrote: There is one more thin

Re: [PATCH v5 0/3] livepatch: introduce atomic replace

2018-01-30 Thread Petr Mladek
On Fri 2018-01-26 14:29:36, Evgenii Shatokhin wrote: > On 26.01.2018 13:23, Petr Mladek wrote: > > On Fri 2018-01-19 16:10:42, Jason Baron wrote: > > > > > > > > > On 01/19/2018 02:20 PM, Evgenii Shatokhin wrote: > > > > On 12.01.2018 22:55, Jason Baron wrote: > > > > There is one more thing that

Re: [PATCH v5 0/3] livepatch: introduce atomic replace

2018-01-26 Thread Evgenii Shatokhin
On 26.01.2018 13:23, Petr Mladek wrote: On Fri 2018-01-19 16:10:42, Jason Baron wrote: On 01/19/2018 02:20 PM, Evgenii Shatokhin wrote: On 12.01.2018 22:55, Jason Baron wrote: There is one more thing that might need attention here. In my experiments with this patch series, I saw that unpatch

Re: [PATCH v5 0/3] livepatch: introduce atomic replace

2018-01-26 Thread Petr Mladek
On Fri 2018-01-19 16:10:42, Jason Baron wrote: > > > On 01/19/2018 02:20 PM, Evgenii Shatokhin wrote: > > On 12.01.2018 22:55, Jason Baron wrote: > > There is one more thing that might need attention here. In my > > experiments with this patch series, I saw that unpatch callbacks are not > > call

Re: [PATCH v5 0/3] livepatch: introduce atomic replace

2018-01-19 Thread Jason Baron
On 01/19/2018 02:20 PM, Evgenii Shatokhin wrote: > On 12.01.2018 22:55, Jason Baron wrote: >> Hi, >>   While using livepatch, I found that when doing cumulative patches, >> if a patched >> function is completed reverted by a subsequent patch (back to its >> original state) >> livepatch does not r

Re: [PATCH v5 0/3] livepatch: introduce atomic replace

2018-01-19 Thread Evgenii Shatokhin
On 12.01.2018 22:55, Jason Baron wrote: Hi, While using livepatch, I found that when doing cumulative patches, if a patched function is completed reverted by a subsequent patch (back to its original state) livepatch does not revert the funtion to its original state. Specifically, if patch A

Re: [PATCH v5 0/3] livepatch: introduce atomic replace

2018-01-19 Thread Petr Mladek
On Fri 2018-01-12 14:55:13, Jason Baron wrote: > Hi, > > While using livepatch, I found that when doing cumulative patches, if a > patched > function is completed reverted by a subsequent patch (back to its original > state) > livepatch does not revert the funtion to its original state. Specifi

[PATCH v5 0/3] livepatch: introduce atomic replace

2018-01-12 Thread Jason Baron
Hi, While using livepatch, I found that when doing cumulative patches, if a patched function is completed reverted by a subsequent patch (back to its original state) livepatch does not revert the funtion to its original state. Specifically, if patch A introduces a change to function 1, and patch