Re: [PATCH v5 00/10] x86/alternative: text_poke() fixes

2018-11-20 Thread Nadav Amit
> On Nov 20, 2018, at 4:42 AM, Peter Zijlstra wrote: > > On Tue, Nov 13, 2018 at 05:07:20AM -0800, Nadav Amit wrote: >> v4->v5: >> - Fix Xen breakage [Damian Tometzki] >> - BUG_ON() when poking_mm initialization fails [PeterZ] >> - Better comments on "x86/mm: temporary mm struct" >> - Cleaner

Re: [PATCH v5 00/10] x86/alternative: text_poke() fixes

2018-11-20 Thread Nadav Amit
> On Nov 20, 2018, at 4:42 AM, Peter Zijlstra wrote: > > On Tue, Nov 13, 2018 at 05:07:20AM -0800, Nadav Amit wrote: >> v4->v5: >> - Fix Xen breakage [Damian Tometzki] >> - BUG_ON() when poking_mm initialization fails [PeterZ] >> - Better comments on "x86/mm: temporary mm struct" >> - Cleaner

Re: [PATCH v5 00/10] x86/alternative: text_poke() fixes

2018-11-20 Thread Peter Zijlstra
On Tue, Nov 13, 2018 at 05:07:20AM -0800, Nadav Amit wrote: > v4->v5: > - Fix Xen breakage [Damian Tometzki] > - BUG_ON() when poking_mm initialization fails [PeterZ] > - Better comments on "x86/mm: temporary mm struct" > - Cleaner removal of the custom poker I'll re-iterate my position: it is

Re: [PATCH v5 00/10] x86/alternative: text_poke() fixes

2018-11-20 Thread Peter Zijlstra
On Tue, Nov 13, 2018 at 05:07:20AM -0800, Nadav Amit wrote: > v4->v5: > - Fix Xen breakage [Damian Tometzki] > - BUG_ON() when poking_mm initialization fails [PeterZ] > - Better comments on "x86/mm: temporary mm struct" > - Cleaner removal of the custom poker I'll re-iterate my position: it is

[PATCH v5 00/10] x86/alternative: text_poke() fixes

2018-11-13 Thread Nadav Amit
This patch-set addresses some issues that might affect the security and the correctness of code patching. The main issue that the patches deal with is the fact that the fixmap PTEs that are used for patching are available for access from other cores and might be exploited. They are not even

[PATCH v5 00/10] x86/alternative: text_poke() fixes

2018-11-13 Thread Nadav Amit
This patch-set addresses some issues that might affect the security and the correctness of code patching. The main issue that the patches deal with is the fact that the fixmap PTEs that are used for patching are available for access from other cores and might be exploited. They are not even