Re: [PATCH v5 00/12] vfio, dax: prevent long term filesystem-dax pins and other fixes

2018-03-02 Thread Dan Williams
On Fri, Mar 2, 2018 at 3:49 PM, Dan Williams wrote: > On Fri, Mar 2, 2018 at 2:57 PM, Christoph Hellwig wrote: >> On Fri, Mar 02, 2018 at 02:21:40PM -0800, Dan Williams wrote: >>> They are indeed a hodge-podge. The problem is that the current >>> IS_DAX() is broken. So I'd like to propose fixing

Re: [PATCH v5 00/12] vfio, dax: prevent long term filesystem-dax pins and other fixes

2018-03-02 Thread Dan Williams
On Fri, Mar 2, 2018 at 2:57 PM, Christoph Hellwig wrote: > On Fri, Mar 02, 2018 at 02:21:40PM -0800, Dan Williams wrote: >> They are indeed a hodge-podge. The problem is that the current >> IS_DAX() is broken. So I'd like to propose fixing IS_DAX() with >> IS_FSDAX() + IS_DEVDAX() for 4.16-rc4 and

Re: [PATCH v5 00/12] vfio, dax: prevent long term filesystem-dax pins and other fixes

2018-03-02 Thread Christoph Hellwig
On Fri, Mar 02, 2018 at 02:21:40PM -0800, Dan Williams wrote: > They are indeed a hodge-podge. The problem is that the current > IS_DAX() is broken. So I'd like to propose fixing IS_DAX() with > IS_FSDAX() + IS_DEVDAX() for 4.16-rc4 and queue up these wider reworks > you propose for the next merge

Re: [PATCH v5 00/12] vfio, dax: prevent long term filesystem-dax pins and other fixes

2018-03-02 Thread Dan Williams
On Fri, Mar 2, 2018 at 2:10 PM, Christoph Hellwig wrote: > I really don't like these IS_DEVDAX and IS_FSDAX flags. We should > stop pretending DAX is a global per-inode choice and get rid of these > magic flags entirely. So please convert the instances inside the > various file systems to checki

Re: [PATCH v5 00/12] vfio, dax: prevent long term filesystem-dax pins and other fixes

2018-03-02 Thread Christoph Hellwig
I really don't like these IS_DEVDAX and IS_FSDAX flags. We should stop pretending DAX is a global per-inode choice and get rid of these magic flags entirely. So please convert the instances inside the various file systems to checking the file system mount options instead. For the core ones we'll

[PATCH v5 00/12] vfio, dax: prevent long term filesystem-dax pins and other fixes

2018-03-01 Thread Dan Williams
Changes since v4 [1]: * Fix the changelog of "dax: introduce IS_DEVDAX() and IS_FSDAX()" to better clarify the need for new helpers (Jan) * Replace dax_sem_is_locked() with dax_sem_assert_held() (Jan) * Use file_inode() in vma_is_dax() (Jan) * Resend the full series to linux-xfs@ (Dave) * Collect