Re: [PATCH v5 00/21] Free some vmemmap pages of hugetlb page

2020-11-23 Thread Matthew Wilcox
On Mon, Nov 23, 2020 at 01:52:13PM -0800, Mike Kravetz wrote: > On 11/22/20 11:38 PM, Michal Hocko wrote: > > On Fri 20-11-20 09:45:12, Mike Kravetz wrote: > >> Not sure if I agree with that last statement. Database and virtualization > >> use cases from my employer allocate allocate hugetlb

Re: [PATCH v5 00/21] Free some vmemmap pages of hugetlb page

2020-11-23 Thread Mike Kravetz
On 11/22/20 11:38 PM, Michal Hocko wrote: > On Fri 20-11-20 09:45:12, Mike Kravetz wrote: >> On 11/20/20 1:43 AM, David Hildenbrand wrote: > [...] > To keep things easy, maybe simply never allow to free these hugetlb pages > again for now? If they were reserved during boot and the vmemmap

Re: [External] Re: [PATCH v5 00/21] Free some vmemmap pages of hugetlb page

2020-11-23 Thread Michal Hocko
On Mon 23-11-20 12:45:13, Matthew Wilcox wrote: > On Mon, Nov 23, 2020 at 11:42:58AM +0100, Michal Hocko wrote: > > On Mon 23-11-20 18:36:33, Muchun Song wrote: > > > > No I really mean that pfn_to_page will give you a struct page pointer > > > > from pages which you release from the vmemmap page

Re: [External] Re: [PATCH v5 00/21] Free some vmemmap pages of hugetlb page

2020-11-23 Thread Matthew Wilcox
On Mon, Nov 23, 2020 at 11:42:58AM +0100, Michal Hocko wrote: > On Mon 23-11-20 18:36:33, Muchun Song wrote: > > > No I really mean that pfn_to_page will give you a struct page pointer > > > from pages which you release from the vmemmap page tables. Those pages > > > might get reused as soon sa

Re: [External] Re: [PATCH v5 00/21] Free some vmemmap pages of hugetlb page

2020-11-23 Thread Michal Hocko
On Mon 23-11-20 20:40:40, Muchun Song wrote: > On Mon, Nov 23, 2020 at 8:18 PM Michal Hocko wrote: > > > > On Mon 23-11-20 20:07:23, Muchun Song wrote: > > > On Mon, Nov 23, 2020 at 7:32 PM Michal Hocko wrote: > > [...] > > > > > > > > No I really mean that pfn_to_page will give you a struct

Re: [External] Re: [PATCH v5 00/21] Free some vmemmap pages of hugetlb page

2020-11-23 Thread Muchun Song
On Mon, Nov 23, 2020 at 8:45 PM Matthew Wilcox wrote: > > On Mon, Nov 23, 2020 at 11:42:58AM +0100, Michal Hocko wrote: > > On Mon 23-11-20 18:36:33, Muchun Song wrote: > > > > No I really mean that pfn_to_page will give you a struct page pointer > > > > from pages which you release from the

Re: [External] Re: [PATCH v5 00/21] Free some vmemmap pages of hugetlb page

2020-11-23 Thread Muchun Song
On Mon, Nov 23, 2020 at 8:18 PM Michal Hocko wrote: > > On Mon 23-11-20 20:07:23, Muchun Song wrote: > > On Mon, Nov 23, 2020 at 7:32 PM Michal Hocko wrote: > [...] > > > > > > > No I really mean that pfn_to_page will give you a struct page > > > > > > > pointer > > > > > > > from pages which

Re: [External] Re: [PATCH v5 00/21] Free some vmemmap pages of hugetlb page

2020-11-23 Thread Michal Hocko
On Mon 23-11-20 20:07:23, Muchun Song wrote: > On Mon, Nov 23, 2020 at 7:32 PM Michal Hocko wrote: [...] > > > > > > No I really mean that pfn_to_page will give you a struct page > > > > > > pointer > > > > > > from pages which you release from the vmemmap page tables. Those > > > > > > pages >

Re: [External] Re: [PATCH v5 00/21] Free some vmemmap pages of hugetlb page

2020-11-23 Thread Muchun Song
On Mon, Nov 23, 2020 at 7:32 PM Michal Hocko wrote: > > On Mon 23-11-20 19:16:18, Muchun Song wrote: > > On Mon, Nov 23, 2020 at 6:43 PM Michal Hocko wrote: > > > > > > On Mon 23-11-20 18:36:33, Muchun Song wrote: > > > > On Mon, Nov 23, 2020 at 5:43 PM Michal Hocko wrote: > > > > > > > > > >

Re: [External] Re: [PATCH v5 00/21] Free some vmemmap pages of hugetlb page

2020-11-23 Thread Michal Hocko
On Mon 23-11-20 19:16:18, Muchun Song wrote: > On Mon, Nov 23, 2020 at 6:43 PM Michal Hocko wrote: > > > > On Mon 23-11-20 18:36:33, Muchun Song wrote: > > > On Mon, Nov 23, 2020 at 5:43 PM Michal Hocko wrote: > > > > > > > > On Mon 23-11-20 16:53:53, Muchun Song wrote: > > > > > On Mon, Nov 23,

Re: [External] Re: [PATCH v5 00/21] Free some vmemmap pages of hugetlb page

2020-11-23 Thread Muchun Song
On Mon, Nov 23, 2020 at 6:43 PM Michal Hocko wrote: > > On Mon 23-11-20 18:36:33, Muchun Song wrote: > > On Mon, Nov 23, 2020 at 5:43 PM Michal Hocko wrote: > > > > > > On Mon 23-11-20 16:53:53, Muchun Song wrote: > > > > On Mon, Nov 23, 2020 at 3:40 PM Michal Hocko wrote: > > > > > > > > > >

Re: [External] Re: [PATCH v5 00/21] Free some vmemmap pages of hugetlb page

2020-11-23 Thread Michal Hocko
On Mon 23-11-20 18:36:33, Muchun Song wrote: > On Mon, Nov 23, 2020 at 5:43 PM Michal Hocko wrote: > > > > On Mon 23-11-20 16:53:53, Muchun Song wrote: > > > On Mon, Nov 23, 2020 at 3:40 PM Michal Hocko wrote: > > > > > > > > On Fri 20-11-20 23:44:26, Muchun Song wrote: > > > > > On Fri, Nov 20,

Re: [External] Re: [PATCH v5 00/21] Free some vmemmap pages of hugetlb page

2020-11-23 Thread Muchun Song
On Mon, Nov 23, 2020 at 5:43 PM Michal Hocko wrote: > > On Mon 23-11-20 16:53:53, Muchun Song wrote: > > On Mon, Nov 23, 2020 at 3:40 PM Michal Hocko wrote: > > > > > > On Fri 20-11-20 23:44:26, Muchun Song wrote: > > > > On Fri, Nov 20, 2020 at 9:11 PM Michal Hocko wrote: > > > > > > > > > >

Re: [External] Re: [PATCH v5 00/21] Free some vmemmap pages of hugetlb page

2020-11-23 Thread Michal Hocko
On Mon 23-11-20 16:53:53, Muchun Song wrote: > On Mon, Nov 23, 2020 at 3:40 PM Michal Hocko wrote: > > > > On Fri 20-11-20 23:44:26, Muchun Song wrote: > > > On Fri, Nov 20, 2020 at 9:11 PM Michal Hocko wrote: > > > > > > > > On Fri 20-11-20 20:40:46, Muchun Song wrote: > > > > > On Fri, Nov 20,

Re: [External] Re: [PATCH v5 00/21] Free some vmemmap pages of hugetlb page

2020-11-23 Thread Muchun Song
On Mon, Nov 23, 2020 at 3:40 PM Michal Hocko wrote: > > On Fri 20-11-20 23:44:26, Muchun Song wrote: > > On Fri, Nov 20, 2020 at 9:11 PM Michal Hocko wrote: > > > > > > On Fri 20-11-20 20:40:46, Muchun Song wrote: > > > > On Fri, Nov 20, 2020 at 4:42 PM Michal Hocko wrote: > > > > > > > > > >

Re: [External] Re: [PATCH v5 00/21] Free some vmemmap pages of hugetlb page

2020-11-22 Thread Michal Hocko
On Fri 20-11-20 23:44:26, Muchun Song wrote: > On Fri, Nov 20, 2020 at 9:11 PM Michal Hocko wrote: > > > > On Fri 20-11-20 20:40:46, Muchun Song wrote: > > > On Fri, Nov 20, 2020 at 4:42 PM Michal Hocko wrote: > > > > > > > > On Fri 20-11-20 14:43:04, Muchun Song wrote: > > > > [...] > > > > > >

Re: [PATCH v5 00/21] Free some vmemmap pages of hugetlb page

2020-11-22 Thread Michal Hocko
On Fri 20-11-20 09:45:12, Mike Kravetz wrote: > On 11/20/20 1:43 AM, David Hildenbrand wrote: [...] > >>> To keep things easy, maybe simply never allow to free these hugetlb pages > >>> again for now? If they were reserved during boot and the vmemmap > >>> condensed, > >>> then just let them

Re: [External] Re: [PATCH v5 00/21] Free some vmemmap pages of hugetlb page

2020-11-21 Thread Muchun Song
On Sat, Nov 21, 2020 at 1:47 AM Mike Kravetz wrote: > > On 11/20/20 1:43 AM, David Hildenbrand wrote: > > On 20.11.20 10:39, Michal Hocko wrote: > >> On Fri 20-11-20 10:27:05, David Hildenbrand wrote: > >>> On 20.11.20 09:42, Michal Hocko wrote: > On Fri 20-11-20 14:43:04, Muchun Song wrote:

Re: [PATCH v5 00/21] Free some vmemmap pages of hugetlb page

2020-11-20 Thread David Hildenbrand
On 20.11.20 18:45, Mike Kravetz wrote: On 11/20/20 1:43 AM, David Hildenbrand wrote: On 20.11.20 10:39, Michal Hocko wrote: On Fri 20-11-20 10:27:05, David Hildenbrand wrote: On 20.11.20 09:42, Michal Hocko wrote: On Fri 20-11-20 14:43:04, Muchun Song wrote: [...] Thanks for improving the

Re: [PATCH v5 00/21] Free some vmemmap pages of hugetlb page

2020-11-20 Thread Mike Kravetz
On 11/20/20 1:43 AM, David Hildenbrand wrote: > On 20.11.20 10:39, Michal Hocko wrote: >> On Fri 20-11-20 10:27:05, David Hildenbrand wrote: >>> On 20.11.20 09:42, Michal Hocko wrote: On Fri 20-11-20 14:43:04, Muchun Song wrote: [...] Thanks for improving the cover letter and

Re: [External] Re: [PATCH v5 00/21] Free some vmemmap pages of hugetlb page

2020-11-20 Thread Muchun Song
On Fri, Nov 20, 2020 at 9:11 PM Michal Hocko wrote: > > On Fri 20-11-20 20:40:46, Muchun Song wrote: > > On Fri, Nov 20, 2020 at 4:42 PM Michal Hocko wrote: > > > > > > On Fri 20-11-20 14:43:04, Muchun Song wrote: > > > [...] > > > > > > Thanks for improving the cover letter and providing some

Re: [External] Re: [PATCH v5 00/21] Free some vmemmap pages of hugetlb page

2020-11-20 Thread Michal Hocko
On Fri 20-11-20 20:40:46, Muchun Song wrote: > On Fri, Nov 20, 2020 at 4:42 PM Michal Hocko wrote: > > > > On Fri 20-11-20 14:43:04, Muchun Song wrote: > > [...] > > > > Thanks for improving the cover letter and providing some numbers. I have > > only glanced through the patchset because I didn't

Re: [External] Re: [PATCH v5 00/21] Free some vmemmap pages of hugetlb page

2020-11-20 Thread Muchun Song
On Fri, Nov 20, 2020 at 4:42 PM Michal Hocko wrote: > > On Fri 20-11-20 14:43:04, Muchun Song wrote: > [...] > > Thanks for improving the cover letter and providing some numbers. I have > only glanced through the patchset because I didn't really have more time > to dive depply into them. > >

Re: [PATCH v5 00/21] Free some vmemmap pages of hugetlb page

2020-11-20 Thread David Hildenbrand
On 20.11.20 10:39, Michal Hocko wrote: On Fri 20-11-20 10:27:05, David Hildenbrand wrote: On 20.11.20 09:42, Michal Hocko wrote: On Fri 20-11-20 14:43:04, Muchun Song wrote: [...] Thanks for improving the cover letter and providing some numbers. I have only glanced through the patchset

Re: [PATCH v5 00/21] Free some vmemmap pages of hugetlb page

2020-11-20 Thread Michal Hocko
On Fri 20-11-20 10:27:05, David Hildenbrand wrote: > On 20.11.20 09:42, Michal Hocko wrote: > > On Fri 20-11-20 14:43:04, Muchun Song wrote: > > [...] > > > > Thanks for improving the cover letter and providing some numbers. I have > > only glanced through the patchset because I didn't really

Re: [PATCH v5 00/21] Free some vmemmap pages of hugetlb page

2020-11-20 Thread David Hildenbrand
On 20.11.20 09:42, Michal Hocko wrote: On Fri 20-11-20 14:43:04, Muchun Song wrote: [...] Thanks for improving the cover letter and providing some numbers. I have only glanced through the patchset because I didn't really have more time to dive depply into them. Overall it looks promissing. To

Re: [PATCH v5 00/21] Free some vmemmap pages of hugetlb page

2020-11-20 Thread Michal Hocko
On Fri 20-11-20 14:43:04, Muchun Song wrote: [...] Thanks for improving the cover letter and providing some numbers. I have only glanced through the patchset because I didn't really have more time to dive depply into them. Overall it looks promissing. To summarize. I would prefer to not have the

[PATCH v5 00/21] Free some vmemmap pages of hugetlb page

2020-11-19 Thread Muchun Song
Hi all, This patch series will free some vmemmap pages(struct page structures) associated with each hugetlbpage when preallocated to save memory. The struct page structures (page structs) are used to describe a physical page frame. By default, there is a one-to-one mapping from a page frame to