Re: [PATCH v5 02/21] libnvdimm, nfit: initial libnvdimm infrastructure and NFIT support

2015-06-09 Thread Dan Williams
On Mon, Jun 8, 2015 at 11:33 PM, h...@lst.de wrote: > On Wed, Jun 03, 2015 at 07:24:34PM +, Williams, Dan J wrote: >> > > +static inline struct acpi_nfit_memory_map *__to_nfit_memdev(struct >> > > nfit_mem *nfit_mem) >> > >> > This line is over 80 characters. >> >> I generally don't see the p

Re: [PATCH v5 02/21] libnvdimm, nfit: initial libnvdimm infrastructure and NFIT support

2015-06-08 Thread h...@lst.de
On Wed, Jun 03, 2015 at 07:24:34PM +, Williams, Dan J wrote: > > > +static inline struct acpi_nfit_memory_map *__to_nfit_memdev(struct > > > nfit_mem *nfit_mem) > > > > This line is over 80 characters. > > I generally don't see the point of fixing up occasional small incursions > over 80 cha

Re: [PATCH v5 02/21] libnvdimm, nfit: initial libnvdimm infrastructure and NFIT support

2015-06-03 Thread Williams, Dan J
On Wed, 2015-06-03 at 16:57 +0200, Christoph Hellwig wrote: > On Mon, Jun 01, 2015 at 08:14:19PM -0400, Dan Williams wrote: > > A libnvdimm bus is the anchor device for registering nvdimm resources and > > interfaces, for example, a character control device, nvdimm devices, > > and I/O region devic

Re: [PATCH v5 02/21] libnvdimm, nfit: initial libnvdimm infrastructure and NFIT support

2015-06-03 Thread Christoph Hellwig
On Mon, Jun 01, 2015 at 08:14:19PM -0400, Dan Williams wrote: > A libnvdimm bus is the anchor device for registering nvdimm resources and > interfaces, for example, a character control device, nvdimm devices, > and I/O region devices. The ACPI NFIT (NVDIMM Firmware Interface Table) > is one possib

[PATCH v5 02/21] libnvdimm, nfit: initial libnvdimm infrastructure and NFIT support

2015-06-01 Thread Dan Williams
A libnvdimm bus is the anchor device for registering nvdimm resources and interfaces, for example, a character control device, nvdimm devices, and I/O region devices. The ACPI NFIT (NVDIMM Firmware Interface Table) is one possible platform description for such non-volatile memory resources in a sy