Re: [PATCH v5 02/21] selftests/resctrl: Fix compilation issues for global variables

2021-03-12 Thread Fenghua Yu
Hi, Babu, On Fri, Mar 12, 2021 at 01:08:31PM -0600, Babu Moger wrote: > > From: Fenghua Yu > > Taking a closer look at the usage of these variables reveals that these > > variables are used only locally to functions such as cqm_resctrl_val() > > %s/ locally to functions/locally in two functions

RE: [PATCH v5 02/21] selftests/resctrl: Fix compilation issues for global variables

2021-03-12 Thread Babu Moger
> -Original Message- > From: Fenghua Yu > Sent: Sunday, March 7, 2021 8:55 AM > To: Shuah Khan ; Tony Luck ; > Reinette Chatre ; Moger, Babu > > Cc: linux-kselftest ; linux-kernel ker...@vger.kernel.org>; Fenghua Yu > Subject: [PATCH v5 02/21] selftes

[PATCH v5 02/21] selftests/resctrl: Fix compilation issues for global variables

2021-03-07 Thread Fenghua Yu
Reinette reported following compilation issue on Fedora 32, gcc version 10.1.1 /usr/bin/ld: cqm_test.o:/cqm_test.c:22: multiple definition of `cache_size'; cat_test.o:/cat_test.c:23: first defined here The same issue is reported for long_mask, cbm_mask, count_of_bits etc variables as well. Compil