Re: [External] Re: [PATCH v5 03/21] mm/hugetlb: Introduce a new config HUGETLB_PAGE_FREE_VMEMMAP

2020-11-20 Thread Muchun Song
On Fri, Nov 20, 2020 at 4:47 PM Michal Hocko wrote: > > On Fri 20-11-20 16:35:16, Muchun Song wrote: > [...] > > > That being said, unless there are huge advantages to introduce a > > > config option I would rather not add it because our config space is huge > > > already and the more we add the m

Re: [External] Re: [PATCH v5 03/21] mm/hugetlb: Introduce a new config HUGETLB_PAGE_FREE_VMEMMAP

2020-11-20 Thread Michal Hocko
On Fri 20-11-20 16:35:16, Muchun Song wrote: [...] > > That being said, unless there are huge advantages to introduce a > > config option I would rather not add it because our config space is huge > > already and the more we add the more future code maintainance that will > > add. If you want the c

Re: [External] Re: [PATCH v5 03/21] mm/hugetlb: Introduce a new config HUGETLB_PAGE_FREE_VMEMMAP

2020-11-20 Thread Muchun Song
On Fri, Nov 20, 2020 at 3:49 PM Michal Hocko wrote: > > On Fri 20-11-20 14:43:07, Muchun Song wrote: > > The purpose of introducing HUGETLB_PAGE_FREE_VMEMMAP is to configure > > whether to enable the feature of freeing unused vmemmap associated > > with HugeTLB pages. Now only support x86. > > Why

Re: [PATCH v5 03/21] mm/hugetlb: Introduce a new config HUGETLB_PAGE_FREE_VMEMMAP

2020-11-19 Thread Michal Hocko
On Fri 20-11-20 14:43:07, Muchun Song wrote: > The purpose of introducing HUGETLB_PAGE_FREE_VMEMMAP is to configure > whether to enable the feature of freeing unused vmemmap associated > with HugeTLB pages. Now only support x86. Why is the config option necessary? Are code savings with the feature

[PATCH v5 03/21] mm/hugetlb: Introduce a new config HUGETLB_PAGE_FREE_VMEMMAP

2020-11-19 Thread Muchun Song
The purpose of introducing HUGETLB_PAGE_FREE_VMEMMAP is to configure whether to enable the feature of freeing unused vmemmap associated with HugeTLB pages. Now only support x86. Signed-off-by: Muchun Song --- arch/x86/mm/init_64.c | 2 +- fs/Kconfig| 14 ++ 2 files chang