Re: [PATCH v5 04/12] sched: Allow all archs to set the capacity_orig

2014-09-11 Thread Preeti U Murthy
On 09/10/2014 07:20 PM, Peter Zijlstra wrote: > On Sat, Aug 30, 2014 at 10:37:40PM +0530, Preeti U Murthy wrote: >>> - if ((sd->flags & SD_SHARE_CPUCAPACITY) && weight > 1) { >>> - if (sched_feat(ARCH_CAPACITY)) >> >> Aren't you missing this check above? I understand that it is not >> c

Re: [PATCH v5 04/12] sched: Allow all archs to set the capacity_orig

2014-09-10 Thread Vincent Guittot
On 10 September 2014 15:50, Peter Zijlstra wrote: > On Sat, Aug 30, 2014 at 10:37:40PM +0530, Preeti U Murthy wrote: >> > - if ((sd->flags & SD_SHARE_CPUCAPACITY) && weight > 1) { >> > - if (sched_feat(ARCH_CAPACITY)) >> >> Aren't you missing this check above? I understand that it is n

Re: [PATCH v5 04/12] sched: Allow all archs to set the capacity_orig

2014-09-10 Thread Peter Zijlstra
On Sat, Aug 30, 2014 at 10:37:40PM +0530, Preeti U Murthy wrote: > > - if ((sd->flags & SD_SHARE_CPUCAPACITY) && weight > 1) { > > - if (sched_feat(ARCH_CAPACITY)) > > Aren't you missing this check above? I understand that it is not > crucial, but that would also mean removing ARCH_CAP

Re: [PATCH v5 04/12] sched: Allow all archs to set the capacity_orig

2014-09-03 Thread Preeti U Murthy
On 09/01/2014 01:35 PM, Vincent Guittot wrote: > On 30 August 2014 19:07, Preeti U Murthy wrote: >> Hi Vincent, >> >> On 08/26/2014 04:36 PM, Vincent Guittot wrote: >>> capacity_orig is only changed for system with a SMT sched_domain level in >>> order >> >> I think I had asked this before, but w

Re: [PATCH v5 04/12] sched: Allow all archs to set the capacity_orig

2014-09-01 Thread Vincent Guittot
On 30 August 2014 19:07, Preeti U Murthy wrote: > Hi Vincent, > > On 08/26/2014 04:36 PM, Vincent Guittot wrote: >> capacity_orig is only changed for system with a SMT sched_domain level in >> order > > I think I had asked this before, but why only capacity_orig? The > capacity of a group is also

Re: [PATCH v5 04/12] sched: Allow all archs to set the capacity_orig

2014-08-30 Thread Preeti U Murthy
Hi Vincent, On 08/26/2014 04:36 PM, Vincent Guittot wrote: > capacity_orig is only changed for system with a SMT sched_domain level in > order I think I had asked this before, but why only capacity_orig? The capacity of a group is also being updated the same way. This patch fixes the capacity of

Re: [PATCH v5 04/12] sched: Allow all archs to set the capacity_orig

2014-08-27 Thread Kamalesh Babulal
* Vincent Guittot [2014-08-26 13:06:47]: > capacity_orig is only changed for system with a SMT sched_domain level in > order > to reflect the lower capacity of CPUs. Heterogenous system also have to > reflect an > original capacity that is different from the default value. > > Create a more ge

[PATCH v5 04/12] sched: Allow all archs to set the capacity_orig

2014-08-26 Thread Vincent Guittot
capacity_orig is only changed for system with a SMT sched_domain level in order to reflect the lower capacity of CPUs. Heterogenous system also have to reflect an original capacity that is different from the default value. Create a more generic function arch_scale_cpu_capacity that can be also us