Re: [PATCH v5 05/21] x86, boot: Calculate decompression size during boot not build

2016-04-15 Thread Kees Cook
On Fri, Apr 15, 2016 at 1:12 AM, Ingo Molnar wrote: > > * Kees Cook wrote: > >> From: Yinghai Lu >> >> Currently z_extract_offset is calculated in boot/compressed/mkpiggy.c. > > What is the high level meaning of z_extract_offset? I cannot tell without > reading > the code - and the point of cha

Re: [PATCH v5 05/21] x86, boot: Calculate decompression size during boot not build

2016-04-15 Thread Ingo Molnar
* Kees Cook wrote: > From: Yinghai Lu > > Currently z_extract_offset is calculated in boot/compressed/mkpiggy.c. What is the high level meaning of z_extract_offset? I cannot tell without reading the code - and the point of changelogs is for them to be readable without having to read the c

[PATCH v5 05/21] x86, boot: Calculate decompression size during boot not build

2016-04-14 Thread Kees Cook
From: Yinghai Lu Currently z_extract_offset is calculated in boot/compressed/mkpiggy.c. This doesn't work well because mkpiggy.c doesn't know the details of the decompressor in use. As a result, it can only make an estimation, which has risks: - output + output_len (VO) could be much bigger tha