Re: [PATCH v5 05/27] arm64: Use daifflag_restore after bp_hardening

2018-10-03 Thread Catalin Marinas
On Tue, Aug 28, 2018 at 04:51:15PM +0100, Julien Thierry wrote: > For EL0 entries requiring bp_hardening, daif status is kept at > DAIF_PROCCTX_NOIRQ until after hardening has been done. Then interrupts > are enabled through local_irq_enable(). > > Before using local_irq_* functions, daifflags sho

Re: [PATCH v5 05/27] arm64: Use daifflag_restore after bp_hardening

2018-09-12 Thread Julien Thierry
On 12/09/18 13:28, James Morse wrote: On 12/09/18 12:11, Julien Thierry wrote: On 12/09/18 11:32, James Morse wrote: On 28/08/18 16:51, Julien Thierry wrote: For EL0 entries requiring bp_hardening, daif status is kept at DAIF_PROCCTX_NOIRQ until after hardening has been done. Then interrupts

Re: [PATCH v5 05/27] arm64: Use daifflag_restore after bp_hardening

2018-09-12 Thread James Morse
Hi Julien, On 12/09/18 12:11, Julien Thierry wrote: > On 12/09/18 11:32, James Morse wrote: >> On 28/08/18 16:51, Julien Thierry wrote: >>> For EL0 entries requiring bp_hardening, daif status is kept at >>> DAIF_PROCCTX_NOIRQ until after hardening has been done. Then interrupts >>> are enabled thr

Re: [PATCH v5 05/27] arm64: Use daifflag_restore after bp_hardening

2018-09-12 Thread Julien Thierry
Hi James, On 12/09/18 11:32, James Morse wrote: Hi Julien, On 28/08/18 16:51, Julien Thierry wrote: For EL0 entries requiring bp_hardening, daif status is kept at DAIF_PROCCTX_NOIRQ until after hardening has been done. Then interrupts are enabled through local_irq_enable(). Before using local

Re: [PATCH v5 05/27] arm64: Use daifflag_restore after bp_hardening

2018-09-12 Thread James Morse
Hi Julien, On 28/08/18 16:51, Julien Thierry wrote: > For EL0 entries requiring bp_hardening, daif status is kept at > DAIF_PROCCTX_NOIRQ until after hardening has been done. Then interrupts > are enabled through local_irq_enable(). > > Before using local_irq_* functions, daifflags should be prop

[PATCH v5 05/27] arm64: Use daifflag_restore after bp_hardening

2018-08-28 Thread Julien Thierry
For EL0 entries requiring bp_hardening, daif status is kept at DAIF_PROCCTX_NOIRQ until after hardening has been done. Then interrupts are enabled through local_irq_enable(). Before using local_irq_* functions, daifflags should be properly restored to a state where IRQs are enabled. Enable IRQs b